Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitserver: grpc: create exhaustive logger for repository service #62158

Conversation

ggilmore
Copy link
Contributor

@ggilmore ggilmore commented Apr 24, 2024

This PR builds on #61270, and adds the request logging funcionality to the repository grpc server in gitserver.

Test plan

Local testing:

Ran env SRC_GITSERVER_EXHAUSTIVE_LOGGING_ENABLED=true SRC_LOG_SCOPE_LEVEL=gitserver.gRPCRequestLogger=debug sg start locally, and saw the following output from the logger in my terminal (note that specifically the repository service is mentioned):

[    gitserver-0] DEBUG gitserver.gRPCRequestLogger internal/server_grpc_logger.go:46 Handled FetchRepository RPC {"server": "gitserver.v1.GitserverRepositoryService", "method": "FetchRepository", "status": "OK", "traceID": "67f1aa837367fa7ea72b164e70a67419", "duration": "1.068438833s", "request": {"repoName": "github.com/sgtest/megarepo"}}

@cla-bot cla-bot bot added the cla-signed label Apr 24, 2024
Copy link
Contributor Author

ggilmore commented Apr 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Apr 24, 2024
@ggilmore ggilmore marked this pull request as ready for review April 24, 2024 16:56
@ggilmore ggilmore marked this pull request as draft April 24, 2024 16:57
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_exhaustive_logger_for_repository_service branch from 0b26aab to 2443801 Compare April 24, 2024 19:50
@ggilmore ggilmore marked this pull request as ready for review April 24, 2024 20:22
@ggilmore ggilmore requested a review from a team April 24, 2024 20:22
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_exhaustive_logger_for_repository_service branch from 2443801 to 5d7fa42 Compare April 24, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants