-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitserver: grpc: create exhaustive logger for repository service #62158
Merged
ggilmore
merged 1 commit into
main
from
04-24-gitserver_grpc_create_exhaustive_logger_for_repository_service
Apr 24, 2024
Merged
gitserver: grpc: create exhaustive logger for repository service #62158
ggilmore
merged 1 commit into
main
from
04-24-gitserver_grpc_create_exhaustive_logger_for_repository_service
Apr 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team/product-platform
team/source
Tickets under the purview of Source - the one Source to graph it all
labels
Apr 24, 2024
ggilmore
force-pushed
the
04-24-gitserver_grpc_create_exhaustive_logger_for_repository_service
branch
from
April 24, 2024 19:50
0b26aab
to
2443801
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_create_exhaustive_logger_for_repository_service
branch
from
April 24, 2024 20:24
2443801
to
5d7fa42
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_create_exhaustive_logger_for_repository_service
branch
from
April 24, 2024 20:37
5d7fa42
to
772f91b
Compare
This was referenced Apr 24, 2024
eseliger
approved these changes
Apr 24, 2024
ggilmore
deleted the
04-24-gitserver_grpc_create_exhaustive_logger_for_repository_service
branch
April 24, 2024 23:04
This was referenced Apr 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-signed
team/product-platform
team/source
Tickets under the purview of Source - the one Source to graph it all
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #61270, and adds the request logging funcionality to the repository grpc server in gitserver.
Test plan
Local testing:
Ran
env SRC_GITSERVER_EXHAUSTIVE_LOGGING_ENABLED=true SRC_LOG_SCOPE_LEVEL=gitserver.gRPCRequestLogger=debug sg start
locally, and saw the following output from the logger in my terminal (note that specifically the repository service is mentioned):