Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symbols: replace usage of gitserver client's DiffSymbols method with new ChangedFiles method #62355

Conversation

ggilmore
Copy link
Contributor

@ggilmore ggilmore commented May 1, 2024

Part of #60654

This PR builds on the new ChangedFiles method introduced in #62354, and changes the symbols service to use it instead of the old custom diff symbols method.

Test plan

Existing CI pipeline

Copy link
Contributor Author

ggilmore commented May 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from 27bd9cc to eaac69f Compare May 1, 2024 21:13
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from f51981a to 26416fd Compare May 1, 2024 21:13
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from eaac69f to 337f48e Compare May 1, 2024 21:18
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from 26416fd to 5de5c61 Compare May 1, 2024 21:18
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from 337f48e to 4da9e89 Compare May 1, 2024 21:21
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from 5de5c61 to 7d0bca6 Compare May 1, 2024 21:21
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from 4da9e89 to a5d3f66 Compare May 1, 2024 21:25
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from 7d0bca6 to ca030e4 Compare May 1, 2024 21:25
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from a5d3f66 to a6d5687 Compare May 1, 2024 21:30
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch 3 times, most recently from f502ebf to 6fcd552 Compare May 1, 2024 22:00
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from 4eefe29 to df57a3e Compare May 6, 2024 19:14
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from 58f11d4 to 153c146 Compare May 6, 2024 19:20
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from df57a3e to 26e5476 Compare May 6, 2024 19:20
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from 153c146 to 17573de Compare May 6, 2024 19:24
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from 26e5476 to 82eb92d Compare May 6, 2024 19:24
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from 17573de to 0af92c9 Compare May 6, 2024 19:38
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from 82eb92d to dbaafc4 Compare May 6, 2024 19:38
cmd/symbols/gitserver/client.go Outdated Show resolved Hide resolved
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from 0af92c9 to 6eb1d2f Compare May 6, 2024 21:55
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from dbaafc4 to c500f80 Compare May 6, 2024 21:55
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from 6eb1d2f to cb06748 Compare May 6, 2024 23:28
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from c500f80 to 709a735 Compare May 6, 2024 23:28
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from cb06748 to 9c74216 Compare May 6, 2024 23:35
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from 709a735 to e6c1a79 Compare May 6, 2024 23:35
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from 9c74216 to aa9ed29 Compare May 6, 2024 23:50
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from e6c1a79 to 30a7eca Compare May 6, 2024 23:50
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from aa9ed29 to 41f212e Compare May 7, 2024 03:47
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch 2 times, most recently from 210d915 to 1302c03 Compare May 7, 2024 16:13
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from 41f212e to 5f646f0 Compare May 7, 2024 16:16
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from 1302c03 to 970a1e5 Compare May 7, 2024 16:16
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from 5f646f0 to 1bb89ac Compare May 7, 2024 16:17
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from 970a1e5 to 93d3419 Compare May 7, 2024 16:18
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from 1bb89ac to a54db0c Compare May 7, 2024 17:44
Base automatically changed from 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client to main May 7, 2024 17:58
@ggilmore ggilmore force-pushed the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch from 93d3419 to f404f6c Compare May 7, 2024 17:59
Copy link
Contributor Author

ggilmore commented May 7, 2024

Merge activity

  • May 7, 1:59 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • May 7, 2:08 PM EDT: @ggilmore merged this pull request with Graphite.

@ggilmore ggilmore merged commit fc03ac9 into main May 7, 2024
15 checks passed
@ggilmore ggilmore deleted the 05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method branch May 7, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants