New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
symbols: replace usage of gitserver client's DiffSymbols method with new ChangedFiles method #62355
Merged
ggilmore
merged 1 commit into
main
from
05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method
May 7, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 1, 2024
github-actions
bot
added
team/product-platform
team/source
Tickets under the purview of Source - the one Source to graph it all
labels
May 1, 2024
This was referenced May 1, 2024
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 1, 2024 21:13
27bd9cc
to
eaac69f
Compare
ggilmore
force-pushed
the
05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method
branch
from
May 1, 2024 21:13
f51981a
to
26416fd
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 1, 2024 21:18
eaac69f
to
337f48e
Compare
ggilmore
force-pushed
the
05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method
branch
from
May 1, 2024 21:18
26416fd
to
5de5c61
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 1, 2024 21:21
337f48e
to
4da9e89
Compare
ggilmore
force-pushed
the
05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method
branch
from
May 1, 2024 21:21
5de5c61
to
7d0bca6
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 1, 2024 21:25
4da9e89
to
a5d3f66
Compare
ggilmore
force-pushed
the
05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method
branch
from
May 1, 2024 21:25
7d0bca6
to
ca030e4
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 1, 2024 21:30
a5d3f66
to
a6d5687
Compare
ggilmore
force-pushed
the
05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method
branch
3 times, most recently
from
May 1, 2024 22:00
f502ebf
to
6fcd552
Compare
ggilmore
force-pushed
the
05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method
branch
from
May 6, 2024 19:14
4eefe29
to
df57a3e
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 6, 2024 19:20
58f11d4
to
153c146
Compare
ggilmore
force-pushed
the
05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method
branch
from
May 6, 2024 19:20
df57a3e
to
26e5476
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 6, 2024 19:24
153c146
to
17573de
Compare
ggilmore
force-pushed
the
05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method
branch
from
May 6, 2024 19:24
26e5476
to
82eb92d
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 6, 2024 19:38
17573de
to
0af92c9
Compare
ggilmore
force-pushed
the
05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method
branch
from
May 6, 2024 19:38
82eb92d
to
dbaafc4
Compare
eseliger
approved these changes
May 6, 2024
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 6, 2024 21:55
0af92c9
to
6eb1d2f
Compare
ggilmore
force-pushed
the
05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method
branch
from
May 6, 2024 21:55
dbaafc4
to
c500f80
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 6, 2024 23:28
6eb1d2f
to
cb06748
Compare
ggilmore
force-pushed
the
05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method
branch
from
May 6, 2024 23:28
c500f80
to
709a735
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 6, 2024 23:35
cb06748
to
9c74216
Compare
ggilmore
force-pushed
the
05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method
branch
from
May 6, 2024 23:35
709a735
to
e6c1a79
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 6, 2024 23:50
9c74216
to
aa9ed29
Compare
ggilmore
force-pushed
the
05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method
branch
from
May 6, 2024 23:50
e6c1a79
to
30a7eca
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 7, 2024 03:47
aa9ed29
to
41f212e
Compare
ggilmore
force-pushed
the
05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method
branch
2 times, most recently
from
May 7, 2024 16:13
210d915
to
1302c03
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 7, 2024 16:16
41f212e
to
5f646f0
Compare
ggilmore
force-pushed
the
05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method
branch
from
May 7, 2024 16:16
1302c03
to
970a1e5
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 7, 2024 16:17
5f646f0
to
1bb89ac
Compare
ggilmore
force-pushed
the
05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method
branch
from
May 7, 2024 16:18
970a1e5
to
93d3419
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 7, 2024 17:44
1bb89ac
to
a54db0c
Compare
Base automatically changed from
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
to
main
May 7, 2024 17:58
…new ChangedFiles method
ggilmore
force-pushed
the
05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method
branch
from
May 7, 2024 17:59
93d3419
to
f404f6c
Compare
ggilmore
deleted the
05-01-symbols_replace_usage_of_gitserver_client_s_diffsymbols_method_with_new_changedfiles_method
branch
May 7, 2024 18:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-signed
team/product-platform
team/source
Tickets under the purview of Source - the one Source to graph it all
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #60654
This PR builds on the new ChangedFiles method introduced in #62354, and changes the symbols service to use it instead of the old custom diff symbols method.
Test plan
Existing CI pipeline