Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitserver: grpc: swap client implementation of GetAheadBehind from Exec to bespoke gRPC endpoint #62217

Conversation

ggilmore
Copy link
Contributor

@ggilmore ggilmore commented Apr 26, 2024

Closes #62101

This PR swaps the gitserver client implemenation of GetBehindAhead to use the new bespoke endpoint introduced in #62216 instead of the all-encompasing exec endpoint.

Test plan

  • Unit tests

Copy link
Contributor Author

ggilmore commented Apr 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Apr 26, 2024
@ggilmore ggilmore marked this pull request as ready for review April 26, 2024 21:10
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 75c2c85 to 5a836f7 Compare April 26, 2024 21:13
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch 2 times, most recently from 74aa0a7 to 503a475 Compare April 26, 2024 21:16
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 5a836f7 to 7fa75c2 Compare April 26, 2024 21:19
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 503a475 to afec55e Compare April 26, 2024 21:19
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 7fa75c2 to 811c697 Compare April 29, 2024 19:24
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from afec55e to d02b395 Compare April 29, 2024 19:24
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 811c697 to 33260ee Compare April 30, 2024 05:16
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from d02b395 to 39e5cfb Compare April 30, 2024 05:16
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 33260ee to 9ce3bb2 Compare April 30, 2024 05:19
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 39e5cfb to 3e6f221 Compare April 30, 2024 05:20
internal/gitserver/commands.go Outdated Show resolved Hide resolved
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 9ce3bb2 to 50df291 Compare April 30, 2024 17:03
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 3e6f221 to ca768ec Compare April 30, 2024 17:03
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 50df291 to a780150 Compare April 30, 2024 17:14
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from ca768ec to dd16782 Compare April 30, 2024 17:15
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from a780150 to 48d352b Compare April 30, 2024 18:06
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 1740b89 to 15bf6fb Compare May 1, 2024 21:17
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 6b57f46 to 3e9b113 Compare May 1, 2024 21:21
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 15bf6fb to 9ffa2d5 Compare May 1, 2024 21:21
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 3e9b113 to 0102189 Compare May 1, 2024 21:25
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 9ffa2d5 to 34cd911 Compare May 1, 2024 21:25
Copy link

graphite-app bot commented May 2, 2024

TV gif. Ty Burrell as Phil on Modern Family bites his lip as he gives a thumbs up, then points at us as he says, 'Yeah.' (Added via Giphy)

Copy link

graphite-app bot commented May 2, 2024

Graphite Automations

"Post a GIF when PR approved" took an action on this PR • (05/02/24)

1 gif was posted to this PR based on Geoffrey Gilmore's automation.

@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 0102189 to da929c9 Compare May 2, 2024 17:43
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 34cd911 to b56c84d Compare May 2, 2024 17:43
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from da929c9 to 33edcd2 Compare May 2, 2024 17:45
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch 2 times, most recently from 0ed26eb to 1762bcd Compare May 2, 2024 18:04
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from c1f0c1e to b43579c Compare May 2, 2024 18:18
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 1762bcd to 9c1c0ad Compare May 2, 2024 18:18
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from b43579c to 429025c Compare May 2, 2024 18:23
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 9c1c0ad to ea74865 Compare May 2, 2024 18:24
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 429025c to 11f62c4 Compare May 2, 2024 18:26
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from ea74865 to 226ef53 Compare May 2, 2024 18:26
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead branch from 11f62c4 to aa22c02 Compare May 3, 2024 16:48
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 226ef53 to 9a67eff Compare May 3, 2024 16:48
Base automatically changed from 04-26-gitserver_grpc_create_server_implementation_for_getbehindahead to main May 3, 2024 17:04
@ggilmore ggilmore force-pushed the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch from 9a67eff to 3c952f2 Compare May 3, 2024 17:18
Copy link
Contributor Author

ggilmore commented May 3, 2024

Merge activity

  • May 3, 1:18 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 3, 1:27 PM EDT: @ggilmore merged this pull request with Graphite.

@ggilmore ggilmore merged commit c1fc7c0 into main May 3, 2024
12 checks passed
@ggilmore ggilmore deleted the 04-26-gitserver_grpc_swap_client_implementation_of_getaheadbehind_from_exec_to_bespoke_grpc_endpoint branch May 3, 2024 17:27
burmudar pushed a commit that referenced this pull request May 6, 2024
…ec to bespoke gRPC endpoint (#62217)

Closes #62101

This PR swaps the gitserver client implemenation of GetBehindAhead to use the new bespoke endpoint introduced in #62216 instead of the all-encompasing `exec` endpoint.

## Test plan

- Unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gitserver: Move GetBehindAhead to new gRPC pattern
2 participants