Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitserver: grpc: create changed files RPC implementation for gRPC server #62262

Conversation

ggilmore
Copy link
Contributor

@ggilmore ggilmore commented Apr 30, 2024

Part of #60654

This PR implements a new gitserver gRPC method, ChangedFiles that lists the files that changed between two commits alonside their added/modified/deleted status. This PR builds on the functionality exposed in #62252.

Test plan

Unit tests

Copy link
Contributor Author

ggilmore commented Apr 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Apr 30, 2024
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 75dd653 to 18d4bba Compare April 30, 2024 05:20
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from f9ac891 to 629d3f0 Compare April 30, 2024 05:20
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 18d4bba to 7a9e364 Compare April 30, 2024 17:03
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from 629d3f0 to 952cf93 Compare April 30, 2024 17:03
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 7a9e364 to 319d6a9 Compare April 30, 2024 17:15
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from 952cf93 to 8ac1945 Compare April 30, 2024 17:15
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 319d6a9 to d8cb7fe Compare April 30, 2024 18:06
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from 8ac1945 to d52b616 Compare April 30, 2024 18:06
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from d8cb7fe to 59cae3e Compare April 30, 2024 19:21
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from d52b616 to 5a3ca00 Compare April 30, 2024 19:21
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 59cae3e to 43d8723 Compare April 30, 2024 19:22
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from 5a3ca00 to 0fdeabd Compare April 30, 2024 19:22
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 43d8723 to 9e1c79e Compare April 30, 2024 19:37
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch 2 times, most recently from 008dec5 to e8dc0b0 Compare April 30, 2024 20:05
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 9e1c79e to cf8b5d1 Compare April 30, 2024 20:07
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from e8dc0b0 to 31b2232 Compare April 30, 2024 20:07
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from 5ffa9ac to c1c6a66 Compare May 2, 2024 18:24
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 4dc9626 to 29d032e Compare May 2, 2024 18:26
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from c1c6a66 to 7871416 Compare May 2, 2024 18:26
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 29d032e to 2b94c9e Compare May 2, 2024 18:39
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from 7871416 to a852048 Compare May 2, 2024 18:39
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 2b94c9e to 95ae787 Compare May 2, 2024 18:53
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from a852048 to 0298d9f Compare May 2, 2024 18:53
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 95ae787 to 8a62f4f Compare May 3, 2024 16:48
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from 0298d9f to 58b9854 Compare May 3, 2024 16:48
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 8a62f4f to 04ebcb0 Compare May 3, 2024 22:03
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch 2 times, most recently from 8b3d845 to e490d50 Compare May 6, 2024 18:16
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 04ebcb0 to 09a543b Compare May 6, 2024 19:37
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from e490d50 to 804cbdd Compare May 6, 2024 19:37
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 09a543b to b7a9f82 Compare May 6, 2024 21:55
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from 804cbdd to 7a61aa2 Compare May 6, 2024 21:55
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from b7a9f82 to 469da92 Compare May 6, 2024 23:28
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch 2 times, most recently from 6248ab5 to b8070d0 Compare May 6, 2024 23:50
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 469da92 to 6f8daa5 Compare May 7, 2024 03:47
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from b8070d0 to 85a0105 Compare May 7, 2024 03:47
@ggilmore ggilmore force-pushed the 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func branch from 6f8daa5 to 1326bb8 Compare May 7, 2024 16:17
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from 85a0105 to fbb2877 Compare May 7, 2024 16:17
Base automatically changed from 04-29-gitserver_grpc_port_diffsymbols_from_client_as_new_gitbackend.changedfiles_func to main May 7, 2024 17:32
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from fbb2877 to 53c8d36 Compare May 7, 2024 17:33
Copy link
Contributor Author

ggilmore commented May 7, 2024

Merge activity

  • May 7, 1:33 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • May 7, 1:43 PM EDT: @ggilmore merged this pull request with Graphite.

@ggilmore ggilmore merged commit 5f81856 into main May 7, 2024
13 checks passed
@ggilmore ggilmore deleted the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch May 7, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants