Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency prettier to v3 #24255

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 13, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
prettier (source) ^2.8.1 -> ^3.0.0 age adoption passing confidence
@​types/prettier ^2.0.0 -> ^3.0.0 age adoption passing confidence
prettier (source) ^2.2.1 -> ^3.0.0 age adoption passing confidence
prettier (source) ^2.6.2 -> ^3.0.0 age adoption passing confidence

Release Notes

prettier/prettier (prettier)

v3.2.5

Compare Source

diff

Support Angular inline styles as single template literal (#​15968 by @​sosukesuzuki)

Angular v17 supports single string inline styles.

// Input
@​Component({
  template: `<div>...</div>`,
  styles: `h1 { color: blue; }`,
})
export class AppComponent {}

// Prettier 3.2.4
@&#8203;Component({
  template: `<div>...</div>`,
  styles: `h1 { color: blue; }`,
})
export class AppComponent {}

// Prettier 3.2.5
@&#8203;Component({
  template: `<div>...</div>`,
  styles: `
    h1 {
      color: blue;
    }
  `,
})
export class AppComponent {}
Unexpected embedded formatting for Angular template (#​15969 by @​JounQin)

Computed template should not be considered as Angular component template

// Input
const template = "foobar";

@&#8203;Component({
  [template]: `<h1>{{       hello }}</h1>`,
})
export class AppComponent {}

// Prettier 3.2.4
const template = "foobar";

@&#8203;Component({
  [template]: `<h1>{{ hello }}</h1>`,
})
export class AppComponent {}

// Prettier 3.2.5
const template = "foobar";

@&#8203;Component({
  [template]: `<h1>{{       hello }}</h1>`,
})
export class AppComponent {}
Use "json" parser for tsconfig.json by default (#​16012 by @​sosukesuzuki)

In v2.3.0, we introduced "jsonc" parser which adds trialing comma by default.

When adding a new parser we also define how it will be used based on the linguist-languages data.

tsconfig.json is a special file used by TypeScript, it uses .json file extension, but it actually uses the JSON with Comments syntax. However, we found that there are many third-party tools not recognize it correctly because of the confusing .json file extension.

We decide to treat it as a JSON file for now to avoid the extra configuration step.

To keep using the "jsonc" parser for your tsconfig.json files, add the following to your .pretterrc file

{
  "overrides": [
    {
      "files": ["tsconfig.json", "jsconfig.json"],
      "options": {
        "parser": "jsonc"
      }
    }
  ]
}

v3.2.4

Compare Source

diff

Fix incorrect parser inference (#​15947 by @​fisker)

Files like .eslintrc.json were incorrectly formatted as JSONC files.

// Input
prettier --file-info .eslintrc.json
{ "ignored": false, "inferredParser": "jsonc" }

// Prettier 3.2.4
prettier --file-info .eslintrc.json
{ "ignored": false, "inferredParser": "json" }

v3.2.3

Compare Source

diff

Throw errors for invalid code (#​15881 by @​fisker, @​Josh-Cena, @​auvred)
// Input
1++;

// Prettier 3.2.2
1++;

// Prettier 3.2.3
SyntaxError: Invalid left-hand side expression in unary operation (1:1)
> 1 | 1++;
    | ^
// Input
try {} catch (error = 1){}

// Prettier 3.2.2
try {
} catch (error) {}

// Prettier 3.2.3
SyntaxError: Catch clause variable cannot have an initializer. (1:23)
> 1 | try {} catch (error = 1){}
    |                       ^
Fix parser inference (#​15927 by @​fisker)
// Prettier 3.2.2
prettier --file-info tsconfig.json
{ "ignored": false, "inferredParser": "json" }

// Prettier 3.2.3
prettier --file-info tsconfig.json
{ "ignored": false, "inferredParser": "jsonc" }

v3.2.2

Compare Source

diff

Fix crash when parsing template literal CSS in a JSX style tag using a spread attribute (#​15896 by @​eelco)

For example this code would crash before:

<style {...spread}>{`.{}`}</style>
Fix formatting error on optional call expression and member chain (#​15920 by @​sosukesuzuki)
// Input
a(() => {}, c?.d());

// Prettier 3.2.1
TypeError: Cannot read properties of undefined (reading 'type')

// Prettier 3.2.2
a(() => {}, c?.d());

v3.2.1

Compare Source

diff

Fix formatting error on member chain (#​15915 by @​sosukesuzuki)
// Input
test().test2().test2(thing?.something);

// Prettier 3.2.0
TypeError: Cannot read properties of undefined (reading 'type')

// Prettier 3.2.1
test().test2().test2(thing?.something);

v3.2.0

Compare Source

diff

🔗 Release Notes

v3.1.1

Compare Source

diff

Fix config file search (#​15363 by @​fisker)

Previously, we start search for config files from the filePath as a directory, if it happened to be a directory and contains config file, it will be used by mistake.

├─ .prettierrc
└─ test.js         (A directory)
  └─ .prettierrc
// Prettier 3.1.0
await prettier.resolveConfigFile(new URL("./test.js", import.meta.url));
// <CWD>/test.js/.prettierrc

// Prettier 3.1.1
await prettier.resolveConfigFile(new URL("./test.js", import.meta.url));
// <CWD>/.prettierrc
Skip explicitly passed symbolic links with --no-error-on-unmatched-pattern (#​15533 by @​sanmai-NL)

Since Prettier v3, we stopped following symbolic links, however in some use cases, the symbolic link patterns can't be filtered out, and there is no way to prevent Prettier from throwing errors.

In Prettier 3.1.1, you can use --no-error-on-unmatched-pattern to simply skip symbolic links.

Consistently use tabs in ternaries when useTabs is true (#​15662 by @​auvred)
// Input
aaaaaaaaaaaaaaa
	? bbbbbbbbbbbbbbbbbb
	: ccccccccccccccc
	  ? ddddddddddddddd
	  : eeeeeeeeeeeeeee
	    ? fffffffffffffff
	    : gggggggggggggggg;

// Prettier 3.1.0
aaaaaaaaaaaaaaa
	? bbbbbbbbbbbbbbbbbb
	: ccccccccccccccc
	  ? ddddddddddddddd
	  : eeeeeeeeeeeeeee
	    ? fffffffffffffff
	    : gggggggggggggggg;

// Prettier 3.1.1
aaaaaaaaaaaaaaa
	? bbbbbbbbbbbbbbbbbb
	: ccccccccccccccc
		? ddddddddddddddd
		: eeeeeeeeeeeeeee
			? fffffffffffffff
			: gggggggggggggggg;
Improve config file search (#​15663 by @​fisker)

The Prettier config file search performance has been improved by more effective cache strategy.

Fix unstable and ugly formatting for comments in destructuring patterns (#​15708 by @​sosukesuzuki)
// Input
const {
  foo,
  // bar
  // baz
}: Foo = expr;

// Prettier 3.1.0
const {
  foo1,
} // bar
// baz
: Foo = expr;

// Prettier 3.1.0 second output
const {
  foo1, // bar
} // baz
: Foo = expr;

// Prettier 3.1.1
const {
  foo1,
  // bar
  // baz
}: Foo = expr;
Support "Import Attributes" (#​15718 by @​fisker)

TypeScript 5.3 supports the latest updates to the import attributes proposal.

import something from "./something.json" with { type: "json" };
Fix false claim in docs that cursorOffset is incompatible with rangeStart/rangeEnd (#​15750 by @​ExplodingCabbage)

The cursorOffset option has in fact been compatible with rangeStart/rangeEnd for over 5 years, thanks to work by @​ds300. However, Prettier's documentation (including the CLI --help text) continued to claim otherwise, falsely. The documentation is now fixed.

Keep curly braces and from keyword in empty import statements (#​15756 by @​fisker)
// Input
import { } from 'foo';
import { /* comment */ } from 'bar';

// Prettier 3.1.0
import {} from "foo";
import /* comment */ "bar";

// Prettier 3.1.1
import {} from "foo";
import {} from /* comment */ "bar";
Keep empty import attributes and assertions (#​15757 by @​fisker)
// Input
import foo from "foo" with {};
import bar from "bar" assert {};

// Prettier 3.1.0
import foo from "foo";
import bar from "bar";

// Prettier 3.1.1
import foo from "foo" with {};
import bar from "bar" assert {};

v3.1.0

Compare Source

diff

🔗 Release Notes

v3.0.3

Compare Source

diff

Add preferUnplugged: true to package.json (#​15169 by @​fisker and @​so1ve)

Prettier v3 uses dynamic imports, user will need to unplug Prettier when Yarn's PnP mode is enabled, add preferUnplugged: true to package.json, so Yarn will install Prettier as unplug by default.

Support shared config that forbids require() (#​15233 by @​fisker)

If an external shared config package is used, and the package exports don't have require or default export.

In Prettier 3.0.2 Prettier fails when attempt to require() the package, and throws an error.

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: No "exports" main defined in <packageName>/package.json
Allow argument of require() to break (#​15256 by @​fisker)
// Input
const plugin = require(
  global.STANDALONE
    ? path.join(__dirname, "../standalone.js")
    : path.join(__dirname, "..")
);

// Prettier 3.0.2
const plugin = require(global.STANDALONE
  ? path.join(__dirname, "../standalone.js")
  : path.join(__dirname, ".."));

// Prettier 3.0.3
const plugin = require(
  global.STANDALONE
    ? path.join(__dirname, "../standalone.js")
    : path.join(__dirname, "..")
);
Do not print trailing commas in arrow function type parameter lists in ts code blocks (#​15286 by @​sosukesuzuki)
<!-- Input -->
```ts
const foo = <T>() => {}
```

<!-- Prettier 3.0.2 -->
```ts
const foo = <T,>() => {}
```

<!-- Prettier 3.0.3 -->
```ts
const foo = <T>() => {}
```
Support TypeScript 5.2 using / await using declaration (#​15321 by @​sosukesuzuki)

Support for the upcoming Explicit Resource Management feature in ECMAScript. using / await using declaration

{
   using foo = new Foo();
   await using bar = new Bar();
}

v3.0.2

Compare Source

diff

Break after = of assignment if RHS is poorly breakable AwaitExpression or YieldExpression (#​15204 by @​seiyab)
// Input
const { section, rubric, authors, tags } = await utils.upsertCommonData(mainData);

// Prettier 3.0.1
const { section, rubric, authors, tags } = await utils.upsertCommonData(
  mainData,
);

// Prettier 3.0.2
const { section, rubric, authors, tags } =
  await utils.upsertCommonData(mainData);
Do not add trailing comma for grouped scss comments (#​15217 by @​auvred)
/* Input */
$foo: (
	'property': (),
	// comment 1
	// comment 2
)

/* Prettier 3.0.1 */
$foo: (
  "property": (),
  // comment 1
  // comment 2,
);

/* Prettier 3.0.2 */
$foo: (
  "property": (),
  // comment 1
  // comment 2
);
Print declare and export keywords for nested namespace (#​15249 by @​sosukesuzuki)
// Input
declare namespace abc1.def {}
export namespace abc2.def {}

// Prettier 3.0.1
namespace abc1.def {}
namespace abc2.def {}

// Prettier 3.0.2
declare namespace abc1.def {}
export namespace abc2.def {}

v3.0.1

Compare Source

diff

Fix cursor positioning for a special case (#​14812 by @​fisker)
// <|> is the cursor position

/* Input */
// All messages are represented in JSON.
// So, the prettier.py controls a subprocess which spawns "node {this_file}".
import {<|>  } from "fs"

/* Prettier 3.0.0 */
// All messages are represented in JSON.
// So, the prettier.py <|>controls a subprocess which spawns "node {this_file}".
import {} from "fs"

/* Prettier 3.0.1 */
// All messages are represented in JSON.
// So, the prettier.py controls a subprocess which spawns "node {this_file}".
import {<|>} from "fs"
Fix plugins/estree.d.ts to make it a module (#​15018 by @​kingyue737)

Add export {} in plugins/estree.d.ts to fix the "File is not a module" error

Add parenthesis around leading multiline comment in return statement (#​15037 by @​auvred)
// Input
function fn() {
  return (
    /**
     * @&#8203;type {...}
     */ expresssion
  )
}

// Prettier 3.0.0
function fn() {
  return /**
   * @&#8203;type {...}
   */ expresssion;
}

// Prettier 3.0.1
function fn() {
  return (
    /**
     * @&#8203;type {...}
     */ expresssion
  );
}
Add support for Vue "Generic Components" (#​15066 by @​auvred)

https://blog.vuejs.org/posts/vue-3-3#generic-components

<!-- Input -->
<script setup lang="ts" generic="T extends Type1 & Type2 & (Type3 | Type4), U extends string | number | boolean"></script>

<!-- Prettier 3.0.0 -->
<script
  setup
  lang="ts"
  generic="T extends Type1 & Type2 & (Type3 | Type4), U extends string | number | boolean"
></script>

<!-- Prettier 3.0.1 -->
<script
  setup
  lang="ts"
  generic="
    T extends Type1 & Type2 & (Type3 | Type4),
    U extends string | number | boolean
  "
></script>
Fix comments print in IfStatement (#​15076 by @​fisker)
function a(b) {
  if (b) return 1; // comment
  else return 2;
}

/* Prettier 3.0.0 */
Error: Comment "comment" was not printed. Please report this error!

/* Prettier 3.0.1 */
function a(b) {
  if (b) return 1; // comment
  else return 2;
}
Add missing type definition for printer.preprocess (#​15123 by @​so1ve)
export interface Printer<T = any> {
  // ...
+ preprocess?:
+   | ((ast: T, options: ParserOptions<T>) => T | Promise<T>)
+   | undefined;
}
Add missing getVisitorKeys method type definition for Printer (#​15125 by @​auvred)
const printer: Printer = {
  print: () => [],
  getVisitorKeys(node, nonTraversableKeys) {
    return ["body"];
  },
};
Add typing to support readonly array properties of AST Node (#​15127 by @​auvred)
// Input
interface TestNode {
  readonlyArray: readonly string[];
}

declare const path: AstPath<TestNode>;

path.map(() => "", "readonlyArray");

// Prettier 3.0.0
interface TestNode {
  readonlyArray: readonly string[];
}

declare const path: AstPath<TestNode>;

path.map(() => "", "readonlyArray");
//                  ^ Argument of type '"readonlyArray"' is not assignable to parameter of type '"regularArray"'. ts(2345)

// Prettier 3.0.1
interface TestNode {
  readonlyArray: readonly string[];
}

declare const path: AstPath<TestNode>;

path.map(() => "", "readonlyArray");
Add space before unary minus followed by a function call (#​15129 by @​pamelalozano)
// Input
div {
  margin: - func();
}

// Prettier 3.0.0
div {
  margin: -func();
}

// Prettier 3.0.1
div {
  margin: - func();
}

v3.0.0

Compare Source

diff

🔗 Release Notes


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested review from backstage-service and a team as code owners April 13, 2024 20:21
@renovate renovate bot added the dependencies Pull requests that update a dependency file label Apr 13, 2024
@github-actions github-actions bot added the microsite Changes to backstage.io label Apr 13, 2024
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Apr 13, 2024

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @backstage/backend-app-api
  • @backstage/backend-common
  • @backstage/backend-dynamic-feature-service
  • @backstage/backend-openapi-utils
  • @backstage/cli
  • @backstage/config-loader
  • @backstage/core-compat-api
  • @backstage/core-components
  • @backstage/core-plugin-api
  • @backstage/create-app
  • @backstage/eslint-plugin
  • @backstage/frontend-plugin-api
  • @backstage/integration
  • @techdocs/cli
  • @backstage/plugin-auth-backend
  • @backstage/plugin-catalog-backend-module-backstage-openapi
  • @backstage/plugin-catalog-backend-module-gcp
  • @backstage/plugin-catalog-backend-module-incremental-ingestion
  • @backstage/plugin-catalog-backend-module-ldap
  • @backstage/plugin-catalog-backend
  • @backstage/plugin-catalog-common
  • @backstage/plugin-catalog-graph
  • @backstage/plugin-catalog-import
  • @backstage/plugin-catalog-react
  • @backstage/plugin-catalog-unprocessed-entities
  • @backstage/plugin-catalog
  • @backstage/plugin-kubernetes-backend
  • @backstage/plugin-kubernetes-react
  • @backstage/plugin-permission-common
  • @backstage/plugin-permission-node
  • @backstage/plugin-scaffolder-backend-module-cookiecutter
  • @backstage/plugin-scaffolder-backend
  • @backstage/plugin-scaffolder-react
  • @backstage/plugin-scaffolder
  • @backstage/plugin-techdocs-backend
  • @backstage/plugin-techdocs-node
  • @backstage/plugin-techdocs

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
example-app-next packages/app-next none v0.0.11
example-app packages/app none v0.2.97
@backstage/backend-app-api packages/backend-app-api none v0.7.3
@backstage/backend-common packages/backend-common none v0.22.0
@backstage/backend-dynamic-feature-service packages/backend-dynamic-feature-service none v0.2.10
@backstage/backend-openapi-utils packages/backend-openapi-utils none v0.1.11
@backstage/cli packages/cli none v0.26.5
@backstage/config-loader packages/config-loader none v1.8.0
@backstage/core-compat-api packages/core-compat-api none v0.2.5
@backstage/core-components packages/core-components none v0.14.7
@backstage/core-plugin-api packages/core-plugin-api none v1.9.2
@backstage/create-app packages/create-app none v0.5.15
@backstage/eslint-plugin packages/eslint-plugin none v0.1.8
@backstage/frontend-plugin-api packages/frontend-plugin-api none v0.6.5
@backstage/integration packages/integration none v1.11.0
@backstage/repo-tools packages/repo-tools patch v0.9.0
techdocs-cli-embedded-app packages/techdocs-cli-embedded-app none v0.2.96
@techdocs/cli packages/techdocs-cli none v1.8.11
@backstage/plugin-auth-backend plugins/auth-backend none v0.22.5
@backstage/plugin-catalog-backend-module-backstage-openapi plugins/catalog-backend-module-backstage-openapi none v0.2.1
@backstage/plugin-catalog-backend-module-gcp plugins/catalog-backend-module-gcp none v0.1.19
@backstage/plugin-catalog-backend-module-incremental-ingestion plugins/catalog-backend-module-incremental-ingestion none v0.4.23
@backstage/plugin-catalog-backend-module-ldap plugins/catalog-backend-module-ldap none v0.5.34
@backstage/plugin-catalog-backend plugins/catalog-backend none v1.22.0
@backstage/plugin-catalog-common plugins/catalog-common none v1.0.23
@backstage/plugin-catalog-graph plugins/catalog-graph none v0.4.5
@backstage/plugin-catalog-import plugins/catalog-import none v0.11.0
@backstage/plugin-catalog-react plugins/catalog-react none v1.12.0
@backstage/plugin-catalog-unprocessed-entities plugins/catalog-unprocessed-entities none v0.2.4
@backstage/plugin-catalog plugins/catalog none v1.20.0
@backstage/plugin-kubernetes-backend plugins/kubernetes-backend none v0.17.1
@backstage/plugin-kubernetes-react plugins/kubernetes-react none v0.3.5
@backstage/plugin-permission-common plugins/permission-common none v0.7.13
@backstage/plugin-permission-node plugins/permission-node none v0.7.29
@backstage/plugin-scaffolder-backend-module-cookiecutter plugins/scaffolder-backend-module-cookiecutter none v0.2.42
@backstage/plugin-scaffolder-backend plugins/scaffolder-backend none v1.22.6
@backstage/plugin-scaffolder-react plugins/scaffolder-react none v1.8.5
@backstage/plugin-scaffolder plugins/scaffolder none v1.20.0
@backstage/plugin-techdocs-backend plugins/techdocs-backend none v1.10.5
@backstage/plugin-techdocs-node plugins/techdocs-node none v1.12.4
@backstage/plugin-techdocs plugins/techdocs none v1.10.5

Copy link
Contributor

github-actions bot commented Apr 13, 2024

Uffizzi Ephemeral Environment - Virtual Cluster

Your cluster pr-24255 was successfully created. Learn more about Uffizzi virtual clusters
To connect to this cluster, follow these steps:

  1. Download and install the Uffizzi CLI from https://docs.uffizzi.com/install
  2. Login to Uffizzi, then select the backstage account and project:
uffizzi login
Select an account: 
  ‣ backstage
    jdoe

Select a project or create a new project: 
  ‣ backstage-6783521
  1. Update your kubeconfig: uffizzi cluster update-kubeconfig pr-24255 --kubeconfig=[PATH_TO_KUBECONFIG]
    After updating your kubeconfig, you can manage your cluster with kubectl, kustomize, helm, and other tools that use kubeconfig files: kubectl get namespace --kubeconfig [PATH_TO_KUBECONFIG]

Access the backstage endpoint at https://backstage-default-pr-24255-c4993.uclusters.app.uffizzi.com

@renovate renovate bot changed the title chore(deps): update dependency prettier to v3 Update dependency prettier to v3 Apr 14, 2024
@renovate renovate bot changed the title Update dependency prettier to v3 chore(deps): update dependency prettier to v3 Apr 14, 2024
@freben
Copy link
Member

freben commented Apr 15, 2024

I started working a bit on this one, but it turned out to be a bit messy. It still formats the api-report files slightly differently. Hoping to continue a bit later.

Copy link
Contributor Author

renovate bot commented Apr 15, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@renovate renovate bot requested a review from a team as a code owner April 16, 2024 13:34
@github-actions github-actions bot added the area:techdocs Related to the TechDocs Project Area label Apr 16, 2024
@freben
Copy link
Member

freben commented Apr 17, 2024

current status: needs this to be released and then an upgrade made in our lockfile fisker/make-synchronized#44

EDIT: done

@renovate renovate bot requested review from a team as code owners April 17, 2024 10:38
@github-actions github-actions bot added the area:permission Related to the Permission Project Area label Apr 17, 2024
@renovate renovate bot requested review from a team, kuangp and alde as code owners April 17, 2024 12:59
@github-actions github-actions bot added BEP Backstage Enhancement Proposals and removed area:kubernetes Related to the Kubernetes Project Area - not deploying Backstage with k8s. search Things related to Search homepage Features for the composable homepage area:scaffolder Everything and all things related to the scaffolder project area area:permission Related to the Permission Project Area area:discoverability Related to the Discoverability Project Area labels Apr 30, 2024
@github-actions github-actions bot added area:catalog Related to the Catalog Project Area auth area:kubernetes Related to the Kubernetes Project Area - not deploying Backstage with k8s. search Things related to Search homepage Features for the composable homepage area:scaffolder Everything and all things related to the scaffolder project area area:permission Related to the Permission Project Area area:discoverability Related to the Discoverability Project Area labels Apr 30, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 30, 2024
@freben freben force-pushed the renovate/prettier-3.x branch 4 times, most recently from fc7af3c to 85bff16 Compare May 6, 2024 13:09
Copy link
Member

@benjdlambert benjdlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but just a question about breaking?

@@ -0,0 +1,6 @@
---
'@backstage/repo-tools': patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a breaking change if people now need to create a .prettierrc.yaml?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was that this should still keep working with prettier 2 if that's what you're depending on in your repo, because that resolve call should just return nothing if the file doesn't exist. Maybe worth triple checking ... Gimme a sec to verify again

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK let's go back to draft until i have time to look at this again

@freben freben marked this pull request as draft May 7, 2024 10:28
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
Copy link
Contributor

github-actions bot commented Jun 4, 2024

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:catalog Related to the Catalog Project Area area:discoverability Related to the Discoverability Project Area area:kubernetes Related to the Kubernetes Project Area - not deploying Backstage with k8s. area:permission Related to the Permission Project Area area:scaffolder Everything and all things related to the scaffolder project area area:techdocs Related to the TechDocs Project Area auth BEP Backstage Enhancement Proposals dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation homepage Features for the composable homepage microsite Changes to backstage.io search Things related to Search stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants