Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: showSaveDialogSync fails assertion #31152

Closed
3 tasks done
legraphista opened this issue Sep 27, 2021 · 12 comments
Closed
3 tasks done

[Bug]: showSaveDialogSync fails assertion #31152

legraphista opened this issue Sep 27, 2021 · 12 comments

Comments

@legraphista
Copy link

Preflight Checklist

Electron Version

14.0.1

What operating system are you using?

Ubuntu

Operating System Version

20.10

What arch are you using?

x64

Last Known Working Electron version

13.4.0

Expected Behavior

dialog.showSaveDialogSync opens a save dialog

Actual Behavior

dialog.showSaveDialogSync is ignored and throws a console warning

[293296:0927/191734.375994:ERROR:browser_main_loop.cc(269)] Gtk: gtk_native_dialog_run: assertion '!priv->visible' failed

Testcase Gist URL

https://gist.github.com/legraphista/7498e518f623da1c20fed241d55e538d

Additional Information

No response

@rooklift
Copy link

From the report I had, I believe showOpenDialogSync is also affected. (Can't check myself, no easy access to Linux.)

@legraphista
Copy link
Author

From the report I had, I believe showOpenDialogSync is also affected. (Can't check myself, no easy access to Linux.)

Can confirm, dialog.showOpenDialogSync(mainWindow); does not work

[9896:0929/110120.256968:ERROR:browser_main_loop.cc(269)] Gtk: gtk_native_dialog_run: assertion '!priv->visible' failed

@nicarl
Copy link

nicarl commented Oct 7, 2021

We see the same issue in https://github.com/opossum-tool/OpossumUI for showOpenDialogSync, but only for running under Linux. macOS does not seem to have problems.

nicarl added a commit to opossum-tool/OpossumUI that referenced this issue Oct 7, 2021
There is a bug (electron/electron#31152) which does not allow to open files under linux. Downgrade as long as the

Signed-off-by: Nico <nicocarl@protonmail.com>
nicarl added a commit to opossum-tool/OpossumUI that referenced this issue Oct 7, 2021
There is a bug (electron/electron#31152) which does not allow to open files under linux. Downgrade as long as the issue exists.

Signed-off-by: Nico <nicocarl@protonmail.com>
@livthomas
Copy link

I have run into the very same issue with Electron 15.1.2 on Manjaro Linux (Gnome 40.4.0).

@alchemicas
Copy link

alchemicas commented Oct 16, 2021

Can confirm that this issue also happens on an up-to-date archlinux distro with gnome, I've tried 14.x, 15.x, 16.x electron versions and they all have this same problem, the native dialogs only work on the latest 13.x release.

Everything worked correctly on macos with the latest 15.x release though.

@iomari
Copy link

iomari commented Oct 26, 2021

greetings,
When I click on any of the import options, nothing happens:

I'm using joplin 2.5.4 on linux.

When I run joplin from terminal to see if there is anerror whenperforming this action, I get:
[486954:1025/201110.445029:ERROR:browser_main_loop.cc(269)] Gtk: gtk_native_dialog_run: assertion '!priv->visible' failed

PalmerAL added a commit to minbrowser/min that referenced this issue Oct 30, 2021
LegendaryLinux added a commit to ArchipelagoMW/Z3Client that referenced this issue Oct 31, 2021
LegendaryLinux added a commit to ArchipelagoMW/SuperMetroidClient that referenced this issue Oct 31, 2021
PalmerAL added a commit to minbrowser/min that referenced this issue Nov 2, 2021
@mathieulj
Copy link

I just ran into this myself. I tracked the failure to bring up the file picker down to a change between v14.0.0-nightly.20210401...v14.0.0-nightly.20210402 there is one commit in that range that seems like a likely culprit: fa65faa. There might be more at play since that version didn't exhibit the assertion error in the console but I wonder if this might be the root cause.

@justkowal
Copy link

Any solutions for this issue?

@DomiStyle
Copy link

This also affects Electron Fiddle since v0.27.0.

Which is not good, the preferred way to create example apps for bug reports in Electron has a bug which makes saving impossible now.

@livthomas
Copy link

I can no longer reproduce this problem in either Electron 16.0.8 or 17.0.0.

It looks like it has already been fixed in all affected major versions (14+). See issue #31997.

@deepak1556
Copy link
Member

Fix has been landed in 14.2.3, 15.3.4, 16.0.5. Merging to #31997

@logicguy1
Copy link

I encountered this error on ArchLinux electron v. 21.1.1

julian-alarcon added a commit to julian-alarcon/prospect-mail that referenced this issue Jul 24, 2023
* resolved package.json conflict

* fix window-controlled require electron to match recent changed in mainstream.

* fix package json about-window requirement

* #189 Force nodeIntegration and  contextIsolation to let require works again.

* Undo Force nodeIntegration and  contextIsolation to let require works again.

* fix package.json doubled lines

* #189 forced contextIsolation: false and nodeIntegration: true to let "require" workson client side.

* UnreadNumberObserver is now in a separated js file

* UnreadNumberObserver is now in a separated js file fix performance cache

* UnreadNumberObserver better tassonomy

* client js and css are now in a separated  file. Using clientInjector to load, cache and inject them.

* Multiple unreadMessageObserver handler.

* Integrated did-create-window and child-window.js suggested by @joax

* Better client injector strategy. Moved all clinet files into /public dir

* #122, #173 Added context menu wilth Editing actions.

* #122 Context menu will show first 50 chars of the clicked link url

* context-menu: undo will appear only on editable element.

* try fix clear unreadmessageicon in some cases OWA

* unread-observer "custom_2": attempting to be multilanguage

* #10 fixed Right click on child windows.

* #10 fixed Right click on child windows.

* update electron to "^16.0.5" in order to fix annoying bug described here electron/electron#31152

* update electron to "^16.0.9" in order to fix annoying bug described here electron/electron#31152

---------

Co-authored-by: Julian Alarcon <jalarcon@lendingfront.com>
Co-authored-by: Julian Alarcon <alarconj@gmail.com>
julian-alarcon pushed a commit to julian-alarcon/prospect-mail that referenced this issue Nov 2, 2023
julian-alarcon pushed a commit to julian-alarcon/prospect-mail that referenced this issue Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

13 participants