Remove support for positional args in graphql/execute/subscribe func #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
added
the
PR: breaking change 💥
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Feb 20, 2021
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Mar 24, 2021
Removal of positional args was done in graphql#2904 but TS typings were not updated.
IvanGoncharov
added a commit
that referenced
this pull request
Mar 24, 2021
Removal of positional args was done in #2904 but TS typings were not updated.
1 task
benjamn
added a commit
to apollographql/react-apollo-error-template
that referenced
this pull request
Nov 22, 2021
Similar to changes made by @brainkim in apollographql/apollo-client#8997, this commit fixes the React Apollo template application when built with graphql@16, since support for passing positional arguments was removed in graphql/graphql-js#2904.
benjamn
added a commit
to apollographql/react-apollo-error-template
that referenced
this pull request
Nov 22, 2021
Similar to changes made by @brainkim in apollographql/apollo-client#8997, this commit fixes the React Apollo template application when built with graphql@16, since support for passing positional arguments was removed in graphql/graphql-js#2904.
6 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2301