Parse request body when using X-HTTP-Method-Override header

[eyasy1217]

References to other Issues or PRs

Fixes #3688

Have you read the Contributing Guidelines?

Yes

Brief description of what is fixed or changed

Fix to parse request body when using X-HTTP-Method-Override header

Other comments

Summary by CodeRabbit

• Bug Fixes

  • Improved logic flow for HTTP method override in conjunction with form parsing.

• Tests

  • Added tests to ensure proper behavior of form parsing with HTTP method override.

[coderabbitai]

Walkthrough

The modification addresses a bug where HTTP form data was not being parsed correctly when using the X-HTTP-Method-Override header. The core change involves adjusting the sequence of operations in the request handling to ensure form data is parsed before the request method is overridden. Additionally, a new test has been added to verify that the form parsing works as intended with the method override.

Changes

File	Change Summary
runtime/mux.go	Moved r.Method assignment inside an if block after form parsing logic
runtime/mux_test.go	Added test TestServeHTTP_WithMethodOverrideAndFormParsing for method override with form parsing

Assessment against linked issues

Objective	Addressed	Explanation
Identify and fix the bug with X-HTTP-Method-Override header handling (#3688)	✅
Ensure r.Method is set after r.ParseForm() to allow body parsing with method override (#3688)	✅
Reproduce the issue and validate the fix with a test case (#3688)	✅

Poem

Amidst the code, a bug did hide, 🐛
With method override, it did collide.
A rabbit hopped through logic deep, 🐇💻
Fixed the flow, now forms can leap! 📝✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 359dc11 and baab8aa.

Files selected for processing (2)

• runtime/mux.go (1 hunks)
• runtime/mux_test.go (1 hunks)

Additional comments: 2

runtime/mux.go (1)

• 350-350: The assignment of r.Method has been moved after the r.ParseForm() call, which is consistent with the PR's objective to ensure form data is parsed correctly when an HTTP method override is specified.

runtime/mux_test.go (1)

• 610-621: A new test TestServeHTTP_WithMethodOverrideAndFormParsing has been added to verify that form parsing behaves as expected when the HTTP method is overridden. This test is crucial for validating the fix and ensuring no regression in the future.

[johanbrandhorst]

LGTM

[johanbrandhorst]

Thanks for your contribution!