feat: deprecate some APIs toward v5 #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fc3752b:
|
|
Size Change: +1.71 kB (+5%) 🔍 Total Size: 38.7 kB
ℹ️ View Unchanged
|
kiputgalak
approved these changes
Nov 3, 2022
|
What would be the next steps to continue this pr ? |
|
Hm, maybe I leave it open for a month or so, and then eventually merge it and release a minor version (v4.2.0). So, questions are welcome in the mean time. (I think |
|
Let's do this along with #1514. |
charkour
reviewed
Jan 9, 2023
| @@ -6,7 +6,7 @@ nav: 18 | |||
| A special `createContext` is provided since v3.5, | |||
| which avoids misusing the store hook. | |||
|
|
|||
| > **Note**: This function will likely be deprecated in v4 and removed in v5. | |||
| > **Note**: This function will be deprecated in v4 and removed in v5. | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Does this createContext function miss-use React APIs? Or is it a performance aspect? Or do you simply not want to manage this code anymore?
Thank you.
There was a problem hiding this comment.
In v3, we only have one create function that creates a React hook.
Passing it via context (or props) can violate the rules of hooks. To avoid misusing it, createContext in v3.5 is carefully implemented so that it can't break the rules of hooks.
In v4, we provide a new general hook useStore along with createStore to create a vanilla store without React hooks.
These APIs are more React-ish, and recommended to use over zustand/context workaround. There's no risks to violate the rules of hooks. As we don't want to teach two usages, zustand/context is being deprecated and will be removed in v5.
So, the short answer is it's no longer necessary.
You are absolutely fine to keep it as a third-party package. The helper function could be useful for a pattern.
There was a problem hiding this comment.
so are you saying the migration path would be to call createStore and put the result into your own context? Can you maybe show how a replacement of zustand/context would look like?
There was a problem hiding this comment.
Good point. I answered it in one of discussions, but that should be in docs too.
There was a problem hiding this comment.
Would be interested too on how to replace/migrate.
My main usecase is that I need zustand state per instance rather than global.
|
thanks for maintaining this project, I'm wondering the roadmap of the v5 |
There's still no plan about v5, but I feel like waiting until |
kodiakhq bot
pushed a commit
to mheob/ef-calc
that referenced
this pull request
Jan 30, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@mheob/eslint-config](https://togithub.com/mheob/config/tree/main/packages/eslint-config) ([source](https://togithub.com/mheob/config)) | [`^4.0.0` -> `^4.1.0`](https://renovatebot.com/diffs/npm/@mheob%2feslint-config/4.0.0/4.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/react](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`^18.0.26` -> `^18.0.27`](https://renovatebot.com/diffs/npm/@types%2freact/18.0.26/18.0.27) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@vitejs/plugin-react](https://togithub.com/vitejs/vite-plugin-react/tree/main/packages/plugin-react#readme) ([source](https://togithub.com/vitejs/vite-plugin-react)) | [`^3.0.0` -> `^3.0.1`](https://renovatebot.com/diffs/npm/@vitejs%2fplugin-react/3.0.0/3.0.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [eslint](https://eslint.org) ([source](https://togithub.com/eslint/eslint)) | [`^8.30.0` -> `^8.32.0`](https://renovatebot.com/diffs/npm/eslint/8.30.0/8.32.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [prettier](https://prettier.io) ([source](https://togithub.com/prettier/prettier)) | [`^2.8.1` -> `^2.8.3`](https://renovatebot.com/diffs/npm/prettier/2.8.1/2.8.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [vite](https://togithub.com/vitejs/vite/tree/main/#readme) ([source](https://togithub.com/vitejs/vite)) | [`^4.0.3` -> `^4.0.4`](https://renovatebot.com/diffs/npm/vite/4.0.3/4.0.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [zustand](https://togithub.com/pmndrs/zustand) | [`^4.1.5` -> `^4.3.2`](https://renovatebot.com/diffs/npm/zustand/4.1.5/4.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mheob/config</summary> ### [`v4.1.0`](https://togithub.com/mheob/config/releases/tag/%40mheob/eslint-config%404.1.0) [Compare Source](https://togithub.com/mheob/config/compare/@mheob/eslint-config@4.0.0...@mheob/eslint-config@4.1.0) ##### Minor Changes - add auto-fix for unused imports and vars --> ([#​106](https://togithub.com/mheob/config/pull/106)) by [@​mheob](https://togithub.com/mheob) ##### Patch Changes - bump `eslint-config-next` to `13.1.0` --> ([#​106](https://togithub.com/mheob/config/pull/106)) by [@​mheob](https://togithub.com/mheob) </details> <details> <summary>vitejs/vite-plugin-react</summary> ### [`v3.0.1`](https://togithub.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#small301-2023-01-05-small) [Compare Source](https://togithub.com/vitejs/vite-plugin-react/compare/0aaf2e56de64d566af9636877200029ec6437918...d758a2a44b0a2cb3c206fa61166cda9d5cf58221) - fix: don't invalidate when code is invalid ([#​67](https://togithub.com/vitejs/vite-plugin-react/issues/67)) ([9231a86](https://togithub.com/vitejs/vite-plugin-react/commit/9231a86)), closes [#​67](https://togithub.com/vitejs/vite-plugin-react/issues/67) - fix(deps): update all non-major dependencies ([#​69](https://togithub.com/vitejs/vite-plugin-react/issues/69)) ([0a8e099](https://togithub.com/vitejs/vite-plugin-react/commit/0a8e099)), closes [#​69](https://togithub.com/vitejs/vite-plugin-react/issues/69) </details> <details> <summary>eslint/eslint</summary> ### [`v8.32.0`](https://togithub.com/eslint/eslint/releases/tag/v8.32.0) [Compare Source](https://togithub.com/eslint/eslint/compare/v8.31.0...v8.32.0) #### Features - [`fc20f24`](https://togithub.com/eslint/eslint/commit/fc20f242a2ac073b5af6d5fca67e07a175f36c3b) feat: add suggestions for redundant wrapping in prefer-regex-literals ([#​16658](https://togithub.com/eslint/eslint/issues/16658)) (YeonJuan) #### Bug Fixes - [`b4f8329`](https://togithub.com/eslint/eslint/commit/b4f8329164d7b293a1557e05b987d2a685fe1d30) fix: ignore directives for no-fallthrough ([#​16757](https://togithub.com/eslint/eslint/issues/16757)) (gfyoung) #### Documentation - [`17b65ad`](https://togithub.com/eslint/eslint/commit/17b65ad10d653bb05077f21d8b1f79bee96e38d8) docs: IA Update page URL move ([#​16665](https://togithub.com/eslint/eslint/issues/16665)) (Ben Perlmutter) - [`5981296`](https://togithub.com/eslint/eslint/commit/5981296d5c7c86228ad766009901191fdd87d5a4) docs: fix theme switcher button ([#​16752](https://togithub.com/eslint/eslint/issues/16752)) (Sam Chen) - [`6669413`](https://togithub.com/eslint/eslint/commit/66694136b67277c050bd27f60050779687a88c9f) docs: deploy prerelease docs under the `/docs/next/` path ([#​16541](https://togithub.com/eslint/eslint/issues/16541)) (Nitin Kumar) - [`78ecfe0`](https://togithub.com/eslint/eslint/commit/78ecfe0e52c0e5780fefc8dc9a98864e48de6637) docs: use inline code for rule options name ([#​16768](https://togithub.com/eslint/eslint/issues/16768)) (Percy Ma) - [`fc2ea59`](https://togithub.com/eslint/eslint/commit/fc2ea598aee97beb6d768866da1ee4f63775f0c9) docs: Update README (GitHub Actions Bot) - [`762a872`](https://togithub.com/eslint/eslint/commit/762a8727fb3b5619cff900826053b643ca5f1162) docs: Update README (GitHub Actions Bot) #### Chores - [`2952d6e`](https://togithub.com/eslint/eslint/commit/2952d6ed95811ce0971b6855d66fb7a9767a7b72) chore: sync templates/\*.md files with issue templates ([#​16758](https://togithub.com/eslint/eslint/issues/16758)) (gfyoung) - [`3e34418`](https://togithub.com/eslint/eslint/commit/3e34418b31664decfb2337de798feafbf985b66c) chore: Add new issues to triage project ([#​16740](https://togithub.com/eslint/eslint/issues/16740)) (Nicholas C. Zakas) ### [`v8.31.0`](https://togithub.com/eslint/eslint/releases/tag/v8.31.0) [Compare Source](https://togithub.com/eslint/eslint/compare/v8.30.0...v8.31.0) #### Features - [`52c7c73`](https://togithub.com/eslint/eslint/commit/52c7c73c052e1ec2528c6b4af78181bc30cf8cdd) feat: check assignment patterns in no-underscore-dangle ([#​16693](https://togithub.com/eslint/eslint/issues/16693)) (Milos Djermanovic) - [`b401cde`](https://togithub.com/eslint/eslint/commit/b401cde47d44746ff91b8feced3fb3a4e32c0e12) feat: add options to check destructuring in no-underscore-dangle ([#​16006](https://togithub.com/eslint/eslint/issues/16006)) (Morten Kaltoft) - [`30d0daf`](https://togithub.com/eslint/eslint/commit/30d0daf55e85a412995f6d69f47cab3fb591f2c3) feat: group properties with values in parentheses in `key-spacing` ([#​16677](https://togithub.com/eslint/eslint/issues/16677)) (Francesco Trotta) #### Bug Fixes - [`35439f1`](https://togithub.com/eslint/eslint/commit/35439f1572e1a8888f7feb6c5e51a15b5582495d) fix: correct syntax error in `prefer-arrow-callback` autofix ([#​16722](https://togithub.com/eslint/eslint/issues/16722)) (Francesco Trotta) - [`87b2470`](https://togithub.com/eslint/eslint/commit/87b247058ed520061fe1a146b7f0e7072a94990d) fix: new instance of FlatESLint should load latest config file version ([#​16608](https://togithub.com/eslint/eslint/issues/16608)) (Milos Djermanovic) #### Documentation - [`4339dc4`](https://togithub.com/eslint/eslint/commit/4339dc462d78888fe2e10acdfacd6f57245ce6ae) docs: Update README (GitHub Actions Bot) - [`4e4049c`](https://togithub.com/eslint/eslint/commit/4e4049c5fa355b2091afc8948690fcd7b1c1e6df) docs: optimize code block structure ([#​16669](https://togithub.com/eslint/eslint/issues/16669)) (Sam Chen) - [`54a7ade`](https://togithub.com/eslint/eslint/commit/54a7ade5d8e6f59554afeb9202ba6143f8afdf57) docs: do not escape code blocks of formatters examples ([#​16719](https://togithub.com/eslint/eslint/issues/16719)) (Sam Chen) - [`e5ecfef`](https://togithub.com/eslint/eslint/commit/e5ecfefa1c952195a3a8371f5953cc655d844079) docs: Add function call example for no-undefined ([#​16712](https://togithub.com/eslint/eslint/issues/16712)) (Elliot Huffman) - [`a3262f0`](https://togithub.com/eslint/eslint/commit/a3262f0a6305d2a721fac137a60c62c019b26aa4) docs: Add mastodon link ([#​16638](https://togithub.com/eslint/eslint/issues/16638)) (Amaresh S M) - [`a14ccf9`](https://togithub.com/eslint/eslint/commit/a14ccf91af1122e419710f58ef494980fc4894b3) docs: clarify files property ([#​16709](https://togithub.com/eslint/eslint/issues/16709)) (Sam Chen) - [`3b29eb1`](https://togithub.com/eslint/eslint/commit/3b29eb14e00182614c986d8498b483a9917976e7) docs: fix npm link ([#​16710](https://togithub.com/eslint/eslint/issues/16710)) (Abdullah Osama) - [`a638673`](https://togithub.com/eslint/eslint/commit/a638673ee6e94344c46d12dfc988adeb3783f817) docs: fix search bar focus on `Esc` ([#​16700](https://togithub.com/eslint/eslint/issues/16700)) (Shanmughapriyan S) - [`f62b722`](https://togithub.com/eslint/eslint/commit/f62b722251858a5dfb157591910edbaaeb4a966f) docs: country flag missing in windows ([#​16698](https://togithub.com/eslint/eslint/issues/16698)) (Shanmughapriyan S) - [`4d27ec6`](https://togithub.com/eslint/eslint/commit/4d27ec6019847afabeebf592dddc014e9220057c) docs: display zh-hans in the docs language switcher ([#​16686](https://togithub.com/eslint/eslint/issues/16686)) (Percy Ma) - [`8bda20e`](https://togithub.com/eslint/eslint/commit/8bda20e8276c6ba17d31842fcdd63ba65476fbbd) docs: remove manually maintained anchors ([#​16685](https://togithub.com/eslint/eslint/issues/16685)) (Percy Ma) - [`b68440f`](https://togithub.com/eslint/eslint/commit/b68440ff2b8322fc00373792701169205c94ed94) docs: User Guide Getting Started expansion ([#​16596](https://togithub.com/eslint/eslint/issues/16596)) (Ben Perlmutter) #### Chores - [`65d4e24`](https://togithub.com/eslint/eslint/commit/65d4e24c36367cd63f0eba7371820e0e81dae7aa) chore: Upgrade [@​eslint/eslintrc](https://togithub.com/eslint/eslintrc)[@​1](https://togithub.com/1).4.1 ([#​16729](https://togithub.com/eslint/eslint/issues/16729)) (Brandon Mills) - [`8d93081`](https://togithub.com/eslint/eslint/commit/8d93081a717f6e8b8cb60c3075cc1d7e4e655e6b) chore: fix CI failure ([#​16721](https://togithub.com/eslint/eslint/issues/16721)) (Sam Chen) - [`8f17247`](https://togithub.com/eslint/eslint/commit/8f17247a93240ff8a08980d8e06352e4ff4e8fe3) chore: Set up automatic updating of README ([#​16717](https://togithub.com/eslint/eslint/issues/16717)) (Nicholas C. Zakas) - [`4cd87cb`](https://togithub.com/eslint/eslint/commit/4cd87cb3c52412277577ba00c4fbb1aec36acc8c) ci: bump actions/stale from 6 to 7 ([#​16713](https://togithub.com/eslint/eslint/issues/16713)) (dependabot\[bot]) - [`fd20c75`](https://togithub.com/eslint/eslint/commit/fd20c75b1059c54d598c0abaf63e7d7a80f04f32) chore: sort package.json scripts in alphabetical order ([#​16705](https://togithub.com/eslint/eslint/issues/16705)) (Darius Dzien) - [`10a5c78`](https://togithub.com/eslint/eslint/commit/10a5c7839370219c79f44d4206cbd7c28a72bad5) chore: update ignore patterns in `eslint.config.js` ([#​16678](https://togithub.com/eslint/eslint/issues/16678)) (Milos Djermanovic) </details> <details> <summary>prettier/prettier</summary> ### [`v2.8.3`](https://togithub.com/prettier/prettier/blob/HEAD/CHANGELOG.md#​283) [Compare Source](https://togithub.com/prettier/prettier/compare/2.8.2...2.8.3) [diff](https://togithub.com/prettier/prettier/compare/2.8.2...2.8.3) ##### Allow self-closing tags on custom elements ([#​14170](https://togithub.com/prettier/prettier/pull/14170) by [@​fisker](https://togithub.com/fisker)) See [Angular v15.1.0 release note](https://togithub.com/angular/angular/releases/tag/15.1.0) for details. ```html // Input <app-test/> // Prettier 2.8.2 SyntaxError: Only void and foreign elements can be self closed "app-test" (1:1) > 1 | <app-test/> | ^^^^^^^^^ 2 | // Prettier 2.8.3 <app-test /> ``` ### [`v2.8.2`](https://togithub.com/prettier/prettier/blob/HEAD/CHANGELOG.md#​282) [Compare Source](https://togithub.com/prettier/prettier/compare/2.8.1...2.8.2) [diff](https://togithub.com/prettier/prettier/compare/2.8.1...2.8.2) ##### Don't lowercase link references ([#​13155](https://togithub.com/prettier/prettier/pull/13155) by [@​DerekNonGeneric](https://togithub.com/DerekNonGeneric) & [@​fisker](https://togithub.com/fisker)) ```markdown <!-- Input --> We now don't strictly follow the release notes format suggested by [Keep a Changelog]. [Keep a Changelog]: https://example.com/ <!-- Prettier 2.8.1 --> We now don't strictly follow the release notes format suggested by [Keep a Changelog]. [keep a changelog]: https://example.com/ <!-- ^^^^^^^^^^^^^^^^^^ lowercased --> <!-- Prettier 2.8.2 --> <Same as input> ``` ##### Preserve self-closing tags ([#​13691](https://togithub.com/prettier/prettier/pull/13691) by [@​dcyriller](https://togithub.com/dcyriller)) ```hbs {{! Input }} <div /> <div></div> <custom-component /> <custom-component></custom-component> <i /> <i></i> <Component /> <Component></Component> {{! Prettier 2.8.1 }} <div></div> <div></div> <custom-component></custom-component> <custom-component></custom-component> <i></i> <i></i> <Component /> <Component /> {{! Prettier 2.8.2 }} <div /> <div></div> <custom-component /> <custom-component></custom-component> <i /> <i></i> <Component /> <Component /> ``` ##### Allow custom "else if"-like blocks with block params ([#​13930](https://togithub.com/prettier/prettier/pull/13930) by [@​jamescdavis](https://togithub.com/jamescdavis)) [#​13507](https://togithub.com/prettier/prettier/issues/13507) added support for custom block keywords used with `else`, but failed to allow block params. This updates printer-glimmer to allow block params with custom "else if"-like blocks. ```hbs {{! Input }} {{#when isAtWork as |work|}} Ship that {{work}}! {{else when isReading as |book|}} You can finish {{book}} eventually... {{else}} Go to bed! {{/when}} {{! Prettier 2.8.1 }} {{#when isAtWork as |work|}} Ship that {{work}}! {{else when isReading}} You can finish {{book}} eventually... {{else}} Go to bed! {{/when}} {{! Prettier 2.8.2 }} {{#when isAtWork as |work|}} Ship that {{work}}! {{else when isReading as |book|}} You can finish {{book}} eventually... {{else}} Go to bed! {{/when}} ``` ##### Preserve empty lines between nested SCSS maps ([#​13931](https://togithub.com/prettier/prettier/pull/13931) by [@​jneander](https://togithub.com/jneander)) ```scss /* Input */ $map: ( 'one': ( 'key': 'value', ), 'two': ( 'key': 'value', ), ) /* Prettier 2.8.1 */ $map: ( 'one': ( 'key': 'value', ), 'two': ( 'key': 'value', ), ) /* Prettier 2.8.2 */ $map: ( 'one': ( 'key': 'value', ), 'two': ( 'key': 'value', ), ) ``` ##### Fix missing parentheses when an expression statement starts with `let[` ([#​14000](https://togithub.com/prettier/prettier/pull/14000), [#​14044](https://togithub.com/prettier/prettier/pull/14044) by [@​fisker](https://togithub.com/fisker), [@​thorn0](https://togithub.com/thorn0)) ```jsx // Input (let[0] = 2); // Prettier 2.8.1 let[0] = 2; // Prettier 2.8.1 (second format) SyntaxError: Unexpected token (1:5) > 1 | let[0] = 2; | ^ 2 | // Prettier 2.8.2 (let)[0] = 2; ``` ##### Fix semicolon duplicated at the end of LESS file ([#​14007](https://togithub.com/prettier/prettier/pull/14007) by [@​mvorisek](https://togithub.com/mvorisek)) ```less // Input @​variable: { field: something; }; // Prettier 2.8.1 @​variable: { field: something; }; ; // Prettier 2.8.2 @​variable: { field: something; }; ``` ##### Fix no space after unary minus when followed by opening parenthesis in LESS ([#​14008](https://togithub.com/prettier/prettier/pull/14008) by [@​mvorisek](https://togithub.com/mvorisek)) ```less // Input .unary_minus_single { margin: -(@​a); } .unary_minus_multi { margin: 0 -(@​a); } .binary_minus { margin: 0 - (@​a); } // Prettier 2.8.1 .unary_minus_single { margin: - (@​a); } .unary_minus_multi { margin: 0 - (@​a); } .binary_minus { margin: 0 - (@​a); } // Prettier 2.8.2 .unary_minus_single { margin: -(@​a); } .unary_minus_multi { margin: 0 -(@​a); } .binary_minus { margin: 0 - (@​a); } ``` ##### Do not change case of property name if inside a variable declaration in LESS ([#​14034](https://togithub.com/prettier/prettier/pull/14034) by [@​mvorisek](https://togithub.com/mvorisek)) ```less // Input @​var: { preserveCase: 0; }; // Prettier 2.8.1 @​var: { preservecase: 0; }; // Prettier 2.8.2 @​var: { preserveCase: 0; }; ``` ##### Fix formatting for auto-accessors with comments ([#​14038](https://togithub.com/prettier/prettier/pull/14038) by [@​fisker](https://togithub.com/fisker)) ```jsx // Input class A { @​dec() // comment accessor b; } // Prettier 2.8.1 class A { @​dec() accessor // comment b; } // Prettier 2.8.1 (second format) class A { @​dec() accessor; // comment b; } // Prettier 2.8.2 class A { @​dec() // comment accessor b; } ``` ##### Add parentheses for TSTypeQuery to improve readability ([#​14042](https://togithub.com/prettier/prettier/pull/14042) by [@​onishi-kohei](https://togithub.com/onishi-kohei)) ```tsx // Input a as (typeof node.children)[number] a as (typeof node.children)[] a as ((typeof node.children)[number])[] // Prettier 2.8.1 a as typeof node.children[number]; a as typeof node.children[]; a as typeof node.children[number][]; // Prettier 2.8.2 a as (typeof node.children)[number]; a as (typeof node.children)[]; a as (typeof node.children)[number][]; ``` ##### Fix displacing of comments in default switch case ([#​14047](https://togithub.com/prettier/prettier/pull/14047) by [@​thorn0](https://togithub.com/thorn0)) It was a regression in Prettier 2.6.0. ```jsx // Input switch (state) { default: result = state; // no change break; } // Prettier 2.8.1 switch (state) { default: // no change result = state; break; } // Prettier 2.8.2 switch (state) { default: result = state; // no change break; } ``` ##### Support type annotations on auto accessors via `babel-ts` ([#​14049](https://togithub.com/prettier/prettier/pull/14049) by [@​sosukesuzuki](https://togithub.com/sosukesuzuki)) [The bug that `@babel/parser` cannot parse auto accessors with type annotations](https://togithub.com/babel/babel/issues/15205) has been fixed. So we now support it via `babel-ts` parser. ```tsx class Foo { accessor prop: number; } ``` ##### Fix formatting of empty type parameters ([#​14073](https://togithub.com/prettier/prettier/pull/14073) by [@​fisker](https://togithub.com/fisker)) ```jsx // Input const foo: bar</* comment */> = () => baz; // Prettier 2.8.1 Error: Comment "comment" was not printed. Please report this error! // Prettier 2.8.2 const foo: bar</* comment */> = () => baz; ``` ##### Add parentheses to head of `ExpressionStatement` instead of the whole statement ([#​14077](https://togithub.com/prettier/prettier/pull/14077) by [@​fisker](https://togithub.com/fisker)) ```jsx // Input ({}).toString.call(foo) === "[object Array]" ? foo.forEach(iterateArray) : iterateObject(foo); // Prettier 2.8.1 ({}.toString.call(foo) === "[object Array]" ? foo.forEach(iterateArray) : iterateObject(foo)); // Prettier 2.8.2 ({}).toString.call(foo.forEach) === "[object Array]" ? foo.forEach(iterateArray) : iterateObject(foo); ``` ##### Fix comments after directive ([#​14081](https://togithub.com/prettier/prettier/pull/14081) by [@​fisker](https://togithub.com/fisker)) ```jsx // Input "use strict" /* comment */; // Prettier 2.8.1 (with other js parsers except `babel`) Error: Comment "comment" was not printed. Please report this error! // Prettier 2.8.2 <Same as input> ``` ##### Fix formatting for comments inside JSX attribute ([#​14082](https://togithub.com/prettier/prettier/pull/14082) with by [@​fisker](https://togithub.com/fisker)) ```jsx // Input function MyFunctionComponent() { <button label=/*old*/"new">button</button> } // Prettier 2.8.1 Error: Comment "old" was not printed. Please report this error! // Prettier 2.8.2 function MyFunctionComponent() { <button label=/*old*/ "new">button</button>; } ``` ##### Quote numeric keys for json-stringify parser ([#​14083](https://togithub.com/prettier/prettier/pull/14083) by [@​fisker](https://togithub.com/fisker)) ```jsx // Input {0: 'value'} // Prettier 2.8.1 { 0: "value" } // Prettier 2.8.2 { "0": "value" } ``` ##### Fix removing commas from function arguments in maps ([#​14089](https://togithub.com/prettier/prettier/pull/14089) by [@​sosukesuzuki](https://togithub.com/sosukesuzuki)) ```scss /* Input */ $foo: map-fn( ( "#{prop}": inner-fn($first, $second), ) ); /* Prettier 2.8.1 */ $foo: map-fn(("#{prop}": inner-fn($first $second))); /* Prettier 2.8.2 */ $foo: map-fn( ( "#{prop}": inner-fn($first, $second), ) ); ``` ##### Do not insert space in LESS property access ([#​14103](https://togithub.com/prettier/prettier/pull/14103) by [@​fisker](https://togithub.com/fisker)) ```less // Input a { color: @​colors[@​white]; } // Prettier 2.8.1 a { color: @​colors[ @​white]; } // Prettier 2.8.2 <Same as input> ``` </details> <details> <summary>vitejs/vite</summary> ### [`v4.0.4`](https://togithub.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small404-2023-01-03-small) [Compare Source](https://togithub.com/vitejs/vite/compare/v4.0.3...v4.0.4) - fix: importmap should insert before module preload link ([#​11492](https://togithub.com/vitejs/vite/issues/11492)) ([25c64d7](https://togithub.com/vitejs/vite/commit/25c64d7)), closes [#​11492](https://togithub.com/vitejs/vite/issues/11492) - fix: server.host with ipv6 missed \[] (fix [#​11466](https://togithub.com/vitejs/vite/issues/11466)) ([#​11509](https://togithub.com/vitejs/vite/issues/11509)) ([2c38bae](https://togithub.com/vitejs/vite/commit/2c38bae)), closes [#​11466](https://togithub.com/vitejs/vite/issues/11466) [#​11509](https://togithub.com/vitejs/vite/issues/11509) - fix: stop considering parent URLs as public file ([#​11145](https://togithub.com/vitejs/vite/issues/11145)) ([568a014](https://togithub.com/vitejs/vite/commit/568a014)), closes [#​11145](https://togithub.com/vitejs/vite/issues/11145) - fix(build): invalidate chunk hash when css changed ([#​11475](https://togithub.com/vitejs/vite/issues/11475)) ([7a97a04](https://togithub.com/vitejs/vite/commit/7a97a04)), closes [#​11475](https://togithub.com/vitejs/vite/issues/11475) - fix(cli): ctrl+C no longer kills processes ([#​11434](https://togithub.com/vitejs/vite/issues/11434)) ([#​11518](https://togithub.com/vitejs/vite/issues/11518)) ([718fc1d](https://togithub.com/vitejs/vite/commit/718fc1d)), closes [#​11434](https://togithub.com/vitejs/vite/issues/11434) [#​11518](https://togithub.com/vitejs/vite/issues/11518) - fix(cli): revert ctrl+C no longer kills processes ([#​11434](https://togithub.com/vitejs/vite/issues/11434)) ([#​11518](https://togithub.com/vitejs/vite/issues/11518)) ([#​11562](https://togithub.com/vitejs/vite/issues/11562)) ([3748acb](https://togithub.com/vitejs/vite/commit/3748acb)), closes [#​11434](https://togithub.com/vitejs/vite/issues/11434) [#​11518](https://togithub.com/vitejs/vite/issues/11518) [#​11562](https://togithub.com/vitejs/vite/issues/11562) - fix(optimizer): check .vite/deps directory existence before removing ([#​11499](https://togithub.com/vitejs/vite/issues/11499)) ([1b043f9](https://togithub.com/vitejs/vite/commit/1b043f9)), closes [#​11499](https://togithub.com/vitejs/vite/issues/11499) - fix(ssr): emit js sourcemaps for ssr builds ([#​11343](https://togithub.com/vitejs/vite/issues/11343)) ([f12a1ab](https://togithub.com/vitejs/vite/commit/f12a1ab)), closes [#​11343](https://togithub.com/vitejs/vite/issues/11343) - chore: update license ([#​11476](https://togithub.com/vitejs/vite/issues/11476)) ([3d346c0](https://togithub.com/vitejs/vite/commit/3d346c0)), closes [#​11476](https://togithub.com/vitejs/vite/issues/11476) - chore(deps): update dependency [@​rollup/plugin-json](https://togithub.com/rollup/plugin-json) to v6 ([#​11553](https://togithub.com/vitejs/vite/issues/11553)) ([3647d07](https://togithub.com/vitejs/vite/commit/3647d07)), closes [#​11553](https://togithub.com/vitejs/vite/issues/11553) </details> <details> <summary>pmndrs/zustand</summary> ### [`v4.3.2`](https://togithub.com/pmndrs/zustand/releases/tag/v4.3.2) [Compare Source](https://togithub.com/pmndrs/zustand/compare/v4.3.1...v4.3.2) There was a regression with default export (which is deprecated) in v4.3.0 and v4.3.1. This should fix it. ##### What's Changed - fix(vanilla,shallow): default export regression in CJS by [@​dai-shi](https://togithub.com/dai-shi) in [pmndrs/zustand#1531 - fix(middleware/persist): Fix the storage type by [@​MOZGIII](https://togithub.com/MOZGIII) in [pmndrs/zustand#1540 ##### New Contributors - [@​CatMonster](https://togithub.com/CatMonster) made their first contribution in [pmndrs/zustand#1539 - [@​MOZGIII](https://togithub.com/MOZGIII) made their first contribution in [pmndrs/zustand#1540 **Full Changelog**: pmndrs/zustand@v4.3.1...v4.3.2 ### [`v4.3.1`](https://togithub.com/pmndrs/zustand/releases/tag/v4.3.1) [Compare Source](https://togithub.com/pmndrs/zustand/compare/v4.3.0...v4.3.1) This version supersedes v4.3.0. #### What's Changed - chore: show deprecated message only in DEV by [@​dai-shi](https://togithub.com/dai-shi) in [pmndrs/zustand#1523 **Full Changelog**: pmndrs/zustand@v4.3.0...v4.3.1 ### [`v4.3.0`](https://togithub.com/pmndrs/zustand/releases/tag/v4.3.0) [Compare Source](https://togithub.com/pmndrs/zustand/compare/v4.2.0...v4.3.0) Throughout past years of development, we've learned the (mis)usage of the library. One of our goal is to provide smallest possible APIs. To go further, this version deprecates some features. They are still usable (with warnings), but will be removed in the future. #### What's Changed - feat: deprecate some APIs toward v5 by [@​dai-shi](https://togithub.com/dai-shi) in [pmndrs/zustand#1403 - feat: deprecate default export by [@​dai-shi](https://togithub.com/dai-shi) in [pmndrs/zustand#1514 - fix(middleware/persist): hydrate in sync (new impl with storage option) by [@​dai-shi](https://togithub.com/dai-shi) in [pmndrs/zustand#1518 #### New Contributors - [@​adil62](https://togithub.com/adil62) made their first contribution in [pmndrs/zustand#1502 - [@​wcastand](https://togithub.com/wcastand) made their first contribution in [pmndrs/zustand#1512 **Full Changelog**: pmndrs/zustand@v4.2.0...v4.3.0 ### [`v4.2.0`](https://togithub.com/pmndrs/zustand/releases/tag/v4.2.0) [Compare Source](https://togithub.com/pmndrs/zustand/compare/v4.1.5...v4.2.0) This version adds some new features in middleware. #### What's Changed - feat(middleware/devtools): Better redux devtools. One connection for all zustand stores by [@​pavlobu](https://togithub.com/pavlobu) in [pmndrs/zustand#1435 - feat(middleware/persist): new storage option by [@​dai-shi](https://togithub.com/dai-shi) in [pmndrs/zustand#1463 - fix(build): disable esModule and re-export for nodejs by [@​barelyhuman](https://togithub.com/barelyhuman) in [pmndrs/zustand#1486 #### New Contributors - [@​Guchii](https://togithub.com/Guchii) made their first contribution in [pmndrs/zustand#1476 - [@​sewera](https://togithub.com/sewera) made their first contribution in [pmndrs/zustand#1478 - [@​pavlobu](https://togithub.com/pavlobu) made their first contribution in [pmndrs/zustand#1435 **Full Changelog**: pmndrs/zustand@v4.1.5...v4.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/mheob/ef-calc).
val-o
reviewed
Jul 18, 2023
| import vanillaStore from './vanillaStore' | ||
|
|
||
| const useBoundStore = create(vanillaStore) | ||
| const useBoundStore = (selector) => useStore(vanillaStore, selector) |
](https://renovatebot.com){kind=link}
There was a problem hiding this comment.
it seems that this will require more TS boilerplate
There was a problem hiding this comment.
I think it's just a little. Such usage is already documented somewhere. If people use this pattern a lot, we could provide a util for it. Thanks for your feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to deprecate some features which will be removed in v5.
They are not often used, have better alternatives, and/or can mislead usages.
There's no plan about v5 (btw, minimal requirement will be react 18) yet, but this PR would be good to get some feedback in advance.