New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency execa to v2 #47498
Conversation
PR has been edited👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description. |
💔 Build Failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
}; | ||
|
||
const runApiDocumenter = async (folder: string) => { | ||
await execa.shell( | ||
`api-documenter markdown -i ./build/${folder} -o ./docs/development/core/${folder}` | ||
await execa( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you dropped shell from these two commands - just want to confirm that was intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best I could tell these only used shell so they didn't need to specify the arguments as independent values, but doing so makes for better escaping which is a good habit I think and especially important here.
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
I'm going to wait until sindresorhus/execa#353 is released because kbn-es is broken without this convenience, but if we need to upgrade we could go earlier. We hopefully will be getting a v3 soon sindresorhus/execa#351 (comment) |
Autoclosing SkippedThis PR has been flagged for autoclosing, however it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
This PR contains the following updates:
^1.0.0
->^2.0.5
^1.0.0
->^2.0.5
Release Notes
sindresorhus/execa
v2.0.5
Compare Source
Bug fixes
d268fd1
v2.0.4
Compare Source
Bug fixes
detached: true
orcleanup: false
is used (#360)211febe
v2.0.3
Compare Source
Bug fixes
all
(#345)Documentation
v2.0.2
Compare Source
Bug fixes
result.all
not being constant across calls (#327, #330)v2.0.1
Compare Source
Bug fixes
engines.node
field inpackage.json
. Supported Node versions are either^8.12.0
or>=9.7.0
(#319, #323)Documentation
execa.command()
documentation (#317)v2.0.0
Compare Source
Thanks to @GMartigny, @BendingBender, @tomsotte, @ammarbinfaisal, @zokker13, @stroncium, @satyarohith, @bradfordlemley, @coreyfarrell, @brandon93s, @dtinth, @papb for the great features and bug fixes they've contributed!
Please check the Medium article about this release!
Breaking changes
execa.shell()
andexeca.shellSync()
. Theshell
option should be used instead. (#219)execa.stdout()
andexeca.stderr()
.childProcessResult.stdout
andchildProcessResult.stderr
should be used instead (#234)error.code
(number
orstring
) in favor oferror.exitCode
(number
) anderror.exitCodeName
(string
) (#187, #250)stripeEof
option tostripFinalNewline
(f8397ba9, 4d0dc88a, #238)cmd
(inchildProcessResult
anderror
) tocommand
(#194)preferLocal
option tofalse
. If you are executing locally installed binaries, you'll need to manually specifypreferLocal: true
(#314)windowsHide
option is alwaystrue
, so that no window pops up on Windows. (8c886452)error.signal
is nowundefined
instead ofnull
when no signal was used (#193)error.killed
tofalse
when child process timed out (#227)error.killed
always boolean (notundefined
) (#229, #248)error.stdout
anderror.stderr
are now an empty string (instead ofnull
) when the command failed. (#246)Features
execa.command()
andexeca.commandSync()
. Those are the same asexeca()
except both file and arguments are specified in a single string. For example,execa('echo', ['unicorns'])
is the same asexeca.command('echo unicorns')
(#182, #261, #262, #278, #279, #282)childProcess.all
andchildProcessResult.all
(#171, #264)execa.node()
which (likechild_process.fork()
) allows you to execute a Node.js script as a child process (#200, #297, #299, #302, #303, #305, #306).childProcess.kill()
does not terminate a child process after 5 seconds, force it by sendingSIGKILL
. This can be configured using theforceKillAfterTimeout
option. (#208, #272, #273, #280, #284, #285)childProcess.cancel()
anderror.isCanceled
(#189, f24e7c72, #226, #309)error.stdout
,error.stderr
anderror.all
now contain the data that was sent before the child process exit. (#271)error.message
on child process failure (#180, #223, #230, #245, #269).finally()
to the child process promise (#174, 65139849)maxBuffer
option default value from10 MB
to100 MB
(#286)Bug fixes
timeout
option not working as expected (#199)error.timedOut
not working withexeca.sync()
(#249)maxBuffer
errors not using the same shape as the other errors (#266)extendEnd
option not working withshell
option (#184)stripFinalNewline
option not applied on error properties (#240)/q
parameter not added when usingcmd
instead ofcmd.exe
(#203)input
option with a non-executable file (#212, #258)stdio
option cannot be used together withstdin: 0
(#301).Documentation
Design
Tests
Maintainers
Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "
rebase!
".🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot. View repository job log here.