Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency eslint to v8 #1434

Closed
wants to merge 1 commit into from
Closed

chore(deps): update dependency eslint to v8 #1434

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 27, 2021 •
edited

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint (source) 7.32.0 -> 8.2.0 age adoption passing confidence
eslint (source) 7.26 || 7.27 || 7.29 || 7.30 || 7.31 || 7.32 -> 7.26 || 7.27 || 7.29 || 7.30 || 7.31 || 7.32 || 8.2 age adoption passing confidence

Release Notes

eslint/eslint

v8.2.0

Compare Source

Features

  • c9fefd2 feat: report class evaluation TDZ errors in no-use-before-define (#​15134) (Milos Djermanovic)

Documentation

  • c415c04 docs: Use string rule severity in CLI examples (#​15253) (Kevin Partington)
  • 12b627d docs: fix typo in working-with-rules.md (#​15233) (Nitin Kumar)
  • a86ffc0 docs: fix broken anchor in configuration files (#​15223) (Pierre Berger)
  • ee8af5f docs: Link to unit tests from rule documentation (#​15207) (Brandon Mills)
  • 1c0ca3c docs: add ci and perf tags for commit (#​15215) (Nitin Kumar)

Build Related

  • 796587a build: upgrade eslint-release to v3.2.0 to support conventional commits (#​15246) (Milos Djermanovic)

Chores

v8.1.0

Compare Source

v8.0.1

Compare Source

v8.0.0

Compare Source

Configuration

📅 Schedule: "before 3am on Saturday" in timezone Europe/Berlin.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2021 •
edited

⚠️ No Changeset found

Latest commit: 46f140f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the type:infrastructure Tooling and other chores label Oct 27, 2021
@coveralls
Copy link

coveralls commented Oct 27, 2021 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 46f140f on renovate/eslint-8.x into 5103fe4 on main.

@ti10le
Copy link
Contributor

ti10le commented Oct 28, 2021

I would like to update Eslint to 8. However, I get this error: https://github.com/marigold-ui/marigold/runs/4021896661?check_suite_focus=true
According to google you should remove 'react-app/jest' from the eslint config. But then I get the error in all configs: Parsing error: Must use import to load ES Module.
Do you have any tips for that @sebald ?

@sebald
Copy link
Member

sebald commented Oct 28, 2021

Did you check that our configs and deps are compatible with the new major eslint release?

Removing it seems like not a good idea since we want that lint rules. Is there a jest-eslint-config for eslint 8?

@ti10le
Copy link
Contributor

ti10le commented Oct 28, 2021

I would then have to check all our dependencies in config? Is there an easier way?

  "dependencies": {
    "@typescript-eslint/eslint-plugin": "5.2.0",
    "@typescript-eslint/parser": "5.2.0",
    "babel-eslint": "10.1.0",
    "eslint-config-prettier": "^8.3.0",
    "eslint-config-react-app": "6.0.0",
    "eslint-plugin-flowtype": "^8.0.0",
    "eslint-plugin-import": "2.25.2",
    "eslint-plugin-jest": "24.7.0",
    "eslint-plugin-jsx-a11y": "6.4.1",
    "eslint-plugin-prettier": "4.0.0",
    "eslint-plugin-react": "7.26.1",
    "eslint-plugin-react-hooks": "^4.2.0",
    "eslint-plugin-testing-library": "5.0.0"
  },

@ti10le
Copy link
Contributor

ti10le commented Oct 28, 2021

jest-community/eslint-plugin-jest#903

@renovate renovate bot force-pushed the renovate/eslint-8.x branch 5 times, most recently from 6f360a5 to ef99d60 Compare October 29, 2021 10:01
@renovate renovate bot force-pushed the renovate/eslint-8.x branch 6 times, most recently from 614c280 to 35b30a6 Compare November 10, 2021 19:20
@renovate
Copy link
Contributor Author

renovate bot commented Nov 16, 2021 •
edited

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 8.x releases. However, if you upgrade to 8.x manually then Renovate will reenable minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate renovate bot deleted the renovate/eslint-8.x branch November 16, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type:infrastructure Tooling and other chores
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@coveralls @ti10le @sebald @viktoria-schwarz @renovate-bot