Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update npm to v9 - autoclosed #146

Closed
wants to merge 1 commit into from
Closed

Update npm to v9 - autoclosed #146

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 10, 2022 •
edited

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
npm (source) ^8 -> ^9.0.0 age adoption passing confidence

Release Notes

npm/cli

v9.2.0

Compare Source

Features
Bug Fixes
Dependencies

v9.1.3

Compare Source

Bug Fixes
Documentation
Dependencies

v9.1.2

Compare Source

Bug Fixes
Dependencies

v9.1.1

Compare Source

Documentation
Dependencies

v9.1.0

Compare Source

Features
Bug Fixes
Documentation
Dependencies

v9.0.1

Compare Source

Documentation
Dependencies

v9.0.0

Compare Source

Features
Dependencies

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

Read more information about the use of Renovate Bot within Laminas.

@renovate renovate bot added the renovate label Nov 10, 2022
@renovate
Copy link
Contributor Author

renovate bot commented Nov 10, 2022 •
edited

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm: undefined
npm ERR! notsup Not compatible with your version of node/npm: undefined
npm ERR! notsup Required: {"npm":"^9.0.0","node":"^19"}
npm ERR! notsup Actual:   {"npm":"8.19.3","node":"v19.3.0"}

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/renovate-cache/others/npm/_logs/2022-12-19T13_16_36_354Z-debug-0.log

@Ocramius Ocramius added this to the 1.20.0 milestone Nov 11, 2022
@Ocramius Ocramius removed this from the 1.20.0 milestone Nov 14, 2022
@Ocramius
Copy link
Member

Needs an update to package.json and package-lock.json:

npm ERR! notsup Required: {"npm":"^9.0.0","node":"^19"}
npm ERR! notsup Actual:   {"npm":"8.19.3","node":"v19.1.0"}

@Ocramius Ocramius changed the base branch from 1.20.x to 1.21.x November 15, 2022 09:35
@internalsystemerror internalsystemerror self-assigned this Nov 15, 2022
@internalsystemerror
Copy link
Member

Dec 7th it will be available in node 19 so we just need to sit on this until then.

https://github.blog/changelog/2022-10-24-npm-v9-0-0-released/

@renovate renovate bot force-pushed the renovate/npm-9.x branch 4 times, most recently from 804cd47 to 04f2d54 Compare November 20, 2022 03:05
@renovate renovate bot force-pushed the renovate/npm-9.x branch 2 times, most recently from c31b947 to a706e43 Compare November 26, 2022 04:40
@renovate renovate bot force-pushed the renovate/npm-9.x branch 2 times, most recently from 3b09222 to 63c12da Compare December 6, 2022 05:00
@renovate renovate bot force-pushed the renovate/npm-9.x branch 2 times, most recently from fc0e148 to 8872d53 Compare December 10, 2022 03:25
@internalsystemerror
Copy link
Member

npm 9 was merged into nodejs main, we're just waiting for a new nodejs release now I believe nodejs/node#45780

@renovate renovate bot force-pushed the renovate/npm-9.x branch 2 times, most recently from 73daa73 to a1bbc34 Compare December 15, 2022 11:24
@internalsystemerror
Copy link
Member

Node 19.3.0 has been released containing npm v9 https://github.com/nodejs/node/releases/tag/v19.3.0. This should be good to merge now, though I'm not sure why the renovate/artifacts job is still failing, I would think that would also show green now.

@internalsystemerror
Copy link
Member

It still seems to be getting an npm constraint of 8 from somewhere:

Logs 
DEBUG: latest commit(branch="renovate/npm-9.x")
{
  "branchName": "1.22.x",
  "latestCommitDate": "2022-12-12T01:00:39+00:00"
}
DEBUG: manager.getUpdatedPackageFiles() reuseExistingBranch=false(branch="renovate/npm-9.x")
DEBUG: npm.updateDependency(): engines.npm = ^9.0.0(branch="renovate/npm-9.x")
DEBUG: Updating npm in package.json(branch="renovate/npm-9.x")
DEBUG: Updated 1 package files(branch="renovate/npm-9.x")
DEBUG: Getting updated lock files(branch="renovate/npm-9.x")
DEBUG: Writing package.json files(branch="renovate/npm-9.x")
{
  "packageFiles": [
    "package.json"
  ]
}
DEBUG: Writing package-lock.json(branch="renovate/npm-9.x")
DEBUG: Writing any updated package files(branch="renovate/npm-9.x")
DEBUG: Writing package.json(branch="renovate/npm-9.x")
DEBUG: npmrc file found in repository(branch="renovate/npm-9.x")
DEBUG: Generating package-lock.json for .(branch="renovate/npm-9.x")
DEBUG: Spawning npm install to create ./package-lock.json(branch="renovate/npm-9.x")
DEBUG: Updating lock file only(branch="renovate/npm-9.x")
DEBUG: Using node constraint "^19" from package.json(branch="renovate/npm-9.x")
DEBUG: Setting CONTAINERBASE_CACHE_DIR to /tmp/containerbase(branch="renovate/npm-9.x")
DEBUG: Using docker to execute(branch="renovate/npm-9.x")
{
  "image": "sidecar"
}
DEBUG: Resolved unstable matching version(branch="renovate/npm-9.x")
{
  "toolName": "node",
  "constraint": "^19",
  "resolvedVersion": "v19.3.0"
}
DEBUG: Resolved stable matching version(branch="renovate/npm-9.x")
{
  "toolName": "npm",
  "constraint": "^8 <9",
  "resolvedVersion": "8.19.3"
}
DEBUG: containerbaseDir is separate from cacheDir(branch="renovate/npm-9.x")
DEBUG: No tag or tagConstraint specified for image: docker.io/renovate/sidecar(branch="renovate/npm-9.x")
DEBUG: Docker image is already prefetched: docker.io/renovate/sidecar@sha256:b3d5cc28d7437b0b926a91085b7ec7d17e48273e8b907f08546142b73b874d7a(branch="renovate/npm-9.x")
DEBUG: Executing command(branch="renovate/npm-9.x")
{
  "command": "docker run --rm --name=renovate_sidecar --label=renovate_child -v \"/mnt/renovate/gh/laminas/laminas-ci-matrix-action\":\"/mnt/renovate/gh/laminas/laminas-ci-matrix-action\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -v \"/tmp/containerbase\":\"/tmp/containerbase\" -e NPM_CONFIG_CACHE -e npm_config_store -e BUILDPACK_CACHE_DIR -e CONTAINERBASE_CACHE_DIR -w \"/mnt/renovate/gh/laminas/laminas-ci-matrix-action\" docker.io/renovate/sidecar bash -l -c \"install-tool node v19.3.0 && install-tool npm 8.19.3 && hash -d npm 2>/dev/null || true && npm install --package-lock-only --no-audit --ignore-scripts\""
}

@Ocramius
Copy link
Member

Main CI broke anyway, due to npm/node being upgraded by GitHub? 🤔

@internalsystemerror
Copy link
Member

I'm not sure why the artifacts job is still failing, this should be good to merge now.

@Ocramius Ocramius changed the base branch from 1.21.x to 1.22.x December 19, 2022 13:15
@renovate
Update npm to v9
eec138f 
| datasource | package | from   | to    |
| ---------- | ------- | ------ | ----- |
| npm        | npm     | 8.19.3 | 9.2.0 |


Signed-off-by: Renovate Bot <bot@renovateapp.com>
@internalsystemerror
Copy link
Member

The logs say that the error is with the lock file and its the same one listed here, installing npm 8 when 9 is required.

WARN: artifactErrors(branch="renovate/npm-9.x")
{
  "artifactErrors": [
    {
      "lockFile": "package-lock.json",
      "stderr": "npm ERR! code EBADENGINE\nnpm ERR! engine Unsupported engine\nnpm ERR! engine Not compatible with your version of node/npm: undefined\nnpm ERR! notsup Not compatible with your version of node/npm: undefined\nnpm ERR! notsup Required: {\"npm\":\"^9.0.0\",\"node\":\"^19\"}\nnpm ERR! notsup Actual:   {\"npm\":\"8.19.3\",\"node\":\"v19.3.0\"}\n\nnpm ERR! A complete log of this run can be found in:\nnpm ERR!     /tmp/renovate-cache/others/npm/_logs/2022-12-19T13_16_36_354Z-debug-0.log\n"
    }
  ]
}

So the issue it's reporting is that it's unable to also update the lockfile in this PR. So we could:

@internalsystemerror internalsystemerror mentioned this pull request Dec 19, 2022
Merged
@renovate renovate bot changed the title Update npm to v9 Update npm to v9 - autoclosed Dec 19, 2022
@renovate renovate bot closed this Dec 19, 2022
@renovate renovate bot deleted the renovate/npm-9.x branch December 19, 2022 15:22
@Ocramius Ocramius added Duplicate This issue or pull request already exists and removed Help Wanted labels Dec 19, 2022
@Ocramius
Copy link
Member

Handled in #166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@internalsystemerror internalsystemerror internalsystemerror approved these changes

Assignees

@internalsystemerror internalsystemerror

Labels
Duplicate This issue or pull request already exists renovate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ocramius @internalsystemerror