feat: PC-13831 unique SLOs validation and test #526
Merged
+49
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubpieta
requested review from
nieomylnieja,
skrolikiewicz and
daniel-zelazny
as code owners
kubaceg
approved these changes
Aug 22, 2024
renovate bot
referenced
this pull request
in nobl9/sloctl
Aug 23, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/nobl9/nobl9-go](https://togithub.com/nobl9/nobl9-go) | `v0.84.0-rc5` -> `v0.84.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>nobl9/nobl9-go (github.com/nobl9/nobl9-go)</summary> ### [`v0.84.0`](https://togithub.com/nobl9/nobl9-go/releases/tag/v0.84.0) [Compare Source](https://togithub.com/nobl9/nobl9-go/compare/v0.84.0-rc6...v0.84.0) ### What's Changed #### 🚀 Features - feat: PC-13831 unique SLOs validation and test ([#​526](https://togithub.com/nobl9/nobl9-go/issues/526)) [@​jakubpieta](https://togithub.com/jakubpieta) > Added BudgetAdjustment validation for unique SLOs in filters - feat: add Replay support to Logic Monitor ([#​510](https://togithub.com/nobl9/nobl9-go/issues/510)) [@​mkaras-nobl9](https://togithub.com/mkaras-nobl9) > Adds Replay support to Logic Monitor data source. - feat: PC-13263 Add Report kind ([#​495](https://togithub.com/nobl9/nobl9-go/issues/495)) [@​natalialanga](https://togithub.com/natalialanga) > New `Report` kind for handling creating, updating and deleting reports. > Only System Health Review report type is currently supported. > This feature is currently in early access, and is available only on demand. > If you want to utilize SDK for reports management, please reach out to Nobl9 Support. - feat: PC-13028 Support Azure Monitor managed service for Prometheus in Direct ([#​449](https://togithub.com/nobl9/nobl9-go/issues/449)) [@​dawidwisn](https://togithub.com/dawidwisn) > Added Direct support for Azure Monitor Managed Service for Prometheus, extending `v1alpha.Direct.Spec`. #### 🐞 Bug Fixes - fix: PC-13744 Removed anomaly config from composite e2e test ([#​520](https://togithub.com/nobl9/nobl9-go/issues/520)) [@​ditrytus](https://togithub.com/ditrytus) - fix: Removing redundant validation in LogicMonitor \[PC-13783] ([#​514](https://togithub.com/nobl9/nobl9-go/issues/514)) [@​dawidwisn](https://togithub.com/dawidwisn) > Removing redundant validation for `ClientID` and `ClientSecret` in Logic Monitor - fix: Fix tests for Azure Prometheus Direct \[PC-13028] ([#​504](https://togithub.com/nobl9/nobl9-go/issues/504)) [@​dawidwisn](https://togithub.com/dawidwisn) #### 🧰 Maintenance <details> <summary>21 changes</summary> - chore: Update dependency cspell to v8.14.2 ([#​524](https://togithub.com/nobl9/nobl9-go/issues/524)) [@​renovate](https://togithub.com/renovate) - chore: Update DEVELOPMENT.md ([#​523](https://togithub.com/nobl9/nobl9-go/issues/523)) [@​nieomylnieja](https://togithub.com/nieomylnieja) - chore: Update dependency cspell to v8.14.1 ([#​522](https://togithub.com/nobl9/nobl9-go/issues/522)) [@​renovate](https://togithub.com/renovate) - chore: Update dependency golangci/golangci-lint to v1.60.1 ([#​521](https://togithub.com/nobl9/nobl9-go/issues/521)) [@​renovate](https://togithub.com/renovate) - chore: PC-13744 Composite SLOs in examples and SDK e2e tests ([#​516](https://togithub.com/nobl9/nobl9-go/issues/516)) [@​ditrytus](https://togithub.com/ditrytus) - chore: PC-13881 Fix comment about composites 2.0 being unavailable ([#​518](https://togithub.com/nobl9/nobl9-go/issues/518)) [@​BSski](https://togithub.com/BSski) - chore: Update dependency cspell to v8.13.3 ([#​517](https://togithub.com/nobl9/nobl9-go/issues/517)) [@​renovate](https://togithub.com/renovate) - chore: Update dependency cspell to v8.13.2 ([#​515](https://togithub.com/nobl9/nobl9-go/issues/515)) [@​renovate](https://togithub.com/renovate) - chore: Adjust release doc ([#​513](https://togithub.com/nobl9/nobl9-go/issues/513)) [@​BSski](https://togithub.com/BSski) - chore: Update module golang.org/x/tools/cmd/goimports to v0.24.0 ([#​512](https://togithub.com/nobl9/nobl9-go/issues/512)) [@​renovate](https://togithub.com/renovate) - chore: Update dependency cspell to v8.13.1 ([#​511](https://togithub.com/nobl9/nobl9-go/issues/511)) [@​renovate](https://togithub.com/renovate) - chore: Update developer docs and examples ([#​509](https://togithub.com/nobl9/nobl9-go/issues/509)) [@​nieomylnieja](https://togithub.com/nieomylnieja) - chore: gitsync updates ([#​507](https://togithub.com/nobl9/nobl9-go/issues/507)) [@​nieomylnieja](https://togithub.com/nieomylnieja) - chore: Update dependency cspell to v8.13.0 ([#​508](https://togithub.com/nobl9/nobl9-go/issues/508)) [@​renovate](https://togithub.com/renovate) - chore: Add Annotations end-to-end tests ([#​501](https://togithub.com/nobl9/nobl9-go/issues/501)) [@​nieomylnieja](https://togithub.com/nieomylnieja) - chore: Add Data Export end-to-end tests ([#​500](https://togithub.com/nobl9/nobl9-go/issues/500)) [@​nieomylnieja](https://togithub.com/nieomylnieja) - chore: Add Alert Silence end-to-end tests ([#​499](https://togithub.com/nobl9/nobl9-go/issues/499)) [@​nieomylnieja](https://togithub.com/nieomylnieja) - chore: Allow sequential apply/delete execution for end-to-end tests ([#​498](https://togithub.com/nobl9/nobl9-go/issues/498)) [@​nieomylnieja](https://togithub.com/nieomylnieja) - chore: Update dependency yaml to v2.5.0 ([#​497](https://togithub.com/nobl9/nobl9-go/issues/497)) [@​renovate](https://togithub.com/renovate) - chore: Update dependency cspell to v8.12.1 ([#​496](https://togithub.com/nobl9/nobl9-go/issues/496)) [@​renovate](https://togithub.com/renovate) - chore: Add SLO end-to-end tests ([#​494](https://togithub.com/nobl9/nobl9-go/issues/494)) [@​nieomylnieja](https://togithub.com/nieomylnieja) </details> ### [`v0.84.0-rc6`](https://togithub.com/nobl9/nobl9-go/releases/tag/v0.84.0-rc6) [Compare Source](https://togithub.com/nobl9/nobl9-go/compare/v0.84.0-rc5...v0.84.0-rc6) #### What's Changed - chore: Update dependency cspell to v8.14.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/nobl9/nobl9-go/pull/524](https://togithub.com/nobl9/nobl9-go/pull/524) - feat: PC-13831 unique SLOs validation and test by [@​jakubpieta](https://togithub.com/jakubpieta) in [https://github.com/nobl9/nobl9-go/pull/526](https://togithub.com/nobl9/nobl9-go/pull/526) **Full Changelog**: nobl9/nobl9-go@v0.84.0-rc5...v0.84.0-rc6 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/nobl9/sloctl). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwiZ29sYW5nIiwicmVub3ZhdGUiXX0=--> [PC-13783]: https://nobl9.atlassian.net/browse/PC-13783?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Added BudgetAdjustment validation for unique SLOs in filters