fix: don't leak internal class #3024

ronag · 2024-03-31T07:45:00Z

Don't pass the internal request object, create a "safe" representation. Also don't allow external mutation through addHeaders.

ronag · 2024-03-31T08:39:08Z

The messages here are weird, :headers isn't actually headers it's response

codecov-commenter · 2024-03-31T10:37:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.50%. Comparing base (7fb8232) to head (241f87f).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3024   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files          89       89           
  Lines       24220    24239   +19     
=======================================
+ Hits        22646    22665   +19     
  Misses       1574     1574

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metcoder95 · 2024-03-31T10:38:28Z

Shall we point to next?

types/diagnostics-channel.d.ts

mcollina

The goal is to leak the internal class, so it could be used as key in maps etc.

ronag · 2024-03-31T13:38:07Z

That's a bad idea in my opinion and can lead to all kinds of undefined behaviors and breaking. The internal class has no guarantees to its interface.

ronag · 2024-03-31T13:39:19Z

The goal is to leak the internal class, so it could be used as key in maps etc.

I don't see how this PR would change it. You can still use the passed object as a key.

mcollina

lgtm

I missed that

This reverts commit 2d5cbdf.

## [1.9.3](v1.9.2...v1.9.3) (2024-04-04) ### Bug Fixes * **deps:** bump undici from 6.10.2 to 6.11.1 ([#125](#125)) ([3c223c7](3c223c7)), closes [#3024](https://github.com/actions/create-github-app-token/issues/3024) [nodejs/undici#3044](nodejs/undici#3044) [#3023](https://github.com/actions/create-github-app-token/issues/3023) [nodejs/undici#3025](nodejs/undici#3025) [nodejs/undici#3024](nodejs/undici#3024) [nodejs/undici#3034](nodejs/undici#3034) [nodejs/undici#3038](nodejs/undici#3038) [nodejs/undici#2947](nodejs/undici#2947) [nodejs/undici#3040](nodejs/undici#3040) [nodejs/undici#3036](nodejs/undici#3036) [nodejs/undici#3041](nodejs/undici#3041) [#3024](https://github.com/actions/create-github-app-token/issues/3024) [#3041](https://github.com/actions/create-github-app-token/issues/3041) [#3036](https://github.com/actions/create-github-app-token/issues/3036)

… v1.9.3 ) (#231) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/create-github-app-token](https://togithub.com/actions/create-github-app-token) | action | patch | `v1.9.2` -> `v1.9.3` | --- ### Release Notes <details> <summary>actions/create-github-app-token (actions/create-github-app-token)</summary> ### [`v1.9.3`](https://togithub.com/actions/create-github-app-token/releases/tag/v1.9.3) [Compare Source](https://togithub.com/actions/create-github-app-token/compare/v1.9.2...v1.9.3) ##### Bug Fixes - **deps:** bump undici from 6.10.2 to 6.11.1 ([#125](https://togithub.com/actions/create-github-app-token/issues/125)) ([3c223c7](https://togithub.com/actions/create-github-app-token/commit/3c223c7336e276235eb843dd4e6ad42147199cbf)), closes [#3024](https://togithub.com/actions/create-github-app-token/issues/3024) [nodejs/undici#3044](https://togithub.com/nodejs/undici/issues/3044) [#3023](https://togithub.com/actions/create-github-app-token/issues/3023) [nodejs/undici#3025](https://togithub.com/nodejs/undici/issues/3025) [nodejs/undici#3024](https://togithub.com/nodejs/undici/issues/3024) [nodejs/undici#3034](https://togithub.com/nodejs/undici/issues/3034) [nodejs/undici#3038](https://togithub.com/nodejs/undici/issues/3038) [nodejs/undici#2947](https://togithub.com/nodejs/undici/issues/2947) [nodejs/undici#3040](https://togithub.com/nodejs/undici/issues/3040) [nodejs/undici#3036](https://togithub.com/nodejs/undici/issues/3036) [nodejs/undici#3041](https://togithub.com/nodejs/undici/issues/3041) [#3024](https://togithub.com/actions/create-github-app-token/issues/3024) [#3041](https://togithub.com/actions/create-github-app-token/issues/3041) [#3036](https://togithub.com/actions/create-github-app-token/issues/3036) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: bloopy-boi[bot] <98279278+bloopy-boi[bot]@users.noreply.github.com>

6.10.2

7485cd9

ronag added the semver-major Features or fixes that will be included in the next semver major release label Mar 31, 2024

ronag force-pushed the hide-internals branch 4 times, most recently from 96b96bd to b096245 Compare March 31, 2024 08:01

ronag requested a review from mcollina March 31, 2024 08:28

ronag force-pushed the hide-internals branch from b096245 to ffb7cb4 Compare March 31, 2024 08:37

ronag force-pushed the hide-internals branch 5 times, most recently from 3b69310 to 1d902e9 Compare March 31, 2024 08:48

ronag marked this pull request as draft March 31, 2024 09:50

ronag force-pushed the hide-internals branch 4 times, most recently from 89dfbd7 to dbc945d Compare March 31, 2024 10:29

ronag marked this pull request as ready for review March 31, 2024 10:29

ronag force-pushed the hide-internals branch 3 times, most recently from 7759418 to 5e4bbb0 Compare March 31, 2024 10:32

fix: don't leak internal class

c1dd2d4

ronag force-pushed the hide-internals branch from 5e4bbb0 to c1dd2d4 Compare March 31, 2024 10:33

ronag force-pushed the main branch from 845c713 to 7fb8232 Compare March 31, 2024 10:36

ronag commented Mar 31, 2024

View reviewed changes

types/diagnostics-channel.d.ts Outdated Show resolved Hide resolved

Update types/diagnostics-channel.d.ts

5b8a162

Merge branch 'main' into hide-internals

203eab5

ronag commented Mar 31, 2024

View reviewed changes

types/diagnostics-channel.d.ts Outdated Show resolved Hide resolved

Update types/diagnostics-channel.d.ts

241f87f

ronag requested a review from metcoder95 March 31, 2024 12:45

mcollina requested changes Mar 31, 2024

View reviewed changes

mcollina approved these changes Mar 31, 2024

View reviewed changes

metcoder95 approved these changes Apr 1, 2024

View reviewed changes

mcollina merged commit 2d5cbdf into main Apr 1, 2024
26 of 27 checks passed

mcollina added a commit that referenced this pull request Apr 2, 2024

Revert "fix: don't leak internal class (#3024)"

1a0c73d

This reverts commit 2d5cbdf.

mcollina added a commit that referenced this pull request Apr 2, 2024

Revert "fix: don't leak internal class (#3024)"

c346b66

This reverts commit 2d5cbdf.

Uzlopak deleted the hide-internals branch April 7, 2024 05:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: don't leak internal class #3024

fix: don't leak internal class #3024

ronag commented Mar 31, 2024 •

edited

ronag commented Mar 31, 2024

codecov-commenter commented Mar 31, 2024 •

edited

metcoder95 commented Mar 31, 2024

mcollina left a comment

ronag commented Mar 31, 2024

ronag commented Mar 31, 2024

mcollina left a comment

fix: don't leak internal class #3024

fix: don't leak internal class #3024

Conversation

ronag commented Mar 31, 2024 • edited

ronag commented Mar 31, 2024

codecov-commenter commented Mar 31, 2024 • edited

Codecov Report

metcoder95 commented Mar 31, 2024

mcollina left a comment

Choose a reason for hiding this comment

ronag commented Mar 31, 2024

ronag commented Mar 31, 2024

mcollina left a comment

Choose a reason for hiding this comment

ronag commented Mar 31, 2024 •

edited

codecov-commenter commented Mar 31, 2024 •

edited