Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing commits #3040

Merged
merged 13 commits into from Apr 2, 2024
Merged

missing commits #3040

merged 13 commits into from Apr 2, 2024

Conversation

ronag
Copy link
Member

@ronag ronag commented Apr 2, 2024 •
edited

Refs: #3033

ronag and others added 6 commits March 27, 2024 10:34
@ronag
6.10.2
7485cd9
@FatumaA @ronag
enhancement: link to the contributing guide from the README (#3003)
960dff9
@mertcanaltin @Uzlopak @ronag
fix: node:util instead of util (#3007)
98aa9f2 
* fix: node:util instead of util

* Update test/fetch/request-inspect-custom.js

Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com>

* Update test/fetch/response-inspect-custom.js

Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com>

---------

Co-authored-by: Mert Can Altin <mert.altin@trendyol.com>
Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com>
@fraxken @ronag
fix(workflows): missing top-level content.read permissions (#3013)
30cced0
@mweberxyz @ronag
chore: add automated CI testing with —no-intl node (#3015)
8c1804c
@mweberxyz @ronag
chore(workflows/nightly.yml): create issue only on all fail (#3020)
9eae7ce
@ronag ronag requested a review from mcollina April 2, 2024 07:25
@ronag

This comment was marked as outdated.

Sign in to view
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.52%. Comparing base (2d5cbdf) to head (a5d7543).
Report is 3 commits behind head on main.

❗ Current head a5d7543 differs from pull request most recent head b4ac7a4. Consider uploading reports for the commit b4ac7a4 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3040   +/-   ##
=======================================
  Coverage   93.51%   93.52%           
=======================================
  Files          89       89           
  Lines       24227    24230    +3     
=======================================
+ Hits        22657    22660    +3     
  Misses       1570     1570

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metcoder95
Copy link
Member

@metcoder95 I can't apply fa5bcb4

Does it have conflicts or how so?

@metcoder95
Copy link
Member

I'll open a PR for it

@ronag
Copy link
Member Author

ronag commented Apr 2, 2024

I think I managed. Though I lost your author ship.

@metcoder95
Copy link
Member

Perfect, that's fine tho 👍

@mcollina
Merge branch 'main' of github.com:nodejs/undici
3ac3682
@mcollina
Merge branch 'main' into missing
b93f198
@mcollina
fixup
57ff37c 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
fixup
c007adc 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
fixup
b5b2669 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
mcollina approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This needs to be landed as "rebase and merge" otherwise we lose commit history

@mcollina mcollina mentioned this pull request Apr 2, 2024
Closed
@mcollina mcollina merged commit c8a43ae into main Apr 2, 2024
29 checks passed
@mcollina mcollina deleted the missing branch April 2, 2024 09:38
create-app-token-action-releaser bot pushed a commit to actions/create-github-app-token that referenced this pull request Apr 4, 2024
@semantic-release-bot
build(release): 1.9.3 [skip ci]
7bfa3a4 
## [1.9.3](v1.9.2...v1.9.3) (2024-04-04)

### Bug Fixes

* **deps:** bump undici from 6.10.2 to 6.11.1 ([#125](#125)) ([3c223c7](3c223c7)), closes [#3024](https://github.com/actions/create-github-app-token/issues/3024) [nodejs/undici#3044](nodejs/undici#3044) [#3023](https://github.com/actions/create-github-app-token/issues/3023) [nodejs/undici#3025](nodejs/undici#3025) [nodejs/undici#3024](nodejs/undici#3024) [nodejs/undici#3034](nodejs/undici#3034) [nodejs/undici#3038](nodejs/undici#3038) [nodejs/undici#2947](nodejs/undici#2947) [nodejs/undici#3040](nodejs/undici#3040) [nodejs/undici#3036](nodejs/undici#3036) [nodejs/undici#3041](nodejs/undici#3041) [#3024](https://github.com/actions/create-github-app-token/issues/3024) [#3041](https://github.com/actions/create-github-app-token/issues/3041) [#3036](https://github.com/actions/create-github-app-token/issues/3036)
bloopy-boi bot added a commit to h3mmy/bloopyboi that referenced this pull request Apr 4, 2024
@bloopy-boi
fix(github-action): update actions/create-github-app-token ( v1.9.2 →…
170b3a8 
… v1.9.3 ) (#231)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[actions/create-github-app-token](https://togithub.com/actions/create-github-app-token)
| action | patch | `v1.9.2` -> `v1.9.3` |

---

### Release Notes

<details>
<summary>actions/create-github-app-token
(actions/create-github-app-token)</summary>

###
[`v1.9.3`](https://togithub.com/actions/create-github-app-token/releases/tag/v1.9.3)

[Compare
Source](https://togithub.com/actions/create-github-app-token/compare/v1.9.2...v1.9.3)

##### Bug Fixes

- **deps:** bump undici from 6.10.2 to 6.11.1
([#&#8203;125](https://togithub.com/actions/create-github-app-token/issues/125))
([3c223c7](https://togithub.com/actions/create-github-app-token/commit/3c223c7336e276235eb843dd4e6ad42147199cbf)),
closes
[#&#8203;3024](https://togithub.com/actions/create-github-app-token/issues/3024)
[nodejs/undici#3044](https://togithub.com/nodejs/undici/issues/3044)
[#&#8203;3023](https://togithub.com/actions/create-github-app-token/issues/3023)
[nodejs/undici#3025](https://togithub.com/nodejs/undici/issues/3025)
[nodejs/undici#3024](https://togithub.com/nodejs/undici/issues/3024)
[nodejs/undici#3034](https://togithub.com/nodejs/undici/issues/3034)
[nodejs/undici#3038](https://togithub.com/nodejs/undici/issues/3038)
[nodejs/undici#2947](https://togithub.com/nodejs/undici/issues/2947)
[nodejs/undici#3040](https://togithub.com/nodejs/undici/issues/3040)
[nodejs/undici#3036](https://togithub.com/nodejs/undici/issues/3036)
[nodejs/undici#3041](https://togithub.com/nodejs/undici/issues/3041)
[#&#8203;3024](https://togithub.com/actions/create-github-app-token/issues/3024)
[#&#8203;3041](https://togithub.com/actions/create-github-app-token/issues/3041)
[#&#8203;3036](https://togithub.com/actions/create-github-app-token/issues/3036)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNzkuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI3OS4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2IiwibGFiZWxzIjpbInJlbm92YXRlL2dpdGh1Yi1hY3Rpb24iLCJyZW5vdmF0ZS9naXRodWItcmVsZWFzZSIsInR5cGUvcGF0Y2giXX0=-->

Co-authored-by: bloopy-boi[bot] <98279278+bloopy-boi[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit to 4m-mazi/gh-test that referenced this pull request May 11, 2024
@mazi-renovate
ci(deps): update actions/create-github-app-token action from v1.9.0 t…
91bd034 
…o v1.10.0 (#728)

This PR contains the following updates:

| Package | Type | Update | Change | OpenSSF |
|---|---|---|---|---|
|
[actions/create-github-app-token](https://togithub.com/actions/create-github-app-token)
| action | minor | `v1.9.0` -> `v1.10.0` | [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/actions/create-github-app-token/badge)](https://securityscorecards.dev/viewer/?uri=github.com/actions/create-github-app-token)
|

---

### Release Notes

<details>
<summary>actions/create-github-app-token
(actions/create-github-app-token)</summary>

###
[`v1.10.0`](https://togithub.com/actions/create-github-app-token/releases/tag/v1.10.0)

[Compare
Source](https://togithub.com/actions/create-github-app-token/compare/v1.9.3...v1.10.0)

##### Features

- **`private-key`:** escaped newlines will be replaced
([#&#8203;132](https://togithub.com/actions/create-github-app-token/issues/132))
([9d23fb9](https://togithub.com/actions/create-github-app-token/commit/9d23fb93dd620572046d85c7c1032b488c12514f))

###
[`v1.9.3`](https://togithub.com/actions/create-github-app-token/releases/tag/v1.9.3)

[Compare
Source](https://togithub.com/actions/create-github-app-token/compare/v1.9.2...v1.9.3)

##### Bug Fixes

- **deps:** bump undici from 6.10.2 to 6.11.1
([#&#8203;125](https://togithub.com/actions/create-github-app-token/issues/125))
([3c223c7](https://togithub.com/actions/create-github-app-token/commit/3c223c7336e276235eb843dd4e6ad42147199cbf)),
closes
[#&#8203;3024](https://togithub.com/actions/create-github-app-token/issues/3024)
[nodejs/undici#3044](https://togithub.com/nodejs/undici/issues/3044)
[#&#8203;3023](https://togithub.com/actions/create-github-app-token/issues/3023)
[nodejs/undici#3025](https://togithub.com/nodejs/undici/issues/3025)
[nodejs/undici#3024](https://togithub.com/nodejs/undici/issues/3024)
[nodejs/undici#3034](https://togithub.com/nodejs/undici/issues/3034)
[nodejs/undici#3038](https://togithub.com/nodejs/undici/issues/3038)
[nodejs/undici#2947](https://togithub.com/nodejs/undici/issues/2947)
[nodejs/undici#3040](https://togithub.com/nodejs/undici/issues/3040)
[nodejs/undici#3036](https://togithub.com/nodejs/undici/issues/3036)
[nodejs/undici#3041](https://togithub.com/nodejs/undici/issues/3041)
[#&#8203;3024](https://togithub.com/actions/create-github-app-token/issues/3024)
[#&#8203;3041](https://togithub.com/actions/create-github-app-token/issues/3041)
[#&#8203;3036](https://togithub.com/actions/create-github-app-token/issues/3036)

###
[`v1.9.2`](https://togithub.com/actions/create-github-app-token/releases/tag/v1.9.2)

[Compare
Source](https://togithub.com/actions/create-github-app-token/compare/v1.9.1...v1.9.2)

##### Bug Fixes

- **deps:** bump the production-dependencies group with 1 update
([#&#8203;123](https://togithub.com/actions/create-github-app-token/issues/123))
([beea7b8](https://togithub.com/actions/create-github-app-token/commit/beea7b860ac0b14ca14258aca701da842aa65e30)),
closes
[nodejs/undici#2978](https://togithub.com/nodejs/undici/issues/2978)
[nodejs/undici#2971](https://togithub.com/nodejs/undici/issues/2971)
[nodejs/undici#2980](https://togithub.com/nodejs/undici/issues/2980)
[#&#8203;2982](https://togithub.com/actions/create-github-app-token/issues/2982)
[nodejs/undici#2983](https://togithub.com/nodejs/undici/issues/2983)
[nodejs/undici#2987](https://togithub.com/nodejs/undici/issues/2987)
[nodejs/undici#2991](https://togithub.com/nodejs/undici/issues/2991)
[#&#8203;2986](https://togithub.com/actions/create-github-app-token/issues/2986)
[nodejs/undici#2992](https://togithub.com/nodejs/undici/issues/2992)
[nodejs/undici#2985](https://togithub.com/nodejs/undici/issues/2985)
[nodejs/undici#2993](https://togithub.com/nodejs/undici/issues/2993)
[nodejs/undici#2995](https://togithub.com/nodejs/undici/issues/2995)
[nodejs/undici#2998](https://togithub.com/nodejs/undici/issues/2998)
[#&#8203;2863](https://togithub.com/actions/create-github-app-token/issues/2863)
[nodejs/undici#2999](https://togithub.com/nodejs/undici/issues/2999)
[nodejs/undici#3001](https://togithub.com/nodejs/undici/issues/3001)
[nodejs/undici#2971](https://togithub.com/nodejs/undici/issues/2971)
[nodejs/undici#2980](https://togithub.com/nodejs/undici/issues/2980)
[nodejs/undici#2983](https://togithub.com/nodejs/undici/issues/2983)
[nodejs/undici#2987](https://togithub.com/nodejs/undici/issues/2987)
[nodejs/undici#2991](https://togithub.com/nodejs/undici/issues/2991)
[nodejs/undici#2985](https://togithub.com/nodejs/undici/issues/2985)
[nodejs/undici#2995](https://togithub.com/nodejs/undici/issues/2995)
[nodejs/undici#2960](https://togithub.com/nodejs/undici/issues/2960)
[nodejs/undici#2959](https://togithub.com/nodejs/undici/issues/2959)
[nodejs/undici#2969](https://togithub.com/nodejs/undici/issues/2969)
[nodejs/undici#2962](https://togithub.com/nodejs/undici/issues/2962)
[nodejs/undici#2974](https://togithub.com/nodejs/undici/issues/2974)
[nodejs/undici#2967](https://togithub.com/nodejs/undici/issues/2967)
[nodejs/undici#2966](https://togithub.com/nodejs/undici/issues/2966)
[nodejs/undici#2969](https://togithub.com/nodejs/undici/issues/2969)
[nodejs/undici#2962](https://togithub.com/nodejs/undici/issues/2962)
[nodejs/undici#2826](https://togithub.com/nodejs/undici/issues/2826)
[nodejs/undici#2952](https://togithub.com/nodejs/undici/issues/2952)
[#&#8203;3001](https://togithub.com/actions/create-github-app-token/issues/3001)
[#&#8203;2863](https://togithub.com/actions/create-github-app-token/issues/2863)
[#&#8203;2999](https://togithub.com/actions/create-github-app-token/issues/2999)
[#&#8203;2998](https://togithub.com/actions/create-github-app-token/issues/2998)
[#&#8203;2993](https://togithub.com/actions/create-github-app-token/issues/2993)
[#&#8203;2986](https://togithub.com/actions/create-github-app-token/issues/2986)
[#&#8203;2992](https://togithub.com/actions/create-github-app-token/issues/2992)
[#&#8203;2991](https://togithub.com/actions/create-github-app-token/issues/2991)
[#&#8203;2987](https://togithub.com/actions/create-github-app-token/issues/2987)

###
[`v1.9.1`](https://togithub.com/actions/create-github-app-token/releases/tag/v1.9.1)

[Compare
Source](https://togithub.com/actions/create-github-app-token/compare/v1.9.0...v1.9.1)

##### Bug Fixes

- clarify `owner` input description
([#&#8203;118](https://togithub.com/actions/create-github-app-token/issues/118))
([d9bc169](https://togithub.com/actions/create-github-app-token/commit/d9bc16919cdbdb07543eb732aa872437384e296f))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJzZW12ZXI6bm9uZSJdfQ==-->

Co-authored-by: mazi-renovate[bot] <161091290+mazi-renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@ronag @codecov-commenter @metcoder95 @mcollina @RafaelGSS @FatumaA @mertcanaltin @fraxken @mweberxyz