fix(ui): escape html for console log view #4724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hi-ogawa
commented
Dec 11, 2023
sheremet-va
approved these changes
Dec 11, 2023
hi-ogawa
commented
Dec 12, 2023
Comment on lines
+1
to
+8
| export function escapeHtml(unsafe: string) { | ||
| return unsafe | ||
| .replace(/&/g, '&') | ||
| .replace(/</g, '<') | ||
| .replace(/>/g, '>') | ||
| .replace(/"/g, '"') | ||
| .replace(/'/g, ''') | ||
| } |
There was a problem hiding this comment.
It might be worth noting that the similar code is also used for junit xml.
vitest/packages/vitest/src/node/reporters/junit.ts
Lines 54 to 64 in d0c3a1f
Is it preferred to move this into @vitest/utils and share everywhere?
hi-ogawa
commented
Dec 18, 2023
Comment on lines
+6
to
+33
| // https://github.com/vitest-dev/vitest/issues/2765 | ||
| it('regexp', () => { | ||
| console.log(/(?<char>\w)/) | ||
| }) | ||
|
|
||
| // https://github.com/vitest-dev/vitest/issues/3934 | ||
| it('html-raw', async () => { | ||
| console.log(` | ||
| <form> | ||
| <label for="email">Email Address</label> | ||
| <input name="email" /> | ||
| <button>Submit</button> | ||
| </form> | ||
| `); | ||
| }) | ||
|
|
||
| // https://github.com/vitest-dev/vitest/issues/1279 | ||
| it('html-pretty', () => { | ||
| const div = document.createElement("div"); | ||
| div.innerHTML = ` | ||
| <form> | ||
| <label for="email">Email Address</label> | ||
| <input name="email" /> | ||
| <button>Submit</button> | ||
| </form> | ||
| `.replaceAll(/\n */gm, ""); // strip new liens | ||
| console.log(prettyDOM(div)) | ||
| }) |
There was a problem hiding this comment.
I add e2e tests 64ae9d2. Asserting dom format was difficult, so the actual testing is limited to only checking /(?<char>\w) string.
sheremet-va
approved these changes
Dec 18, 2023
|
Thank you! Let's try this out. |
This was referenced Dec 22, 2023
1 task
1 task
This was referenced Mar 2, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1279, #2765, #3934
I'm not sure if this naive idea is supposed to work (or already attempted before) but this is just to start investigation and I will test it further.
At least this
filter.toHtml(escapeHtml(...))pattern seems to be already used in report view:vitest/packages/ui/client/components/views/ViewReport.vue
Line 39 in 4a32fdc
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.