-
Notifications
You must be signed in to change notification settings - Fork 32
2021.07.08 Meeting Notes
Philipp Grete edited this page Jul 8, 2021
·
2 revisions
- Individual/group updates
- Schedule communication patterns discussion
- Next release
- Paper
- Review non-WIP PR
- going back to original pack interface in sparse PR (majority vote)
- currently tracking down a regression while reverting
- looking at communication patterns to figure out signaling of sparse variable communication
- will add new regression test with "sparse advection"
- going through Athena++ method paper to get more familiar with block structure AMR as implemented in
Parthenon
- working on implementing support for iterative solvers in the task infrastructure
- there existed some
whileworkarounds/hacks but they didn't allow for interleaved tasks - will have new
AddIterativeTaskcall with existing interfaces untouched - will add WIP PR soon
- may potentially add a
AddMeshTask(with support for reduction), which is also sth already implemented as a workaround inAthenaPK
- reviewed sparse PR
- almost done implementing
parthenon-hydrominiapp (right now ~1.7K LOC - trying to get it down to <1K) - still working on AMR performance regression tests
- target date the week after next week
- PG will also write the text for the Parthenon paper by then
- 11am EST Mon 19 Jul -- JL will send webex
- merge sparse in, then make next release
- afterwards remove old comm interfaces and rename
StateDescriptortoPackage
- goal to have some "very basic" text in all the method sections with the goal to get a better sense of how the pieces fit together and may still be missing/not well connected.
- Phoebus uses complex geometries that are expensive to calc on the fly
- Caching of geometry helped a lot in performance
- However, geometry only changes after mesh refinement
- Added hack to "FillDerived" on first call after refinement
- Will try to reintroduce
InitUserMeshBlockData(which is still present in Parthenon but the function call is commented out)