Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react monorepo to v17 (major) #728

Merged
merged 6 commits into from Dec 7, 2020
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 26, 2020

This PR contains the following updates:

Package Type Update Change
react (source) dependencies major 16.14.0 -> 17.0.1
react-dom (source) dependencies major 16.14.0 -> 17.0.1
react-test-renderer (source) dependencies major 16.14.0 -> 17.0.1

Release Notes

facebook/react

v17.0.1

Compare Source

React DOM

v17.0.0

Compare Source

Today, we are releasing React 17!

Learn more about React 17 and how to update to it on the official React blog.

React
React DOM
React DOM Server
React Test Renderer
Concurrent Mode (Experimental)

Renovate configuration

📅 Schedule: "before 3am on Monday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the maintenance label Oct 26, 2020
@webteam-app
Copy link

renovate[bot] is not a collaborator of the repo

@barrymcgee
Copy link
Contributor

Enzyme doesn't officially support React 17 yet but there is a community adaptor available which I swapped in; enzymejs/enzyme#2429 (comment)

@barrymcgee
Copy link
Contributor

@hatched We've now hit this issue: facebook/create-react-app#9896

Can those mocks be refactored?

@hatched
Copy link
Contributor

hatched commented Oct 26, 2020

We mocked out react-ga globally so that we wouldn't inadvertently send analytics pings so I don't think we want to skip on that one.

I can't remember why we mocked the Topology ones. But I believe it had to do with testing d3 with jsdom issues so I'm not entirely sure we can skip that one either. We should revisit re-enabling that component in tests as it's been a while.

@barrymcgee
Copy link
Contributor

@hatched I ran the codemod npx react-codemod update-react-imports over this hence the large changeset 🤓

Copy link
Contributor

@hatched hatched left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small deps request.

package.json Show resolved Hide resolved
@hatched hatched merged commit 692b2d9 into master Dec 7, 2020
@hatched hatched deleted the renovate/major-react-monorepo branch December 7, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants