Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update docusaurus monorepo to v2.3.0 #7475

Merged
merged 6 commits into from Feb 3, 2023
Merged

fix(deps): update docusaurus monorepo to v2.3.0 #7475

merged 6 commits into from Feb 3, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 27, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@docusaurus/core 2.2.0 -> 2.3.0 age adoption passing confidence
@docusaurus/module-type-aliases 2.2.0 -> 2.3.0 age adoption passing confidence
@docusaurus/plugin-content-docs 2.2.0 -> 2.3.0 age adoption passing confidence
@docusaurus/preset-classic 2.2.0 -> 2.3.0 age adoption passing confidence

Release Notes

facebook/docusaurus

v2.3.0

Compare Source

🚀 New Feature
  • docusaurus-theme-translations
  • docusaurus-plugin-content-blog
  • docusaurus-theme-classic, docusaurus-theme-common, docusaurus
  • docusaurus
    • #​8397 feat(core): deploy CLI - add support for git url "insteadOf": use 'remote get-url' to determine source repo url (@​friederbluemle)
  • docusaurus-theme-search-algolia
    • #​8428 feat(theme-algolia): add option.replaceSearchResultPathname to process/replaceAll search result urls
  • docusaurus-plugin-google-tag-manager
    • #​8470 feat(plugin-google-tag-manager): add new google-tag-manager plugin + deprecate google-analytics plugin
🐛 Bug Fix
  • docusaurus-mdx-loader
    • #​8303 fix(mdx-loader): support nested admonitions
    • #​8282 fix(mermaid): fix Mermaid integration for v9.2 release
  • docusaurus-theme-common
  • docusaurus
  • docusaurus-theme-classic, docusaurus
    • #​8445 fix(theme-classic) extract HomeBreadcrumbItem + fix swizzle bugs (@​3v0k4)
  • docusaurus-theme-search-algolia
  • docusaurus-theme-classic, docusaurus-theme-common
    • #​8486 fix(theme): refactor Tabs, make groupId + queryString work fine together (@​slorber)
  • docusaurus-theme-classic
  • docusaurus-theme-translations
    • #​8424 fix(translations): typo in lastUpdatedAtBy Vietnamese translation (@​slorber)
    • #​8289 fix(theme-translations): complete Turkish theme translations
    • #​8406 fix(translations): complete farsi theme translations
    • #​8450 fix(theme-translations): complete Vietnamese theme translations
    • #​8525 chore(theme-translations): complete pl translations
  • docusaurus-plugin-content-blog
  • docusaurus-plugin-content-docs
  • docusaurus-utils
  • create-docusaurus, docusaurus-theme-classic
    • #​8279 fix(create-docusaurus): improve init template misleading doc + add Docuaurus social card (@​slorber)
💅 Polish
  • docusaurus-theme-classic, docusaurus
    • #​8445 fix(theme-classic) extract HomeBreadcrumbItem + fix swizzle bugs (@​3v0k4)
  • docusaurus-theme-translations
  • eslint-plugin
Committers: 16

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the release:chore This PR is a chore (means nothing for users) label Jan 27, 2023
@renovate renovate bot force-pushed the renovate/docusaurus-monorepo branch 5 times, most recently from 36c06fb to 653fc81 Compare January 29, 2023 02:25
@jtoar
Copy link
Contributor

jtoar commented Jan 29, 2023

Looks like docusaurus removed the useTabGroupChoices hook, but that's out fault for importing from the internal package.

@jtoar
Copy link
Contributor

jtoar commented Jan 29, 2023

We may also want to take advantage of the new tab-query-string-in-URL feature in 2.3.0: https://docusaurus.io/docs/markdown-features/tabs#query-string. Relevant PRs:

@renovate renovate bot force-pushed the renovate/docusaurus-monorepo branch 22 times, most recently from e042fa9 to b622f84 Compare January 31, 2023 22:04
@renovate renovate bot force-pushed the renovate/docusaurus-monorepo branch 9 times, most recently from 494a843 to dfd606b Compare February 2, 2023 08:42
@renovate renovate bot force-pushed the renovate/docusaurus-monorepo branch from dfd606b to 4670df8 Compare February 2, 2023 13:09
@Tobbe
Copy link
Member

Tobbe commented Feb 2, 2023 •
edited

Looks like they replaced it with a new useTabs hook. We could probably do cost { selectedValue } = useTabs()

Even if we turn on queryString for our tabs I still want useTabs() (or something like it) to be able to read from localStorage, so that it remembers your choice if you open a new browser tab or close the tab and come back

EDIT:

useTabs is a no-go. It crashes if there aren't any actual tabs on the page when you try to use it.

Uncaught TypeError: Cannot read properties of undefined (reading 'map')
    at extractChildrenTabValues (tabsUtils.tsx?219d:71:1)

EDIT 2:

Found a much better hook, useStorageSlot. Easier to use, and no more imports from /internal 🙂

@renovate renovate bot force-pushed the renovate/docusaurus-monorepo branch from 4670df8 to 151916b Compare February 2, 2023 20:55
@renovate
Copy link
Contributor Author

renovate bot commented Feb 2, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

@jtoar
Copy link
Contributor

jtoar commented Feb 3, 2023

Thanks @Tobbe! Not sure why but I'm seeing a layout shift in this implementation:

fix.deps._.update.docusaurus.monorepo.to.v2.3.0.by.renovate.bot.Pull.Request.7475.redwoodjs_redwood.-.2.February.2023.mp4

@Tobbe
Copy link
Member

Tobbe commented Feb 3, 2023

@jtoar looks like that might actually be a bug with Docusaurus itself, introduced in 2.3. I filed an issue facebook/docusaurus#8625

jtoar
jtoar approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep it's all good now, thanks @Tobbe!

@jtoar jtoar merged commit f797d8d into main Feb 3, 2023
@jtoar jtoar deleted the renovate/docusaurus-monorepo branch February 3, 2023 16:51
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Feb 3, 2023
jtoar added a commit that referenced this pull request Feb 4, 2023
@renovate @Tobbe @jtoar
fix(deps): update docusaurus monorepo to v2.3.0 (#7475)
7b3a697 
* fix(deps): update docusaurus monorepo to v2.3.0

* fix(deps): update docusaurus monorepo to v2.3.0

* useStorageSlot

* fix: update to docusaurus 2.3.1

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
jtoar added a commit that referenced this pull request Feb 4, 2023
@renovate @Tobbe @jtoar
fix(deps): update docusaurus monorepo to v2.3.0 (#7475)
174422a 
* fix(deps): update docusaurus monorepo to v2.3.0

* fix(deps): update docusaurus monorepo to v2.3.0

* useStorageSlot

* fix: update to docusaurus 2.3.1

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
@jtoar jtoar modified the milestones: next-release, v4.1.0 Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtoar jtoar jtoar approved these changes

Assignees
No one assigned
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtoar @Tobbe