Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update docusaurus to ~2.3.0 #6386

Closed
wants to merge 2 commits into from
Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 30, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@docusaurus/core ~2.2.0 -> ~2.3.0 age adoption passing confidence
@docusaurus/module-type-aliases ~2.2.0 -> ~2.3.0 age adoption passing confidence
@docusaurus/plugin-pwa ~2.2.0 -> ~2.3.0 age adoption passing confidence
@docusaurus/preset-classic ~2.2.0 -> ~2.3.0 age adoption passing confidence
@docusaurus/remark-plugin-npm2yarn ~2.2.0 -> ~2.3.0 age adoption passing confidence
@docusaurus/theme-common ~2.2.0 -> ~2.3.0 age adoption passing confidence

Release Notes

facebook/docusaurus

v2.3.0

Compare Source

🚀 New Feature
  • docusaurus-theme-translations
  • docusaurus-plugin-content-blog
  • docusaurus-theme-classic, docusaurus-theme-common, docusaurus
  • docusaurus
    • #​8397 feat(core): deploy CLI - add support for git url "insteadOf": use 'remote get-url' to determine source repo url (@​friederbluemle)
  • docusaurus-theme-search-algolia
    • #​8428 feat(theme-algolia): add option.replaceSearchResultPathname to process/replaceAll search result urls
  • docusaurus-plugin-google-tag-manager
    • #​8470 feat(plugin-google-tag-manager): add new google-tag-manager plugin + deprecate google-analytics plugin
🐛 Bug Fix
  • docusaurus-mdx-loader
    • #​8303 fix(mdx-loader): support nested admonitions
    • #​8282 fix(mermaid): fix Mermaid integration for v9.2 release
  • docusaurus-theme-common
  • docusaurus
  • docusaurus-theme-classic, docusaurus
    • #​8445 fix(theme-classic) extract HomeBreadcrumbItem + fix swizzle bugs (@​3v0k4)
  • docusaurus-theme-search-algolia
  • docusaurus-theme-classic, docusaurus-theme-common
    • #​8486 fix(theme): refactor Tabs, make groupId + queryString work fine together (@​slorber)
  • docusaurus-theme-classic
  • docusaurus-theme-translations
    • #​8424 fix(translations): typo in lastUpdatedAtBy Vietnamese translation (@​slorber)
    • #​8289 fix(theme-translations): complete Turkish theme translations
    • #​8406 fix(translations): complete farsi theme translations
    • #​8450 fix(theme-translations): complete Vietnamese theme translations
    • #​8525 chore(theme-translations): complete pl translations
  • docusaurus-plugin-content-blog
  • docusaurus-plugin-content-docs
  • docusaurus-utils
  • create-docusaurus, docusaurus-theme-classic
    • #​8279 fix(create-docusaurus): improve init template misleading doc + add Docuaurus social card (@​slorber)
💅 Polish
  • docusaurus-theme-classic, docusaurus
    • #​8445 fix(theme-classic) extract HomeBreadcrumbItem + fix swizzle bugs (@​3v0k4)
  • docusaurus-theme-translations
  • eslint-plugin
Committers: 16

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added dependencies Issue about dependencies of the package javascript Pull requests that update Javascript code labels Jan 30, 2023
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @renovate[bot]!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Jan 30, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 48d40e9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Jan 30, 2023

Deploy Preview for typescript-eslint failed.

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63d85994f86c2c00a4e37e0f

@bradzacher
Copy link
Member

bradzacher commented Jan 30, 2023

9:53:34 AM: [ERROR] Docusaurus server-side rendering could not render static page with path /rules/adjacent-overload-signatures.
9:53:34 AM: [ERROR] Docusaurus server-side rendering could not render static page with path /rules/array-type.

......... one for each rule page
9:53:37 AM: Error: Missing getServerSnapshot, which is required for server-rendered content. Will revert to client rendering.

......... one for each rule page
9:53:37 AM: [WARNING] {"moduleIdentifier":"/opt/build/repo/node_modules/babel-loader/lib/index.js??ruleSet[1].rules[5].use[0]!/opt/build/repo/packages/website/src/components/config/utils.ts","moduleName":"./src/components/config/utils.ts","loc":"1:140-145","message":"export 'parse' (imported as 'parse') was not found in 'json5' (possible exports: default)","compilerPath":"server"}
9:53:37 AM: [ERROR] Unable to build website for locale en.
9:53:37 AM: [ERROR] Error: Failed to compile with errors.
9:53:37 AM:     at /opt/build/repo/node_modules/@docusaurus/core/lib/webpack/utils.js:180:24
9:53:37 AM:     at /opt/build/repo/node_modules/webpack/lib/MultiCompiler.js:554:14
9:53:37 AM:     at processQueueWorker (/opt/build/repo/node_modules/webpack/lib/MultiCompiler.js:491:6)
9:53:37 AM:     at processTicksAndRejections (node:internal/process/task_queues:78:11)

This is probably the issue?
export 'parse' (imported as 'parse') was not found in 'json5' (possible exports: default)

Looking at json5 - it looks like there is a mismatch between the "module" runtime code and the "commonjs" code.

So it looks like a bug in their module build step.
Also weird that docusaurus is using the module code given we do everything as CommonJS (at least I thought we did?) cc @Josh-Cena

Found this bug already filed.... over 2 years ago!!! json5/json5#240

@renovate
Copy link
Contributor Author

renovate bot commented Jan 30, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@Josh-Cena
Copy link
Member

There's stuff going on with v2.3 and React 18 (facebook/docusaurus#8592), I'm pretty sure we are seeing the same bug here with the mention of getServerSnapshot. Let's hold this off until next week.

@bradzacher
Copy link
Member

Yeah I was going to say - fixing the json5 bug didn't actually fix the build.

Interestingly - Error: Missing getServerSnapshot, which is required for server-rendered content. Will revert to client rendering. is logged as an error by react, but it's not actually thrown as an error, but docusaurus sees it as a build-stopping error.

@bradzacher bradzacher closed this Jan 31, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Jan 31, 2023

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will now ignore this update (~2.3.0). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate renovate bot deleted the renovate/docusaurus branch January 31, 2023 00:12
@Josh-Cena
Copy link
Member

Error: Missing getServerSnapshot, which is required for server-rendered content. Will revert to client rendering. is logged as an error by react, but it's not actually thrown as an error

...really? We probably need to dig deeper, then. I'd admit we didn't do a great job at indicating what the actual culprit is.

@bradzacher
Copy link
Member

oh no - it is thrown during the SSR.
had to do some digging to find it
https://github.com/facebook/react/blob/main/packages/react-reconciler/src/ReactFiberHooks.js#L1579-L1582

@Josh-Cena
Copy link
Member

I really wonder what the Will revert to client rendering. is supposed to mean when they just terminate the process ^^

@bradzacher
Copy link
Member

bradzacher commented Jan 31, 2023

It means "crash out and return nothing for the server render so there's nothing for the client to hydrate from, so it has to render from scratch"

Which is the correct message if you're SSRing in response to a request.
But if you're SSGing, then it's an entirely incorrect message.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Issue about dependencies of the package javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants