-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update docusaurus to ~2.3.0 #6386
Conversation
Thanks for the PR, @renovate[bot]! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
❌ Deploy Preview for typescript-eslint failed.
|
a3fdd10
to
4361064
Compare
This is probably the issue?
Looking at json5 - it looks like there is a mismatch between the "module" runtime code and the "commonjs" code.
So it looks like a bug in their module build step. Found this bug already filed.... over 2 years ago!!! json5/json5#240 |
4361064
to
633eaee
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. ⚠ Warning: custom changes will be lost. |
There's stuff going on with v2.3 and React 18 (facebook/docusaurus#8592), I'm pretty sure we are seeing the same bug here with the mention of |
Yeah I was going to say - fixing the json5 bug didn't actually fix the build. Interestingly - |
Renovate Ignore NotificationAs this PR has been closed unmerged, Renovate will now ignore this update (~2.3.0). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened. |
...really? We probably need to dig deeper, then. I'd admit we didn't do a great job at indicating what the actual culprit is. |
oh no - it is thrown during the SSR. |
I really wonder what the |
It means "crash out and return nothing for the server render so there's nothing for the client to hydrate from, so it has to render from scratch" Which is the correct message if you're SSRing in response to a request. |
This PR contains the following updates:
~2.2.0
->~2.3.0
~2.2.0
->~2.3.0
~2.2.0
->~2.3.0
~2.2.0
->~2.3.0
~2.2.0
->~2.3.0
~2.2.0
->~2.3.0
Release Notes
facebook/docusaurus
v2.3.0
Compare Source
🚀 New Feature
docusaurus-theme-translations
docusaurus-plugin-content-blog
docusaurus-theme-classic
,docusaurus-theme-common
,docusaurus
docusaurus
docusaurus-theme-search-algolia
docusaurus-plugin-google-tag-manager
🐛 Bug Fix
docusaurus-mdx-loader
docusaurus-theme-common
docusaurus
docusaurus-theme-classic
,docusaurus
docusaurus-theme-search-algolia
docusaurus-theme-classic
,docusaurus-theme-common
docusaurus-theme-classic
docusaurus-theme-translations
docusaurus-plugin-content-blog
docusaurus-plugin-content-docs
docusaurus-utils
create-docusaurus
,docusaurus-theme-classic
💅 Polish
docusaurus-theme-classic
,docusaurus
docusaurus-theme-translations
eslint-plugin
Committers: 16
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.