Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript-eslint monorepo to v3 (major) #589

Merged
merged 2 commits into from May 23, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 21, 2020

This PR contains the following updates:

Package Type Update Change
@typescript-eslint/eslint-plugin devDependencies major 2.34.0 -> 3.0.0
@typescript-eslint/parser devDependencies major 2.34.0 -> 3.0.0

Release Notes

typescript-eslint/typescript-eslint

v3.0.0

Compare Source

Please see the release notes for v3.0.0

Bug Fixes
  • eslint-plugin: [dot-notation] fix typo in schema (#​2040) (242328f)
  • eslint-plugin: correct parser peerDep version (fe59f69)
  • experimental-utils: add back SourceCode.isSpaceBetweenTokens (ae82ea4)
  • typescript-estree: remove now defunct Import node type (f199cbd)
  • typescript-estree: use TSEmptyBodyFunctionExpression for body-less nodes (#​1289) (82e7163)
Features
  • add index files to parser and typescript-estree (3dfc46d)
  • eslint-plugin: [no-floating-promises] ignore void operator by default (#​2003) (3626a67)
  • eslint-plugin: [no-unnecessary-condition] remove checkArrayPredicates and always check it (#​1579) (bfd9b60)
  • eslint-plugin: [no-unnecessary-condition] report when non-nullish is compared to null/undefined (#​1659) (7fa9060)
  • eslint-plugin: [prefer-nullish-coalescing][prefer-optional-chain] remove unsafe fixers (52b6085)
  • eslint-plugin: [restrict-template-expressions] allowNumber: true by default (#​2005) (643ec24)
  • eslint-plugin: [restrict-template-expressions] rename allowNullable to allowNullish (#​2006) (264b017)
  • experimental-utils: upgrade eslint types for v7 (#​2023) (06869c9)
  • bump minimum required TS version (#​2004) (7ad4d7c)
  • upgrade to ESLint v7 (#​2022) (208de71)
  • eslint-plugin: [ban-types] rework default options (#​848) (8e31d5d)
  • eslint-plugin: [no-unnecessary-condition] remove option ignoreRHS (#​1163) (ee8dd8f)
  • eslint-plugin: [strict-boolean-expression] rework options (#​1631) (cd14482)
  • eslint-plugin: delete deprecated rules (#​2002) (da0aec2)
  • eslint-plugin: eslint-recommended: disable no-func-assign (#​984) (ae9b8a9)
  • eslint-plugin: eslint-recommended: disable no-obj-calls (#​1000) (b9ca14c)
  • eslint-plugin: update eslint-recommended set (#​1996) (9a96e18)
  • eslint-plugin: update recommended sets (#​2001) (0126b4f)
  • typescript-estree: align nodes with estree 2020 (#​1389) (aff5b62)
  • typescript-estree: align optional fields (#​1429) (0e0010f)
  • drop support for node v8 (#​1997) (b6c3b7b)
  • typescript-estree: always return parserServices (#​716) (5b23443)
  • typescript-estree: handle 3.9's non-null assertion changes (#​2036) (06bec63)

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled due to failing status checks.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@bbarry
Copy link
Contributor

bbarry commented May 21, 2020

lint failure due to typescript-eslint/typescript-eslint#848

[P in keyof T]: T[P] extends {} ? DeepPartial<T[P]> : T[P];

perhaps a better type:

export type DeepPartial<T> = {
    [P in keyof T]?: T[P] extends Record<P, T[P]> ? DeepPartial<T[P]> : T[P];
};

@renovate
Copy link
Contributor Author

renovate bot commented May 23, 2020

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@@ -1,7 +1,7 @@
import { Exec } from "../adapters/exec";

export type DeepPartial<T> = {
[P in keyof T]: T[P] extends {} ? DeepPartial<T[P]> : T[P];
[P in keyof T]?: T[P] extends Record<P, T[P]> ? DeepPartial<T[P]> : T[P];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion @bbarry! Seems to work great.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading it more this type is wrong? I think it should work for now because it is basically being treated as any here but I'll try and write some tests and put in a pr at some point.

@JoshuaKGoldberg JoshuaKGoldberg force-pushed the renovate/major-typescript-eslint-monorepo branch from ae3a424 to 6ce2c8b Compare May 23, 2020 07:38
@JoshuaKGoldberg JoshuaKGoldberg merged commit f4fb3a6 into master May 23, 2020
@JoshuaKGoldberg JoshuaKGoldberg deleted the renovate/major-typescript-eslint-monorepo branch May 23, 2020 07:40
@KingDarBoja KingDarBoja added the dependencies Pull requests that update a dependency file label May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants