Fix indexing of routes #30762

dylandreimerink · 2024-02-14T11:43:58Z

The RouteID.Key() was supposed to make a composite key from 'table + index + destination', but due to a copy-paste brainfart the composite index was 'table + table + destination'.

Fix Key() to correctly build the key. While at it, make it more efficient by pre-allocating the correct fixed-size byte slice.

Fixes: #30563
Fixes: 8abf620 ("devices_controller: Switched devices and routes from StateDB to StateDB2")

Fix bug in indexing of routes that lead to veth devices being considered native devices, which caused the wrong BPF program to be loaded onto them.

Issue #30563 showed that veth devices were picked as selected native devices even though they did not have a route. This was due to a bug in the route StateDB table indexing. This commit expands the devices controller tests to catch this wrong behavior. Signed-off-by: Jussi Maki <jussi@isovalent.com>

The RouteID.Key() was supposed to make a composite key from 'table + index + destination', but due to a copy-paste brainfart the composite index was 'table + table + destination'. Fix Key() to correctly build the key. While at it, make it more efficient by pre-allocating the correct fixed-size byte slice. Fixes: #30563 Fixes: 8abf620 ("devices_controller: Switched devices and routes from StateDB to StateDB2") Signed-off-by: Jussi Maki <jussi@isovalent.com>

We are failing a e2e test quite consistantly, while the root cause is not fully clear, it seems that setting devices explicitly might help. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>

dylandreimerink · 2024-02-14T12:39:42Z

/test

pkg/datapath/linux/devices_controller_test.go

pkg/datapath/tables/route.go

ldelossa

Overall logic looks fine. Just a few nitty comments.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [cilium](https://cilium.io/) ([source](https://togithub.com/cilium/cilium)) | HelmChart | patch | `1.15.0` -> `1.15.1` | | [cilium](https://cilium.io/) ([source](https://togithub.com/cilium/cilium)) | | patch | `1.15.0` -> `1.15.1` | --- ### Release Notes <details> <summary>cilium/cilium (cilium)</summary> ### [`v1.15.1`](https://togithub.com/cilium/cilium/releases/tag/v1.15.1): 1.15.1 [Compare Source](https://togithub.com/cilium/cilium/compare/1.15.0...1.15.1) We are pleased to release Cilium v1.15.1. This release contains various bug fixes and improvements, including a fix for a regression where veth devices were incorrectly getting classified as native devices ([cilium/cilium#30762). ## Summary of Changes **Minor Changes:** - Enhance trace events from the outbound SNAT path, to report the pre-SNAT IP address and the interface index of the egress interface. (Backport PR [#30704](https://togithub.com/cilium/cilium/issues/30704), Upstream PR [#28723](https://togithub.com/cilium/cilium/issues/28723), [@julianwiedmann](https://togithub.com/julianwiedmann)) - ui: release v0.13.0 (Backport PR [#30727](https://togithub.com/cilium/cilium/issues/30727), Upstream PR [#30711](https://togithub.com/cilium/cilium/issues/30711), [@geakstr](https://togithub.com/geakstr)) **Bugfixes:** - envoy: Change socket option from 'STATE_LISTENING' to 'STATE_PREBIND' (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30543](https://togithub.com/cilium/cilium/issues/30543), [@chaunceyjiang](https://togithub.com/chaunceyjiang)) - Fix bug in indexing of routes that lead to veth devices being considered native devices, which caused the wrong BPF program to be loaded onto them. (Backport PR [#30767](https://togithub.com/cilium/cilium/issues/30767), Upstream PR [#30762](https://togithub.com/cilium/cilium/issues/30762), [@dylandreimerink](https://togithub.com/dylandreimerink)) - fix edge case in node addressing logic which could result in a panic (Backport PR [#30767](https://togithub.com/cilium/cilium/issues/30767), Upstream PR [#30757](https://togithub.com/cilium/cilium/issues/30757), [@dylandreimerink](https://togithub.com/dylandreimerink)) - hive: Fix start hook log output (Backport PR [#30727](https://togithub.com/cilium/cilium/issues/30727), Upstream PR [#30712](https://togithub.com/cilium/cilium/issues/30712), [@joamaki](https://togithub.com/joamaki)) - Updating ENI prefix delegation fallback to use dedicated error codes (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30536](https://togithub.com/cilium/cilium/issues/30536), [@hemanthmalla](https://togithub.com/hemanthmalla)) **CI Changes:** - ci: add trigger phrase to Gateway API conformance test workflow name (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30525](https://togithub.com/cilium/cilium/issues/30525), [@tklauser](https://togithub.com/tklauser)) - CI: Change cloud regions (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30378](https://togithub.com/cilium/cilium/issues/30378), [@brlbil](https://togithub.com/brlbil)) - ci: Fix PR labels parsing in update label workflow (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30507](https://togithub.com/cilium/cilium/issues/30507), [@pippolo84](https://togithub.com/pippolo84)) - gh: ci-verifier: use lvh-images/complexity-test as renovate dependency (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30520](https://togithub.com/cilium/cilium/issues/30520), [@julianwiedmann](https://togithub.com/julianwiedmann)) - gha: additionally cover BPF masquerade in clustermesh E2E tests (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30321](https://togithub.com/cilium/cilium/issues/30321), [@giorio94](https://togithub.com/giorio94)) - gha: make runner type for clustermesh workflows configurable (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30496](https://togithub.com/cilium/cilium/issues/30496), [@giorio94](https://togithub.com/giorio94)) - Update GitHub upload-artifact action (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30443](https://togithub.com/cilium/cilium/issues/30443), [@brlbil](https://togithub.com/brlbil)) - workflows: Clean IPsec test output (Backport PR [#30767](https://togithub.com/cilium/cilium/issues/30767), Upstream PR [#30759](https://togithub.com/cilium/cilium/issues/30759), [@pchaigno](https://togithub.com/pchaigno)) **Misc Changes:** - Added Last page Edit on Documentation (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30612](https://togithub.com/cilium/cilium/issues/30612), [@gailsuccess](https://togithub.com/gailsuccess)) - bgpv1: remove BGP Controller from daemon cell (Backport PR [#30767](https://togithub.com/cilium/cilium/issues/30767), Upstream PR [#30561](https://togithub.com/cilium/cilium/issues/30561), [@harsimran-pabla](https://togithub.com/harsimran-pabla)) - chore(deps): update all github action dependencies (v1.15) (patch) ([#30486](https://togithub.com/cilium/cilium/issues/30486), [@renovate](https://togithub.com/renovate)\[bot]) - chore(deps): update all kind-images main (v1.15) (patch) ([#30670](https://togithub.com/cilium/cilium/issues/30670), [@renovate](https://togithub.com/renovate)\[bot]) - chore(deps): update dependency cilium/cilium-cli to v0.15.21 (v1.15) ([#30570](https://togithub.com/cilium/cilium/issues/30570), [@renovate](https://togithub.com/renovate)\[bot]) - chore(deps): update dependency cilium/cilium-cli to v0.15.22 (v1.15) ([#30671](https://togithub.com/cilium/cilium/issues/30671), [@renovate](https://togithub.com/renovate)\[bot]) - chore(deps): update stable lvh-images (v1.15) (patch) ([#30574](https://togithub.com/cilium/cilium/issues/30574), [@renovate](https://togithub.com/renovate)\[bot]) - dep: Bump grpc_health_probe to v0.4.24 (Backport PR [#30704](https://togithub.com/cilium/cilium/issues/30704), Upstream PR [#30643](https://togithub.com/cilium/cilium/issues/30643), [@ferozsalam](https://togithub.com/ferozsalam)) - docs: Document XfrmInStateInvalid errors (Backport PR [#30767](https://togithub.com/cilium/cilium/issues/30767), Upstream PR [#30151](https://togithub.com/cilium/cilium/issues/30151), [@pchaigno](https://togithub.com/pchaigno)) - egressgw: improvements for FIB-driven redirect path (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30576](https://togithub.com/cilium/cilium/issues/30576), [@julianwiedmann](https://togithub.com/julianwiedmann)) - Fix failure in `FuzzDenyPreferredInsert` test (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30368](https://togithub.com/cilium/cilium/issues/30368), [@christarazi](https://togithub.com/christarazi)) **Other Changes:** - \[v1.15] ci/ipsec: Fix downgrade version for release preparation commits ([#30718](https://togithub.com/cilium/cilium/issues/30718), [@qmonnet](https://togithub.com/qmonnet)) - envoy: Bump envoy version to v1.27.3 ([#30696](https://togithub.com/cilium/cilium/issues/30696), [@sayboras](https://togithub.com/sayboras)) - install: Update image digests for v1.15.0 ([#30559](https://togithub.com/cilium/cilium/issues/30559), [@aanm](https://togithub.com/aanm)) ##### v1.15.0 ##### Docker Manifests </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [cilium](https://cilium.io/) ([source](https://togithub.com/cilium/cilium)) | HelmChart | patch | `1.15.0` -> `1.15.1` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>cilium/cilium (cilium)</summary> ### [`v1.15.1`](https://togithub.com/cilium/cilium/releases/tag/v1.15.1): 1.15.1 [Compare Source](https://togithub.com/cilium/cilium/compare/1.15.0...1.15.1) We are pleased to release Cilium v1.15.1. This release contains various bug fixes and improvements, including a fix for a regression where veth devices were incorrectly getting classified as native devices ([cilium/cilium#30762). ## Summary of Changes **Minor Changes:** - Enhance trace events from the outbound SNAT path, to report the pre-SNAT IP address and the interface index of the egress interface. (Backport PR [#30704](https://togithub.com/cilium/cilium/issues/30704), Upstream PR [#28723](https://togithub.com/cilium/cilium/issues/28723), [@julianwiedmann](https://togithub.com/julianwiedmann)) - ui: release v0.13.0 (Backport PR [#30727](https://togithub.com/cilium/cilium/issues/30727), Upstream PR [#30711](https://togithub.com/cilium/cilium/issues/30711), [@geakstr](https://togithub.com/geakstr)) **Bugfixes:** - envoy: Change socket option from 'STATE_LISTENING' to 'STATE_PREBIND' (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30543](https://togithub.com/cilium/cilium/issues/30543), [@chaunceyjiang](https://togithub.com/chaunceyjiang)) - Fix bug in indexing of routes that lead to veth devices being considered native devices, which caused the wrong BPF program to be loaded onto them. (Backport PR [#30767](https://togithub.com/cilium/cilium/issues/30767), Upstream PR [#30762](https://togithub.com/cilium/cilium/issues/30762), [@dylandreimerink](https://togithub.com/dylandreimerink)) - fix edge case in node addressing logic which could result in a panic (Backport PR [#30767](https://togithub.com/cilium/cilium/issues/30767), Upstream PR [#30757](https://togithub.com/cilium/cilium/issues/30757), [@dylandreimerink](https://togithub.com/dylandreimerink)) - hive: Fix start hook log output (Backport PR [#30727](https://togithub.com/cilium/cilium/issues/30727), Upstream PR [#30712](https://togithub.com/cilium/cilium/issues/30712), [@joamaki](https://togithub.com/joamaki)) - Updating ENI prefix delegation fallback to use dedicated error codes (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30536](https://togithub.com/cilium/cilium/issues/30536), [@hemanthmalla](https://togithub.com/hemanthmalla)) **CI Changes:** - ci: add trigger phrase to Gateway API conformance test workflow name (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30525](https://togithub.com/cilium/cilium/issues/30525), [@tklauser](https://togithub.com/tklauser)) - CI: Change cloud regions (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30378](https://togithub.com/cilium/cilium/issues/30378), [@brlbil](https://togithub.com/brlbil)) - ci: Fix PR labels parsing in update label workflow (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30507](https://togithub.com/cilium/cilium/issues/30507), [@pippolo84](https://togithub.com/pippolo84)) - gh: ci-verifier: use lvh-images/complexity-test as renovate dependency (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30520](https://togithub.com/cilium/cilium/issues/30520), [@julianwiedmann](https://togithub.com/julianwiedmann)) - gha: additionally cover BPF masquerade in clustermesh E2E tests (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30321](https://togithub.com/cilium/cilium/issues/30321), [@giorio94](https://togithub.com/giorio94)) - gha: make runner type for clustermesh workflows configurable (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30496](https://togithub.com/cilium/cilium/issues/30496), [@giorio94](https://togithub.com/giorio94)) - Update GitHub upload-artifact action (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30443](https://togithub.com/cilium/cilium/issues/30443), [@brlbil](https://togithub.com/brlbil)) - workflows: Clean IPsec test output (Backport PR [#30767](https://togithub.com/cilium/cilium/issues/30767), Upstream PR [#30759](https://togithub.com/cilium/cilium/issues/30759), [@pchaigno](https://togithub.com/pchaigno)) **Misc Changes:** - Added Last page Edit on Documentation (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30612](https://togithub.com/cilium/cilium/issues/30612), [@gailsuccess](https://togithub.com/gailsuccess)) - bgpv1: remove BGP Controller from daemon cell (Backport PR [#30767](https://togithub.com/cilium/cilium/issues/30767), Upstream PR [#30561](https://togithub.com/cilium/cilium/issues/30561), [@harsimran-pabla](https://togithub.com/harsimran-pabla)) - chore(deps): update all github action dependencies (v1.15) (patch) ([#30486](https://togithub.com/cilium/cilium/issues/30486), [@renovate](https://togithub.com/renovate)\[bot]) - chore(deps): update all kind-images main (v1.15) (patch) ([#30670](https://togithub.com/cilium/cilium/issues/30670), [@renovate](https://togithub.com/renovate)\[bot]) - chore(deps): update dependency cilium/cilium-cli to v0.15.21 (v1.15) ([#30570](https://togithub.com/cilium/cilium/issues/30570), [@renovate](https://togithub.com/renovate)\[bot]) - chore(deps): update dependency cilium/cilium-cli to v0.15.22 (v1.15) ([#30671](https://togithub.com/cilium/cilium/issues/30671), [@renovate](https://togithub.com/renovate)\[bot]) - chore(deps): update stable lvh-images (v1.15) (patch) ([#30574](https://togithub.com/cilium/cilium/issues/30574), [@renovate](https://togithub.com/renovate)\[bot]) - dep: Bump grpc_health_probe to v0.4.24 (Backport PR [#30704](https://togithub.com/cilium/cilium/issues/30704), Upstream PR [#30643](https://togithub.com/cilium/cilium/issues/30643), [@ferozsalam](https://togithub.com/ferozsalam)) - docs: Document XfrmInStateInvalid errors (Backport PR [#30767](https://togithub.com/cilium/cilium/issues/30767), Upstream PR [#30151](https://togithub.com/cilium/cilium/issues/30151), [@pchaigno](https://togithub.com/pchaigno)) - egressgw: improvements for FIB-driven redirect path (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30576](https://togithub.com/cilium/cilium/issues/30576), [@julianwiedmann](https://togithub.com/julianwiedmann)) - Fix failure in `FuzzDenyPreferredInsert` test (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30368](https://togithub.com/cilium/cilium/issues/30368), [@christarazi](https://togithub.com/christarazi)) **Other Changes:** - \[v1.15] ci/ipsec: Fix downgrade version for release preparation commits ([#30718](https://togithub.com/cilium/cilium/issues/30718), [@qmonnet](https://togithub.com/qmonnet)) - envoy: Bump envoy version to v1.27.3 ([#30696](https://togithub.com/cilium/cilium/issues/30696), [@sayboras](https://togithub.com/sayboras)) - install: Update image digests for v1.15.0 ([#30559](https://togithub.com/cilium/cilium/issues/30559), [@aanm](https://togithub.com/aanm)) #### v1.15.0 #### Docker Manifests </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cilium](https://cilium.io/) ([source](https://togithub.com/cilium/cilium)) | patch | `1.15.0` -> `1.15.1` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>cilium/cilium (cilium)</summary> ### [`v1.15.1`](https://togithub.com/cilium/cilium/releases/tag/v1.15.1): 1.15.1 [Compare Source](https://togithub.com/cilium/cilium/compare/1.15.0...1.15.1) We are pleased to release Cilium v1.15.1. This release contains various bug fixes and improvements, including a fix for a regression where veth devices were incorrectly getting classified as native devices ([cilium/cilium#30762). ## Summary of Changes **Minor Changes:** - Enhance trace events from the outbound SNAT path, to report the pre-SNAT IP address and the interface index of the egress interface. (Backport PR [#30704](https://togithub.com/cilium/cilium/issues/30704), Upstream PR [#28723](https://togithub.com/cilium/cilium/issues/28723), [@julianwiedmann](https://togithub.com/julianwiedmann)) - ui: release v0.13.0 (Backport PR [#30727](https://togithub.com/cilium/cilium/issues/30727), Upstream PR [#30711](https://togithub.com/cilium/cilium/issues/30711), [@geakstr](https://togithub.com/geakstr)) **Bugfixes:** - envoy: Change socket option from 'STATE_LISTENING' to 'STATE_PREBIND' (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30543](https://togithub.com/cilium/cilium/issues/30543), [@chaunceyjiang](https://togithub.com/chaunceyjiang)) - Fix bug in indexing of routes that lead to veth devices being considered native devices, which caused the wrong BPF program to be loaded onto them. (Backport PR [#30767](https://togithub.com/cilium/cilium/issues/30767), Upstream PR [#30762](https://togithub.com/cilium/cilium/issues/30762), [@dylandreimerink](https://togithub.com/dylandreimerink)) - fix edge case in node addressing logic which could result in a panic (Backport PR [#30767](https://togithub.com/cilium/cilium/issues/30767), Upstream PR [#30757](https://togithub.com/cilium/cilium/issues/30757), [@dylandreimerink](https://togithub.com/dylandreimerink)) - hive: Fix start hook log output (Backport PR [#30727](https://togithub.com/cilium/cilium/issues/30727), Upstream PR [#30712](https://togithub.com/cilium/cilium/issues/30712), [@joamaki](https://togithub.com/joamaki)) - Updating ENI prefix delegation fallback to use dedicated error codes (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30536](https://togithub.com/cilium/cilium/issues/30536), [@hemanthmalla](https://togithub.com/hemanthmalla)) **CI Changes:** - ci: add trigger phrase to Gateway API conformance test workflow name (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30525](https://togithub.com/cilium/cilium/issues/30525), [@tklauser](https://togithub.com/tklauser)) - CI: Change cloud regions (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30378](https://togithub.com/cilium/cilium/issues/30378), [@brlbil](https://togithub.com/brlbil)) - ci: Fix PR labels parsing in update label workflow (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30507](https://togithub.com/cilium/cilium/issues/30507), [@pippolo84](https://togithub.com/pippolo84)) - gh: ci-verifier: use lvh-images/complexity-test as renovate dependency (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30520](https://togithub.com/cilium/cilium/issues/30520), [@julianwiedmann](https://togithub.com/julianwiedmann)) - gha: additionally cover BPF masquerade in clustermesh E2E tests (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30321](https://togithub.com/cilium/cilium/issues/30321), [@giorio94](https://togithub.com/giorio94)) - gha: make runner type for clustermesh workflows configurable (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30496](https://togithub.com/cilium/cilium/issues/30496), [@giorio94](https://togithub.com/giorio94)) - Update GitHub upload-artifact action (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30443](https://togithub.com/cilium/cilium/issues/30443), [@brlbil](https://togithub.com/brlbil)) - workflows: Clean IPsec test output (Backport PR [#30767](https://togithub.com/cilium/cilium/issues/30767), Upstream PR [#30759](https://togithub.com/cilium/cilium/issues/30759), [@pchaigno](https://togithub.com/pchaigno)) **Misc Changes:** - Added Last page Edit on Documentation (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30612](https://togithub.com/cilium/cilium/issues/30612), [@gailsuccess](https://togithub.com/gailsuccess)) - bgpv1: remove BGP Controller from daemon cell (Backport PR [#30767](https://togithub.com/cilium/cilium/issues/30767), Upstream PR [#30561](https://togithub.com/cilium/cilium/issues/30561), [@harsimran-pabla](https://togithub.com/harsimran-pabla)) - chore(deps): update all github action dependencies (v1.15) (patch) ([#30486](https://togithub.com/cilium/cilium/issues/30486), [@renovate](https://togithub.com/renovate)\[bot]) - chore(deps): update all kind-images main (v1.15) (patch) ([#30670](https://togithub.com/cilium/cilium/issues/30670), [@renovate](https://togithub.com/renovate)\[bot]) - chore(deps): update dependency cilium/cilium-cli to v0.15.21 (v1.15) ([#30570](https://togithub.com/cilium/cilium/issues/30570), [@renovate](https://togithub.com/renovate)\[bot]) - chore(deps): update dependency cilium/cilium-cli to v0.15.22 (v1.15) ([#30671](https://togithub.com/cilium/cilium/issues/30671), [@renovate](https://togithub.com/renovate)\[bot]) - chore(deps): update stable lvh-images (v1.15) (patch) ([#30574](https://togithub.com/cilium/cilium/issues/30574), [@renovate](https://togithub.com/renovate)\[bot]) - dep: Bump grpc_health_probe to v0.4.24 (Backport PR [#30704](https://togithub.com/cilium/cilium/issues/30704), Upstream PR [#30643](https://togithub.com/cilium/cilium/issues/30643), [@ferozsalam](https://togithub.com/ferozsalam)) - docs: Document XfrmInStateInvalid errors (Backport PR [#30767](https://togithub.com/cilium/cilium/issues/30767), Upstream PR [#30151](https://togithub.com/cilium/cilium/issues/30151), [@pchaigno](https://togithub.com/pchaigno)) - egressgw: improvements for FIB-driven redirect path (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30576](https://togithub.com/cilium/cilium/issues/30576), [@julianwiedmann](https://togithub.com/julianwiedmann)) - Fix failure in `FuzzDenyPreferredInsert` test (Backport PR [#30681](https://togithub.com/cilium/cilium/issues/30681), Upstream PR [#30368](https://togithub.com/cilium/cilium/issues/30368), [@christarazi](https://togithub.com/christarazi)) **Other Changes:** - \[v1.15] ci/ipsec: Fix downgrade version for release preparation commits ([#30718](https://togithub.com/cilium/cilium/issues/30718), [@qmonnet](https://togithub.com/qmonnet)) - envoy: Bump envoy version to v1.27.3 ([#30696](https://togithub.com/cilium/cilium/issues/30696), [@sayboras](https://togithub.com/sayboras)) - install: Update image digests for v1.15.0 ([#30559](https://togithub.com/cilium/cilium/issues/30559), [@aanm](https://togithub.com/aanm)) #### v1.15.0 #### Docker Manifests </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>

dylandreimerink requested review from a team as code owners February 14, 2024 11:43

dylandreimerink requested review from ldelossa and brlbil February 14, 2024 11:43

maintainer-s-little-helper bot added this to Needs backport from main in 1.15.1 Feb 14, 2024

dylandreimerink mentioned this pull request Feb 14, 2024

Fix indexing of routes #30691

Closed

joamaki and others added 3 commits February 14, 2024 12:47

conformance-e2e: Explicitly set devices to fix e2e tests

1cc99e8

We are failing a e2e test quite consistantly, while the root cause is not fully clear, it seems that setting devices explicitly might help. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>

dylandreimerink force-pushed the pr/joamaki/fix-route-indexing branch from 8ac89f1 to 1cc99e8 Compare February 14, 2024 11:47

ldelossa reviewed Feb 14, 2024

View reviewed changes

pkg/datapath/linux/devices_controller_test.go Show resolved Hide resolved

ldelossa reviewed Feb 14, 2024

View reviewed changes

pkg/datapath/tables/route.go Show resolved Hide resolved

ldelossa reviewed Feb 14, 2024

View reviewed changes

pkg/datapath/tables/route.go Show resolved Hide resolved

michi-covalent approved these changes Feb 14, 2024

View reviewed changes

ldelossa approved these changes Feb 14, 2024

View reviewed changes

brlbil approved these changes Feb 14, 2024

View reviewed changes

maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 14, 2024

dylandreimerink added this pull request to the merge queue Feb 14, 2024

Merged via the queue into main with commit 0e67360 Feb 14, 2024
220 checks passed

dylandreimerink deleted the pr/joamaki/fix-route-indexing branch February 14, 2024 16:07

michi-covalent mentioned this pull request Feb 14, 2024

v1.15 backports 2024-02-14 #30767

Merged

5 tasks

michi-covalent added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Feb 14, 2024

maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.15 in 1.15.1 Feb 14, 2024

github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Feb 14, 2024

maintainer-s-little-helper bot removed this from Backport pending to v1.15 in 1.15.1 Feb 14, 2024

michi-covalent mentioned this pull request Feb 14, 2024

Prepare for release v1.15.1 #30775

Merged

sayboras mentioned this pull request Mar 19, 2024

CI: Conformance E2E (ci-e2e) - ingress tests #30717

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix indexing of routes #30762

Fix indexing of routes #30762

dylandreimerink commented Feb 14, 2024

dylandreimerink commented Feb 14, 2024

ldelossa left a comment

Fix indexing of routes #30762

Fix indexing of routes #30762

Conversation

dylandreimerink commented Feb 14, 2024

dylandreimerink commented Feb 14, 2024

ldelossa left a comment

Choose a reason for hiding this comment