Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update babel monorepo #35763

Merged
merged 4 commits into from
Oct 4, 2019
Merged

fix(deps): update babel monorepo #35763

merged 4 commits into from
Oct 4, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 25, 2019

This PR contains the following updates:

Package Type Update Change
@babel/cli (source) dependencies minor 7.5.5 -> 7.6.2
@babel/polyfill (source) dependencies minor 7.4.4 -> 7.6.0
@babel/runtime dependencies minor 7.5.5 -> 7.6.2
babel-eslint devDependencies patch 10.0.2 -> 10.0.3

Release Notes

babel/babel

v7.6.2

Compare Source

👓 Spec Compliance
🐛 Bug Fix
🏠 Internal
🏃‍♀️ Performance

v7.6.0

Compare Source

👓 Spec Compliance
🚀 New Feature
🐛 Bug Fix
💅 Polish
  • babel-plugin-transform-runtime, babel-preset-env
📝 Documentation
🏠 Internal
  • babel-register
  • babel-helper-fixtures, babel-helper-transform-fixture-test-runner, babel-preset-env
  • babel-parser
  • babel-helper-fixtures, babel-helper-transform-fixture-test-runner, babel-plugin-proposal-dynamic-import, babel-preset-env
  • babel-runtime-corejs2, babel-runtime, babel-types
  • babel-cli, babel-core, babel-generator, babel-helper-create-class-features-plugin, babel-helper-fixtures, babel-node, babel-parser, babel-plugin-proposal-do-expressions, babel-plugin-proposal-pipeline-operator, babel-plugin-transform-modules-commonjs, babel-plugin-transform-runtime, babel-preset-env, babel-standalone, babel-template, babel-traverse, babel-types
  • babel-cli
🏃‍♀️ Performance
  • babel-helpers, babel-plugin-transform-modules-commonjs, babel-preset-env
  • babel-traverse
babel/babel-eslint

v10.0.3

Compare Source

Fixes #​791, also eslint/eslint#​12117

Some context: #​793 (comment)

We ended up going with @​JLHwung's PR #​794 which uses ESLint's deps instead of going with peerDeps since it really depends on the version being used and we don't want users to have to install it directly on their own.

babel-eslint is patching patches of the dependencies of ESLint itself so these kinds of issues have happened in the past. We'll need to look into figuring out how to have a more solid way of modifying behavior instead of this monkeypatching type of thing for future releases.


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner August 25, 2019 21:34
@renovate renovate bot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Task Framework labels Aug 25, 2019
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Aug 25, 2019

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~128 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-login                 +237 B  (+0.0%)      +69 B  (+0.0%)
entry-main                  +145 B  (+0.0%)      +34 B  (+0.0%)
entry-domains-landing        +92 B  (+0.0%)      +25 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~1307 bytes added 📈 [gzipped])

name                parsed_size           gzip_size
woocommerce              +836 B  (+0.0%)     +303 B  (+0.1%)
google-my-business       +836 B  (+0.3%)     +303 B  (+0.4%)
gutenberg-editor         +100 B  (+0.0%)      +36 B  (+0.0%)
themes                    +92 B  (+0.0%)      +35 B  (+0.0%)
stats                     +92 B  (+0.0%)      +35 B  (+0.0%)
settings-writing          +92 B  (+0.0%)      +35 B  (+0.0%)
security                  +92 B  (+0.0%)      +35 B  (+0.0%)
purchases                 +92 B  (+0.0%)      +35 B  (+0.0%)
posts-pages               +92 B  (+0.0%)      +35 B  (+0.0%)
posts-custom              +92 B  (+0.0%)      +35 B  (+0.0%)
post-editor               +92 B  (+0.0%)      +35 B  (+0.0%)
plans                     +92 B  (+0.0%)      +35 B  (+0.0%)
people                    +92 B  (+0.0%)      +35 B  (+0.0%)
jetpack-connect           +92 B  (+0.0%)      +35 B  (+0.0%)
help                      +92 B  (+0.0%)      +35 B  (+0.0%)
export                    +92 B  (+0.0%)      +35 B  (+0.0%)
domains                   +92 B  (+0.0%)      +35 B  (+0.0%)
concierge                 +92 B  (+0.0%)      +35 B  (+0.0%)
comments                  +92 B  (+0.0%)      +35 B  (+0.0%)
checkout                  +92 B  (+0.0%)      +35 B  (+0.0%)
activity                  +92 B  (+0.0%)      +35 B  (+0.0%)
account                   +92 B  (+0.0%)      +35 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~910 bytes added 📈 [gzipped])

name                                        parsed_size           gzip_size
async-load-design-playground                     +882 B  (+0.1%)     +311 B  (+0.1%)
async-load-design                                +882 B  (+0.0%)     +311 B  (+0.1%)
async-load-design-blocks                         +138 B  (+0.0%)      +43 B  (+0.0%)
async-load-signup-steps-plans-atomic-store        +92 B  (+0.1%)      +35 B  (+0.1%)
async-load-signup-steps-plans                     +92 B  (+0.1%)      +35 B  (+0.1%)
async-load-signup-steps-domains                   +92 B  (+0.0%)      +35 B  (+0.1%)
async-load-signup-steps-clone-point               +92 B  (+0.1%)      +35 B  (+0.1%)
async-load-reader-search-stream                   +92 B  (+0.1%)      +35 B  (+0.1%)
async-load-reader-following-manage                +92 B  (+0.1%)      +35 B  (+0.1%)
async-load-blocks-inline-help-popover             +92 B  (+0.0%)      +35 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@renovate renovate bot force-pushed the renovate/babel-monorepo branch 3 times, most recently from 22df51c to ef059a1 Compare August 30, 2019 10:12
@renovate renovate bot changed the title chore(deps): update dependency babel-eslint to v10.0.3 fix(deps): update babel monorepo Sep 6, 2019
@renovate renovate bot force-pushed the renovate/babel-monorepo branch 2 times, most recently from 583218e to 6bab8fd Compare September 26, 2019 19:15
@renovate
Copy link
Contributor Author

renovate bot commented Oct 3, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@renovate renovate bot requested review from a team as code owners October 3, 2019 09:52
@jsnajdr jsnajdr self-assigned this Oct 3, 2019
@jsnajdr
Copy link
Member

jsnajdr commented Oct 3, 2019

Pushed a few manual commits that update calypso-build's dependencies and also the FSE and WBE apps' lockfiles.

@jsnajdr
Copy link
Member

jsnajdr commented Oct 3, 2019

This bundle size increase is not good:

name                parsed_size            gzip_size
gutenberg-editor      +212787 B  (+31.7%)   +73384 B  (+39.2%)

Should be investigated before merging.

@jsnajdr
Copy link
Member

jsnajdr commented Oct 3, 2019

Turns out the size increase in gutenberg-editor was caused by bundling a few copies of Lodash from @wordpress/* packages that had a different Lodash version:

Screenshot 2019-10-03 at 13 29 12

Fixed in 989c024 by pinning the dom, shortcode and redux-routine dependencies to be in sync with other @wordpress/* packages.

Copy link
Member

@jsnajdr jsnajdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green, ready to merge 👍

@jsnajdr jsnajdr added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 3, 2019
@jsnajdr jsnajdr merged commit ffde92a into master Oct 4, 2019
@jsnajdr jsnajdr deleted the renovate/babel-monorepo branch October 4, 2019 08:28
@sgomes
Copy link
Contributor

sgomes commented Oct 4, 2019

@jsnajdr FYI: in general, the Babel configuration in calypso-build/babel/default.js needs to be updated whenever @babel/runtime is, or we run the risk of duplicating code if the helpers were updated (see #35136). Specifically, the version field in there, that refers to the helpers version.

That doesn't appear to be the case here, so we can probably keep the old version number without worrying too much, but it's good to be aware of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants