fix(deps): update dependency undici to v5 [security] - autoclosed #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
3.3.6
->5.19.1
GitHub Vulnerability Alerts
CVE-2022-31151
Impact
Authorization headers are already cleared on cross-origin redirect in
https://github.com/nodejs/undici/blob/main/lib/handler/redirect.js#L189, based on https://github.com/nodejs/undici/issues/872.
However, cookie headers which are sensitive headers and are official headers found in the spec, remain uncleared. There also has been active discussion of implementing a cookie store https://github.com/nodejs/undici/pull/1441, which suggests that there are active users using cookie headers in undici.
As such this may lead to accidental leakage of cookie to a 3rd-party site or a malicious attacker who can control the redirection target (ie. an open redirector) to leak the cookie to the 3rd party site.
Patches
This was patched in v5.8.0.
Workarounds
By default, this vulnerability is not exploitable.
Do not enable redirections, i.e.
maxRedirections: 0
(the default).References
https://hackerone.com/reports/1635514
https://curl.se/docs/CVE-2018-1000007.html
https://curl.se/docs/CVE-2022-27776.html
For more information
If you have any questions or comments about this advisory:
CVE-2022-31150
Impact
It is possible to inject CRLF sequences into request headers in Undici.
The same applies to
path
andmethod
Patches
Update to v5.8.0
Workarounds
Sanitize all HTTP headers from untrusted sources to eliminate
\r\n
.References
https://hackerone.com/reports/409943
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-12116
For more information
If you have any questions or comments about this advisory:
CVE-2022-35949
Impact
undici
is vulnerable to SSRF (Server-side Request Forgery) when an application takes in user input into thepath/pathname
option ofundici.request
.If a user specifies a URL such as
http://127.0.0.1
or//127.0.0.1
Instead of processing the request as
http://example.org//127.0.0.1
(orhttp://example.org/http://127.0.0.1
whenhttp://127.0.0.1 is used
), it actually processes the request ashttp://127.0.0.1/
and sends it tohttp://127.0.0.1
.If a developer passes in user input into
path
parameter ofundici.request
, it can result in an SSRF as they will assume that the hostname cannot change, when in actual fact it can change because the specified path parameter is combined with the base URL.Patches
This issue was fixed in
undici@5.8.1
.Workarounds
The best workaround is to validate user input before passing it to the
undici.request
call.For more information
If you have any questions or comments about this advisory:
CVE-2022-35948
Impact
=< undici@5.8.0
users are vulnerable to CRLF Injection on headers when using unsanitized input as request headers, more specifically, inside thecontent-type
header.Example:
The above snippet will perform two requests in a single
request
API call:http://localhost:3000/
http://localhost:3000/foo2
Patches
This issue was patched in Undici v5.8.1
Workarounds
Sanitize input when sending content-type headers using user input.
For more information
If you have any questions or comments about this advisory:
CVE-2023-23936
Impact
undici library does not protect
host
HTTP header from CRLF injection vulnerabilities.Patches
This issue was patched in Undici v5.19.1.
Workarounds
Sanitize the
headers.host
string before passing to undici.References
Reported at https://hackerone.com/reports/1820955.
Credits
Thank you to Zhipeng Zhang (@timon8) for reporting this vulnerability.
CVE-2023-24807
Impact
The
Headers.set()
andHeaders.append()
methods are vulnerable to Regular Expression Denial of Service (ReDoS) attacks when untrusted values are passed into the functions. This is due to the inefficient regular expression used to normalize the values in theheaderValueNormalize()
utility function.Patches
This vulnerability was patched in v5.19.1.
Workarounds
There is no workaround. Please update to an unaffected version.
References
Credits
Carter Snook reported this vulnerability.
Release Notes
nodejs/undici
v5.19.1
Compare Source
This release is part of the Node.js security release train: https://nodejs.org/en/blog/vulnerability/february-2023-security-releases/
v5.19.0
Compare Source
What's Changed
New Contributors
Full Changelog: nodejs/undici@v5.18.0...v5.19.0
v5.18.0
Compare Source
What's Changed
Full Changelog: nodejs/undici@v5.17.1...v5.18.0
v5.17.1
Compare Source
What's Changed
Full Changelog: nodejs/undici@v5.17.0...v5.17.1
v5.17.0
Compare Source
What's Changed
New Contributors
Full Changelog: nodejs/undici@v5.16.0...v5.17.0
v5.16.0
Compare Source
What's Changed
New Contributors
Full Changelog: nodejs/undici@v5.15.2...v5.16.0
v5.15.2
Compare Source
v5.15.1
Compare Source
What's Changed
Full Changelog: nodejs/undici@v5.15.0...v5.15.1
v5.15.0
Compare Source
What's Changed
New Contributors
Full Changelog: nodejs/undici@v5.14.0...v5.15.0
v5.14.0
Compare Source
What's Changed
response-static-error.any.js
by @KhafraDev in https://github.com/nodejs/undici/pull/1789New Contributors
Full Changelog: nodejs/undici@v5.13.0...v5.14.0
v5.13.0
Compare Source
What's Changed
8.2 Set request’s referrer policy on redirect
by @metcoder95 in https://github.com/nodejs/undici/pull/1717argumentLengthCheck
guard by @KhafraDev in https://github.com/nodejs/undici/pull/1755New Contributors
Full Changelog: nodejs/undici@v5.12.0...v5.13.0
v5.12.0
Compare Source
This release includes significant improvements to fetch code coverage and spec compliance as well as a new option to limit response body size.
What's Changed
Request{Init}.duplex
and add WPTs by @KhafraDev in https://github.com/nodejs/undici/pull/1681response
WPTs by @KhafraDev in https://github.com/nodejs/undici/pull/1684type
more strict by @KhafraDev in https://github.com/nodejs/undici/pull/1703scheme-blob.sub.any.js
by @KhafraDev in https://github.com/nodejs/undici/pull/1707Response.json
by @KhafraDev in https://github.com/nodejs/undici/pull/1723New Contributors
Full Changelog: nodejs/undici@v5.11.0...v5.12.0
v5.11.0
Compare Source
What's Changed
FormData
/Blob
bodies by @mrbbot in https://github.com/nodejs/undici/pull/1643MockPoolInterceptOptions.method
is optional by @KhafraDev in https://github.com/nodejs/undici/pull/1648PoolOptions
by @silverwind in https://github.com/nodejs/undici/pull/1651META
tags by @KhafraDev in https://github.com/nodejs/undici/pull/1664determineRequestReferrer
by @metcoder95 in https://github.com/nodejs/undici/pull/1236New Contributors
Full Changelog: nodejs/undici@v5.10.0...v5.11.0
v5.10.0
Compare Source
What's Changed
ArrayBufferView
andArrayBuffer
as body by @LiviaMedeiros in https://github.com/nodejs/undici/pull/1584New Contributors
Full Changelog: nodejs/undici@v5.9.1...v5.10.0
v5.9.1
What's Changed
integrity
option to Fetch by @jelmervdl in https://github.com/nodejs/undici/pull/1596byteOffset
andbyteLength
by @mrbbot in https://github.com/nodejs/undici/pull/1601New Contributors
Full Changelog: nodejs/undici@v5.8.2...v5.9.1
v5.8.2
Compare Source
undici.request
vulnerable to SSRF using absolute URL onpathname
GHSA-8qr4-xgw6-wmr3 CVE-2022-35949What's Changed
New Contributors
Full Changelog: nodejs/undici@v5.8.1...v5.8.2
v5.8.1
Compare Source
What's Changed
isErrorLike
by @KhafraDev in https://github.com/nodejs/undici/pull/1570New Contributors
Full Changelog: nodejs/undici@v5.8.0...v5.8.1
v5.8.0
Compare Source
What's Changed
exclude
in CI by @dominykas in https://github.com/nodejs/undici/pull/1544New Contributors
Full Changelog: nodejs/undici@v5.7.0...v5.7.1
v5.7.0
Compare Source
What's Changed
Headers.prototype.set
by @KhafraDev in https://github.com/nodejs/undici/pull/1535Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.