chore(deps): update typescript-eslint monorepo to v3 (major) #769

renovate · 2020-06-04T06:44:31Z

This PR contains the following updates:

Package	Type	Update	Change
@typescript-eslint/eslint-plugin	devDependencies	major	`2.34.0` -> `3.1.0`
@typescript-eslint/parser	devDependencies	major	`2.34.0` -> `3.1.0`

Release Notes

typescript-eslint/typescript-eslint

`v3.1.0`

Compare Source

Bug Fixes

eslint-plugin: [explicit-module-boundary-types] don't check returned functions if parent function has return type (#2084) (d7d4eeb)
eslint-plugin: [no-unnecessary-condition] handle comparison of any, unknown and loose comparisons with nullish values (#2123) (1ae1d01)
eslint-plugin: [no-unnecessary-condition] improve optional chain handling (#2111) (9ee399b)
eslint-plugin: [no-unnecessary-condition] improve optional chain handling 2 - electric boogaloo (#2138) (c87cfaf)
eslint-plugin: [no-unused-expressions] ignore import expressions (#2130) (e383691)
eslint-plugin: [no-var-requires] false negative for TSAsExpression and MemberExpression (#2139) (df95338)
experimental-utils: downlevel type declarations for versions older than 3.8 (#2133) (7925823)

Features

eslint-plugin: [ban-ts-comments] add "allow-with-description" option (#2099) (8a0fd18)
eslint-plugin: [ban-types] allow selective disable of default options with false value (#2137) (1cb8ca4)
eslint-plugin: [explicit-module-boundary-types] improve accuracy and coverage (#2135) (caaa859)

3.0.2 (2020-05-27)

Bug Fixes

regression for eslint v6 (#2105) (31fc503)

3.0.1 (2020-05-25)

Bug Fixes

eslint-plugin: [naming-convention] handle no options correctly (#2095) (fd7d02b)
eslint-plugin: [no-throw-literal] handle intersection and union types (#2085) (cae037f)
eslint-plugin: [unbound-method] fix crash due to missing Intl (#2090) (f2fa82c)
experimental-utils: export CLIEngine & ESLint (#2083) (014341b)
typescript-estree: handle BigInt with _ numeric separator (#2067) (66f1627)
typescript-estree: mark TS 3.8 and 3.9 as "supported" (#2057) (5eedbff), closes #1436 #1436

`v3.0.2`

Compare Source

Bug Fixes

regression for eslint v6 (#2105) (31fc503)

`v3.0.1`

Compare Source

Bug Fixes

eslint-plugin: [naming-convention] handle no options correctly (#2095) (fd7d02b)
eslint-plugin: [no-throw-literal] handle intersection and union types (#2085) (cae037f)
eslint-plugin: [unbound-method] fix crash due to missing Intl (#2090) (f2fa82c)
experimental-utils: export CLIEngine & ESLint (#2083) (014341b)
typescript-estree: handle BigInt with _ numeric separator (#2067) (66f1627)
typescript-estree: mark TS 3.8 and 3.9 as "supported" (#2057) (5eedbff), closes #1436 #1436

`v3.0.0`

Compare Source

Please see the release notes for v3.0.0

Bug Fixes

eslint-plugin: [dot-notation] fix typo in schema (#2040) (242328f)
eslint-plugin: correct parser peerDep version (fe59f69)
experimental-utils: add back SourceCode.isSpaceBetweenTokens (ae82ea4)
typescript-estree: remove now defunct Import node type (f199cbd)
typescript-estree: use TSEmptyBodyFunctionExpression for body-less nodes (#1289) (82e7163)

Features

add index files to parser and typescript-estree (3dfc46d)
eslint-plugin: [no-floating-promises] ignore void operator by default (#2003) (3626a67)
eslint-plugin: [no-unnecessary-condition] remove checkArrayPredicates and always check it (#1579) (bfd9b60)
eslint-plugin: [no-unnecessary-condition] report when non-nullish is compared to null/undefined (#1659) (7fa9060)
eslint-plugin: [prefer-nullish-coalescing][prefer-optional-chain] remove unsafe fixers (52b6085)
eslint-plugin: [restrict-template-expressions] allowNumber: true by default (#2005) (643ec24)
eslint-plugin: [restrict-template-expressions] rename allowNullable to allowNullish (#2006) (264b017)
experimental-utils: upgrade eslint types for v7 (#2023) (06869c9)
bump minimum required TS version (#2004) (7ad4d7c)
upgrade to ESLint v7 (#2022) (208de71)
eslint-plugin: [ban-types] rework default options (#848) (8e31d5d)
eslint-plugin: [no-unnecessary-condition] remove option ignoreRHS (#1163) (ee8dd8f)
eslint-plugin: [strict-boolean-expression] rework options (#1631) (cd14482)
eslint-plugin: delete deprecated rules (#2002) (da0aec2)
eslint-plugin: eslint-recommended: disable no-func-assign (#984) (ae9b8a9)
eslint-plugin: eslint-recommended: disable no-obj-calls (#1000) (b9ca14c)
eslint-plugin: update eslint-recommended set (#1996) (9a96e18)
eslint-plugin: update recommended sets (#2001) (0126b4f)
typescript-estree: align nodes with estree 2020 (#1389) (aff5b62)
typescript-estree: align optional fields (#1429) (0e0010f)
drop support for node v8 (#1997) (b6c3b7b)
typescript-estree: always return parserServices (#716) (5b23443)
typescript-estree: handle 3.9's non-null assertion changes (#2036) (06bec63)

Renovate configuration

📅 Schedule: "on Thursday every 4 weeks of the year starting on the 3rd week" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

hzhu · 2020-06-04T22:24:59Z

.eslintrc.json

@@ -38,8 +38,16 @@
    "react-hooks/exhaustive-deps": "warn",
    "@typescript-eslint/explicit-function-return-type": "off",
    "@typescript-eslint/no-explicit-any": "off",
-    "@typescript-eslint/camelcase": ["error", { "properties": "never" }],
-    "@typescript-eslint/interface-name-prefix": ["error", "always"],


Removing these rules as they ave been deprecated in v3.0.0 and replaced with naming-convention.

+ fix ban-type lint warnings

hzhu · 2020-06-04T23:06:17Z

packages/notifications/src/utils/icons.ts

@@ -11,7 +11,7 @@ import AlertWarningStrokeIcon from '@zendeskgarden/svg-icons/src/16/alert-warnin
 import InfoStrokeIcon from '@zendeskgarden/svg-icons/src/16/info-stroke.svg';
 import { VALIDATION_TYPE } from './types';

-export const validationIcons: Record<VALIDATION_TYPE, object> = {
+export const validationIcons: Record<VALIDATION_TYPE, Record<string, unknown>> = {


Updates have been made to the types using {} and object. The defaults for @typescript-eslint/ban-types have been updated to warn when these types are used, and provides suggestions:

renovate · 2020-06-05T01:04:30Z

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

coveralls · 2020-06-05T01:25:30Z

Coverage remained the same at 97.696% when pulling cfd022d on renovate/major-typescript-eslint-monorepo into 18130c0 on master.

hzhu

✅

jzempel

nice @hzhu makes sense.

renovate bot requested a review from a team as a code owner June 4, 2020 06:44

renovate bot added the PR: Internal 🌱 label Jun 4, 2020

renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch 3 times, most recently from 16288ab to 98393bd Compare June 4, 2020 20:44

hzhu reviewed Jun 4, 2020

View reviewed changes

chore(deps): update typescript-eslint monorepo to v3

ad22042

renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from 0966331 to ad22042 Compare June 4, 2020 22:25

Update eslintrc; remove deprecated rules

cfd022d

+ fix ban-type lint warnings

hzhu reviewed Jun 4, 2020

View reviewed changes

renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch 2 times, most recently from 5f97c28 to b92645d Compare June 5, 2020 00:15

hzhu force-pushed the renovate/major-typescript-eslint-monorepo branch from b92645d to cfd022d Compare June 5, 2020 01:03

zendesk-garden temporarily deployed to staging June 5, 2020 01:38 Inactive

hzhu approved these changes Jun 5, 2020

View reviewed changes

jzempel approved these changes Jun 5, 2020

View reviewed changes

hzhu merged commit 1403d68 into master Jun 5, 2020

hzhu deleted the renovate/major-typescript-eslint-monorepo branch June 5, 2020 02:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): update typescript-eslint monorepo to v3 (major) #769

chore(deps): update typescript-eslint monorepo to v3 (major) #769

renovate bot commented Jun 4, 2020 •

edited

hzhu Jun 4, 2020

hzhu Jun 4, 2020 •

edited

renovate bot commented Jun 5, 2020

coveralls commented Jun 5, 2020

hzhu left a comment

jzempel left a comment

chore(deps): update typescript-eslint monorepo to v3 (major) #769

chore(deps): update typescript-eslint monorepo to v3 (major) #769

Conversation

renovate bot commented Jun 4, 2020 • edited

Release Notes

v3.1.0

Bug Fixes

Features

3.0.2 (2020-05-27)

Bug Fixes

3.0.1 (2020-05-25)

Bug Fixes

v3.0.2

Bug Fixes

v3.0.1

Bug Fixes

v3.0.0

Please see the release notes for v3.0.0

Bug Fixes

Features

Renovate configuration

hzhu Jun 4, 2020

Choose a reason for hiding this comment

hzhu Jun 4, 2020 • edited

Choose a reason for hiding this comment

renovate bot commented Jun 5, 2020

PR has been edited

coveralls commented Jun 5, 2020

hzhu left a comment

Choose a reason for hiding this comment

jzempel left a comment

Choose a reason for hiding this comment

renovate bot commented Jun 4, 2020 •

edited

`v3.1.0`

`v3.0.2`

`v3.0.1`

`v3.0.0`

hzhu Jun 4, 2020 •

edited