Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js to v13.11.0 #8806

Merged
merged 1 commit into from Mar 23, 2020
Merged

Update Node.js to v13.11.0 #8806

merged 1 commit into from Mar 23, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 4, 2020

This PR contains the following updates:

Package Type Update New value References Sourcegraph
node minor 13.11.0 source code search for "node"
@types/node devDependencies patch 13.9.3 source code search for "@types/node"

Release Notes

nodejs/node

v13.11.0

Compare Source

Notable Changes
  • async_hooks: add sync enterWith to ALS (Stephen Belanger) #​31945
  • cli: allow --jitless V8 flag in NODE_OPTIONS (Andrew Neitsch) #​32100
  • fs: return first folder made by mkdir recursive (Benjamin Coe) #​31530
  • n-api: define release 6 (Gabriel Schulhof) #​32058
  • os: create a getter for kernel version (Juan José Arboleda) #​31732
  • wasi: add returnOnExit option (Colin Ihrig) #​32101
Commits

v13.10.1

Compare Source

Notable Changes

In Node.js 13.9.0 deps/zlib was switched to the chromium maintained implementation. This change
had the unforseen consequence of breaking building from the tarballs we release as we were too
aggressively removing unneccessary files from the deps/zlib folder. This release includes
a patch that ensures that individuals will once again be able to build Node.js from source.

Commits

v13.10.0

Compare Source

Notable Changes
  • async_hooks
    • introduce async-context API (vdeturckheim) #​26540
  • stream
    • support passing generator functions into pipeline() (Robert Nagy) #​31223
  • tls
    • expose SSL_export_keying_material (simon) #​31814
  • vm
    • implement vm.measureMemory() for per-context memory measurement (Joyee Cheung) #​31824
Commits

Renovate configuration

📅 Schedule: "on the 1st through 7th day of the month" in timezone America/Los_Angeles.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team March 4, 2020 18:07
@renovate renovate bot added the bot label Mar 4, 2020
@renovate renovate bot changed the title Update Node.js to v13.10.0 Update Node.js to v13.10.1 Mar 5, 2020
@eseliger eseliger closed this Mar 9, 2020
@eseliger
Copy link
Member

eseliger commented Mar 9, 2020

Broken: sindresorhus/got#1107

@renovate
Copy link
Contributor Author

renovate bot commented Mar 9, 2020

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will now ignore this update (13.10.1). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate renovate bot deleted the renovate/node-13.x branch March 9, 2020 16:11
@felixfbecker
Copy link
Contributor

Let's keep it open an request changes, so Renovate doesn't just open a new one on the next version without the note from here 👍

@felixfbecker felixfbecker restored the renovate/node-13.x branch March 9, 2020 16:44
@felixfbecker felixfbecker reopened this Mar 9, 2020
Copy link
Contributor

@felixfbecker felixfbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks got: sindresorhus/got#1107

@felixfbecker
Copy link
Contributor

@sourcegraph/code-intel perhaps there's also a (sensible) unit test that could be written that fails on this branch, so that we will confidently and automatically know when the problem was fixed?

@renovate renovate bot changed the title Update Node.js to v13.10.1 Update Node.js to v13.11.0 Mar 12, 2020
@renovate renovate bot force-pushed the renovate/node-13.x branch 2 times, most recently from 0a0d166 to 6cfcfc1 Compare March 18, 2020 21:38
@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #8806 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8806   +/-   ##
=======================================
  Coverage   41.50%   41.50%           
=======================================
  Files        1315     1315           
  Lines       71537    71537           
  Branches     6601     6601           
=======================================
  Hits        29694    29694           
  Misses      39111    39111           
  Partials     2732     2732           

@felixfbecker
Copy link
Contributor

There are some reports in sindresorhus/got#1107 that 3.11 fixed the issue

@felixfbecker
Copy link
Contributor

The issue on node is also closed: nodejs/node#32105

@felixfbecker
Copy link
Contributor

@sourcegraph/code-intel I'm tagging you for review since you noticed the issue inside lsif/ :)

@felixfbecker felixfbecker requested a review from a team March 23, 2020 19:16
@efritz efritz merged commit 101385e into master Mar 23, 2020
@efritz efritz deleted the renovate/node-13.x branch March 23, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants