Update eslint (major) #1851
Update eslint (major) #1851
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
Deploy preview for nusmods ready! Built with commit ebf8281 |
renovate
bot
force-pushed
the
renovate/major-eslint
branch
14 times, most recently
from
3a3bab7
to
b1dd258
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/major-eslint
branch
from
b1dd258
to
ebfc594
Compare
|
Failing test caused by typescript-eslint/typescript-eslint#639. We'll need to wait for |
renovate
bot
force-pushed
the
renovate/major-eslint
branch
11 times, most recently
from
1282330
to
243e07a
Compare
renovate
bot
force-pushed
the
renovate/major-eslint
branch
13 times, most recently
from
564423e
to
93eca0d
Compare
renovate
bot
force-pushed
the
renovate/major-eslint
branch
from
93eca0d
to
72db4f5
Compare
- Disabled some false positive and unwanted rules - Downgraded some rules pending fixes
PR has been edited👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description. |
| // @ts-ignore Not technically safe, since some ReactNodes are also functions, but this is safe enough | ||
| return children(isOnline); | ||
| // Not technically safe, since some ReactNodes are also functions, but this is safe enough | ||
| return (children as Function)(isOnline); |
There was a problem hiding this comment.
Interesting, typescript still won't infer children as functions here?
Codecov Report
@@ Coverage Diff @@
## master #1851 +/- ##
==========================================
- Coverage 45.74% 45.73% -0.02%
==========================================
Files 238 238
Lines 4945 4944 -1
Branches 1159 1159
==========================================
- Hits 2262 2261 -1
Misses 2683 2683
Continue to review full report at Codecov.
|
This PR contains the following updates:
1.13.0->2.3.31.13.0->2.3.35.16.0->6.5.117.1.1->18.0.113.2.0->14.0.04.3.0->6.4.0Release Notes
typescript-eslint/typescript-eslint
v2.3.3Compare Source
Bug Fixes
v2.3.2Compare Source
Bug Fixes
v2.3.1Compare Source
Bug Fixes
v2.3.0Compare Source
Bug Fixes
Features
v2.2.0Compare Source
Bug Fixes
Features
v2.1.0Compare Source
Bug Fixes
Features
v2.0.0Compare Source
Bug Fixes
Features
as constarrow functions (#876) (14c6f80)options.project(#806) (9e5f21e)eslint/eslint
v6.5.1Compare Source
0d3d7d9Docs: fix typo in no-magic-numbers (#12345) (Josiah Rooney)447ac87Fix: no-useless-rename handles ExperimentalRestProperty (fixes #12335) (#12339) (Kai Cataldo)b6ff73cSponsors: Sync README with website (ESLint Jenkins)v6.5.0Compare Source
73596cbUpdate: Add enforceForSwitchCase option to use-isnan (#12106) (Milos Djermanovic)d592a24Fix: exclude\u000dso new line won't convert to text (fixes #12027) (#12031) (zamboney)e85d27aFix: no-regex-spaces false positives and invalid autofix (fixes #12226) (#12231) (Milos Djermanovic)b349bf7Fix: prefer-named-capture-group incorrect locations (fixes #12233) (#12247) (Milos Djermanovic)7dc1ea9Fix: no-useless-return autofix removes comments (#12292) (Milos Djermanovic)0e68677Fix: no-extra-bind autofix removes comments (#12293) (Milos Djermanovic)6ad7e86Fix: no-extra-label autofix removes comments (#12298) (Milos Djermanovic)acec201Fix: no-undef-init autofix removes comments (#12299) (Milos Djermanovic)d89390bFix: use async reading of stdin in bin/eslint.js (fixes #12212) (#12230) (Barrie Treloar)334ca7cUpdate: no-useless-rename also reports default values (fixes #12301) (#12322) (Kai Cataldo)41bfe91Update: Fix handling of chained new expressions in new-parens (#12303) (Milos Djermanovic)160b7c4Chore: add autofix npm script (#12330) (Kai Cataldo)04b6adbChore: enable eslint-plugin-jsdoc (refs #11146) (#12332) (Kai Cataldo)9b86167Docs: Add new ES environments to Configuring ESLint (#12289) (Milos Djermanovic)c9aeab2Docs: Add supported ECMAScript version to README (#12290) (Milos Djermanovic)8316e7bFix: no-useless-rename autofix removes comments (#12300) (Milos Djermanovic)29c12f1Chore: cache results in runtime-info (#12320) (Kai Cataldo)f5537b2Fix: prefer-numeric-literals autofix removes comments (#12313) (Milos Djermanovic)11ae6fcUpdate: Fix call, new and member expressions in no-extra-parens (#12302) (Milos Djermanovic)a7894ebNew: add --env-info flag to CLI (#12270) (Kai Cataldo)61392ffSponsors: Sync README with website (ESLint Jenkins)2c6bf8eDocs: English fix (#12306) (Daniel Nixon)6f11877Sponsors: Sync README with website (ESLint Jenkins)2e202caDocs: fix links in array-callback-return (#12288) (Milos Djermanovic)e39c631Docs: add example for CLIEngine#executeOnText 3rd arg (#12286) (Kai Cataldo)d4f9a16Update: add support for JSXFragments in indent rule (fixes #12208) (#12210) (Kai Cataldo)c6af95fSponsors: Sync README with website (ESLint Jenkins)8cadd52Sponsors: Sync README with website (ESLint Jenkins)f9fc695Chore: enable default-param-last (#12244) (薛定谔的猫)9984c3eDocs: Update README team and sponsors (ESLint Jenkins)v6.4.0Compare Source
e915fffDocs: Improve examples and clarify default option (#12067) (Yuping Zuo)540296fUpdate: enforceForClassMembers option to accessor-pairs (fixes #12063) (#12192) (Milos Djermanovic)d3c2334Update: flag nested block with declaration as error (#12193) (David Waller)b2498d2Update: Fix handling of property names in no-self-assign (#12105) (Milos Djermanovic)1ee61b0Update: enforceForClassMembers computed-property-spacing (fixes #12049) (#12214) (Milos Djermanovic)520c922Docs: Added naming convention details to plugin usage (#12202) (Henrique Barcelos)f826eabFix: Allow line comment exception in object-curly-spacing (fixes #11902) (#12216) (Milos Djermanovic)db2a29bUpdate: indentation of comment followed by semicolon (fixes #12232) (#12243) (Kai Cataldo)ae17d1cFix: no-sequences is reporting incorrect locations (#12241) (Milos Djermanovic)365331aFix: object-shorthand providing invalid fixes for typescript (#12260) (Brad Zacher)1c921c6New: add no-import-assign (fixes #12237) (#12252) (Toru Nagashima)3be04fdNew: Add prefer-regex-literals rule (fixes #12238) (#12254) (Milos Djermanovic)37c0fdeUpdate: Report global Atomics calls in no-obj-calls (fixes #12234) (#12258) (Milos Djermanovic)985c9e5Fix: space-before-function-paren autofix removes comments (fixes #12259) (#12264) (Milos Djermanovic)01da7d0Fix: eqeqeq rule reports incorrect locations (#12265) (Milos Djermanovic)319e4d8Docs: adding finally example (#12256) (Jens Melgaard)d52328fDocs: fix no-sequenceswithexamples (#12239) (Milos Djermanovic)a41fdc0Fix: Remove autofixer for no-unsafe-negation (#12157) (Milos Djermanovic)e38f5fdUpdate: fix no-octal-escape false negatives after \0 (#12079) (Milos Djermanovic)9418fbeSponsors: Sync README with website (ESLint Jenkins)acc5ec5Sponsors: Sync README with website (ESLint Jenkins)460c5adSponsors: Sync README with website (ESLint Jenkins)0313441New: add rule default-param-last (fixes #11361) (#12188) (Chiawen Chen)7621f5dUpdate: add more specific linting messages to space-in-parens (#11121) (Che Fisher)21eb904Fix: basePath of OverrideTester (fixes #12032) (#12205) (Toru Nagashima)86e5e65Sponsors: Sync README with website (ESLint Jenkins)2b1a13fFix: no-extra-boolean-cast reports wrong negation node (fixes #11324) (#12197) (Milos Djermanovic)ba8c2aaSponsors: Sync README with website (ESLint Jenkins)a0a9746Docs: Fix link in no-irregular-whitespace.md (#12196) (Timo Tijhof)e10eebaFix: quotes autofix produces syntax error with octal escape sequences (#12118) (Milos Djermanovic)v6.3.0Compare Source
0acdefbChore: refactor code (#12113) (James George)52e2cf5New: reportUnusedDisableDirectives in config (refs eslint/rfcs#22) (#12151) (Toru Nagashima)020f952Update: enforceForSequenceExpressions to no-extra-parens (fixes #11916) (#12142) (Milos Djermanovic)aab1b84Fix: reset to the default color (#12174) (Ricardo Gobbo de Souza)4009d39Fix: yoda rule produces invalid autofix with preceding yield (#12166) (Milos Djermanovic)febb660Fix: no-extra-boolean-cast invalid autofix with yield before negation (#12164) (Milos Djermanovic)4c0b70bNew: support TypeScript at config initializer (fixes #11789) (#12172) (Pig Fang)94e39d9Chore: use GitHub Actions (#12144) (Toru Nagashima)e88f305Chore: support es2020 in fuzz (#12180) (薛定谔的猫)00d2c5bDocs: corrected class extension example (#12176) (Marius M)31e5428Chore: Fix wrong error object keys in test files (#12162) (Milos Djermanovic)197f443Fix: func-name-matching crash on descriptor-like arguments (#12100) (Milos Djermanovic)644ce33Fix: no-self-assign false positive with rest and spread in array (#12099) (Milos Djermanovic)a81d263Fix: fix message of function-paren-newline (#12136) (Pig Fang)77f8ed1Chore: update blogpost template (#12154) (Toru Nagashima)6abc7b7Docs: Document the exception in no-unsafe-negation (#12161) (Milos Djermanovic)v6.2.2Compare Source
0e0b784Upgrade: espree@^6.1.1 (#12158) (Kevin Partington)04e859fSponsors: Sync README with website (ESLint Jenkins)34783d1Sponsors: Sync README with website (ESLint Jenkins)b809e72Docs: Update README team and sponsors (ESLint Jenkins)v6.2.1Compare Source
8c021b5Upgrade: eslint-utils 1.4.2 (#12131) (Toru Nagashima)e82388bSponsors: Sync README with website (ESLint Jenkins)4aeeeedDocs: update docs for ecmaVersion 2020 (#12120) (silverwind)6886148Docs: Add duplicate keys limitation to accessor-pairs (#12124) (Milos Djermanovic)v6.2.0Compare Source
fee6acbUpdate: support bigint and dynamic import (refs #11803) (#11983) (Toru Nagashima)afd8012New: noInlineConfig setting (refs eslint/rfcs#22) (#12091) (Toru Nagashima)3d12378Update: Fix accessor-pairs to enforce pairs per property in literals (#12062) (Milos Djermanovic)8cd00b3New: function-call-argument-newline (#12024) (finico)30ebf92Fix: prefer-template autofix produces syntax error with octal escapes (#12085) (Milos Djermanovic)13c3988Fix: Check literal type explicitly in dot-notation (#12095) (Milos Djermanovic)3e5cecaFix: Handle empty string property names in getFunctionNameWithKind (#12104) (Milos Djermanovic)9a043ffFix: no-duplicate-case false positives on Object.prototype keys (#12107) (Milos Djermanovic)fe631afChore: minor typo fix (#12112) (James George)4cb7877Fix: fix no-extra-parens ignores some nodes (#11909) (Pig Fang)2dc23b8Update: fix no-dupe-keys false negatives on empty string names (#12069) (Milos Djermanovic)19ab666Fix: yoda exceptRange false positives on empty string property names (#12071) (Milos Djermanovic)d642150Update: Check empty string property names in sort-keys (#12073) (Milos Djermanovic)acce6deFix: class-methods-use-this reports 'undefined' names (#12103) (Milos Djermanovic)92ec2cbFix: Allow bind call with a single spread element in no-extra-bind (#12088) (Milos Djermanovic)bfdb0c9Fix: no-extra-boolean-cast invalid autofix for Boolean() without args (#12076) (Milos Djermanovic)34ccc0cChore: Remove TDZ scope type condition from no-unused-vars (#12055) (Milos Djermanovic)01d38ceDocs: Remove TDZ scope from the scope manager interface documentation (#12054) (Milos Djermanovic)1aff8fcUpdate: warn about mixing ternary and logical operators (fixes #11704) (#12001) (Karthik Priyadarshan)11be2f8Docs: do not recommend global-installed usage (#12016) (薛定谔的猫)cf31dabFix: no-restricted-syntax - correct the schema (#12051) (Brad Zacher)fbec99eUpdate: fix class-methods-use-this false negatives with exceptMethods (#12077) (Milos Djermanovic)fb08b7cDocs: Remove readonly/writable global logic from no-undef (fixes #11963) (#12053) (Milos Djermanovic)5b5934bSponsors: Sync README with website (ESLint Jenkins)9156760Sponsors: Sync README with website (ESLint Jenkins)f5e0cc4Update: Check computed method keys in no-extra-parens (#11973) (Milos Djermanovic)d961438Docs: Fix Incorrect Documentation (#12045) (Michael Miceli)887d08cSponsors: Sync README with website (ESLint Jenkins)d90183fDocs: add a case to func-names (#12038) (Chiawen Chen)8a5b62dDocs: no use eslint.linter in code example (#12037) (薛定谔的猫)5831767Update: report location of func-names (fixes #12022) (#12028) (Pig Fang)v6.1.0Compare Source
8f86ccaUpgrade: eslint-scope@^5.0.0 (#12011) (Kevin Partington)d08683eFix: glob processing (fixes #11940) (#11986) (Toru Nagashima)bfcf8b2Fix: dot-location errors with parenthesized objects (fixes #11868) (#11933) (Milos Djermanovic)79e8d09Fix: add parens for sequence expr in arrow-body-style (fixes #11917) (#11918) (Pig Fang)105c098Docs: update docs for object-curly-spacing (fixes #11634) (#12009) (Chiawen Chen)c90a12cChore: update release script for new website repo (#12006) (Kai Cataldo)e2c08a9Sponsors: Sync README with website (ESLint Jenkins)b974fcbUpdate: Check computed property keys in no-extra-parens (#11952) (Milos Djermanovic)222d27cUpdate: Add for-in and for-of checks for props in no-param-reassign (#11941) (Milos Djermanovic)e4c450fFix: no-extra-parens autofix withinin a for-loop init (fixes #11706) (#11848) (Milos Djermanovic)2dafe2dFix: prefer-const produces invalid autofix (fixes #11699) (#11827) (Milos Djermanovic)cb475fdFix: Cache file error handling on read-only file system. (fixes #11945) (#11946) (Cuki)89412c3Docs: Fixed a typo (fixes #11999) (#12000) (Eddie Olson)6669f78Fix: --init with Vue.js failed (fixes #11970) (#11985) (Toru Nagashima)93633c2Upgrade: Upgrade lodash dependency (fixes #11992) (#11994) (Cyd La Luz)776dae7Docs: fix wrong Node.js version in getting started (#11993) (Toru Nagashima)4448261Docs: some typos and optimization points (#11960) (Jason Lee)2a10856Chore: Add temporary test files to .gitignore (#11978) (Milos Djermanovic)d83b233Chore: update path for release bundles (#11977) (Kai Cataldo)1fb3620Fix: creating of enabledGlobals object without prototype (fixes #11929) (#11935) (finico)c2f2db9Docs: Replace global true and false with writable and readonly in rules (#11956) (Milos Djermanovic)19335b8Fix: actual messageId and expected messageId are switched in rule tester (#11928) (Milos Djermanovic)8b216e0Docs: Fix incorrect example comments for unicode-bom rule (fixes #11937) (#11938) (Brandon Yeager)cc3885bChore: add v8-compile-cache to speed up instantiation time (#11921) (薛定谔的猫)d8f2688Upgrade: deps (#11904) (薛定谔的猫)e5f1cccDocs: add 'stricter rule config validating' in migrating docs (#11905) (薛定谔的猫)v6.0.1Compare Source
b5bde06Fix: --rulesdir option didn't work (fixes #11888) (#11890) (Toru Nagashima)13f0418Fix: improve error message on --print-config (fixes #11874) (#11885) (Toru Nagashima)056c2aaFix: improve diagnostics for shareable-config-missing errors (#11880) (Teddy Katz)566b7aaDocs: Update no-confusing-arrow with the new default option (#11886) (Yuping Zuo)d07f3faFix: CLIEngine#getRules() contains plugin rules (fixes #11871) (#11872) (Toru Nagashima)21f4a80Docs: Fix inconsistent linking in migration guide (#11881) (Teddy Katz)f3a0774Docs: Fix typo in 6.0.0 migration guide (#11870) (Kevin Partington)v6.0.0Compare Source
81aa06bUpgrade: espree@6.0.0 (#11869) (Teddy Katz)5f022bcFix: no-else-return autofix produces name collisions (fixes #11069) (#11867) (Milos Djermanovic)ded9548Fix: multiline-comment-style incorrect message (#11864) (golopot)cad074dDocs: Add JSHint W047 compat to no-floating-decimal (#11861) (Timo Tijhof)41f6304Upgrade: sinon (#11855) (Toru Nagashima)167ce87Chore: remove unuseable profile command (#11854) (Toru Nagashima)c844c6fFix: max-len properly ignore trailing comments (fixes #11838) (#11841) (ZYSzys)1b5661aFix: no-var should not fix variables named 'let' (fixes #11830) (#11832) (Milos Djermanovic)4d75956Build: CI with Azure Pipelines (#11845) (Toru Nagashima)1db3462Chore: rm superfluous argument & fix perf-multifiles-targets (#11834) (薛定谔的猫)c57a4a4Upgrade: @babel/polyfill => core-js v3 (#11833) (薛定谔的猫)65faa04Docs: Clarify prefer-destructuring array/object difference (fixes #9970) (#11851) (Oliver Sieweke)81c3823Fix: require-atomic-updates reports parameters (fixes #11723) (#11774) (Toru Nagashima)aef8ea1Sponsors: Sync README with website (ESLint Jenkins)airbnb/javascript
v18.0.1Compare Source
v18.0.0Compare Source
prettier/eslint-config-prettier
v6.4.0Compare Source
(@yangmingshan)!
v6.3.0Compare Source
(@ybiquitous)!
v6.2.0Compare Source
rule][@typescript-eslint/quotes-special]). Thanks to Masafumi Koba
(@ybiquitous)!
v6.1.0Compare Source
Masafumi Koba (@ybiquitous)!
v6.0.0Compare Source
Changed: The CLI helper tool now considers [no-confusing-arrow] to conflict
if you use the default value of its
allowParensoption. The default waschanged to
truein ESLint 6, which conflicts with Prettier.If the CLI helper tool gives you errors about this after upgrading, the
solution is to change this:
{ "rules": { "no-confusing-arrow": ["error"] } }Into this:
{ "rules": { "no-confusing-arrow": ["error", { "allowParens": false }] } }The latter works in both ESLint 6 as well as in ESLint 5 and older.
Improved:
eslint --print-configusage instructions. The CLI tool helptext as well as the documentation has been updated to suggest commands that
work in ESLint 6.0 as well as in ESLint 5 and older. (Instead of
eslint --print-config ., useeslint --print-config path/to/main.js.)v5.1.0Compare Source
v5.0.0Compare Source
Removed: [react/self-closing-comp]. This rule was added in v4.1.0 not
because it conflicted with Prettier but because it was unnecessary when
using Prettier. However, in v1.18.0 [Prettier stopped converting empty
elements to self-closing elements][prettier-self-closing]. So the rule is
not unnecessary anymore.
If you use Prettier v1.17.1 or older you should be able t
Renovate configuration
📅 Schedule: "every weekend" in timezone Asia/Singapore.
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "
rebase!".👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Renovate Bot. View repository job log here.