Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency eslint to v7 #42614

Merged
merged 3 commits into from May 28, 2020
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 25, 2020

This PR contains the following updates:

Package Type Update Change
eslint (source) peerDependencies major ^6.0.0 -> ^7.0.0
eslint (source) dependencies major ^6.8.0 -> ^7.0.0

Release Notes

eslint/eslint

v7.1.0

Compare Source

v7.0.0

Compare Source


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner May 25, 2020 06:49
@renovate renovate bot added the [Type] Task label May 25, 2020
@matticbot
Copy link
Contributor

@renovate renovate bot added the Framework label May 25, 2020
@matticbot
Copy link
Contributor

matticbot commented May 25, 2020

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@scinos scinos self-assigned this May 25, 2020
@scinos
Copy link
Contributor

scinos commented May 26, 2020

eslint v7 breaks our custom rule i18n-ellipsis. See eslint/eslint#13360 for more details.

@renovate
Copy link
Contributor Author

renovate bot commented May 26, 2020

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@scinos scinos added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 26, 2020
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested the ESLint rule change locally and the error and auto-fix both worked.

@scinos scinos merged commit 4bd1eb4 into master May 28, 2020
@scinos scinos deleted the renovate/eslint-7.x branch May 28, 2020 08:01
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants